From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-GitPython: adopt orphaned package and update to 3.1.26.
Date: Sat, 12 Feb 2022 18:28:48 +0100 [thread overview]
Message-ID: <20220212172848.VRHxw1OJ_0NH-enFkkN2QZE4-sE9DjzUgER0ojRV-ns@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35536@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
New review comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/35536#discussion_r805183183
Comment:
You mean instead of pulling in and extracting the distfile? Should be possible, yeah. Is there a policy on this, when do we do cloning instead of extracting a checkout? Last time that topic come up, [the response was](https://github.com/void-linux/void-packages/pull/35082#issuecomment-1015415324):
> Cloning the git repo is generally undesirable with xbps-src.
In that case it would've been for generating the changelog, which would be done every time, so I didn't end up doing it, isolating it into the check stage that isn't automatically executed here made sense to me.
next prev parent reply other threads:[~2022-02-12 17:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 16:50 [PR PATCH] python3-GitPython: " jcgruenhage
2022-02-11 17:27 ` [PR PATCH] [Updated] " jcgruenhage
2022-02-12 17:05 ` [PR REVIEW] python3-GitPython: adopt orphaned package and " paper42
2022-02-12 17:05 ` paper42
2022-02-12 17:05 ` paper42
2022-02-12 17:05 ` paper42
2022-02-12 17:18 ` jcgruenhage
2022-02-12 17:28 ` jcgruenhage [this message]
2022-02-12 17:38 ` jcgruenhage
2022-02-12 17:42 ` jcgruenhage
2022-02-12 17:56 ` paper42
2022-02-12 17:58 ` paper42
2022-02-12 18:42 ` [PR PATCH] [Updated] " jcgruenhage
2022-02-12 18:46 ` [PR REVIEW] " jcgruenhage
2022-02-12 18:49 ` jcgruenhage
2022-02-12 18:49 ` jcgruenhage
2022-02-12 19:35 ` paper42
2022-02-12 19:35 ` paper42
2022-02-12 20:27 ` jcgruenhage
2022-02-12 21:43 ` paper42
2022-02-13 10:37 ` [PR PATCH] [Updated] " jcgruenhage
2022-02-13 10:40 ` [PR REVIEW] " jcgruenhage
2022-02-13 12:36 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220212172848.VRHxw1OJ_0NH-enFkkN2QZE4-sE9DjzUgER0ojRV-ns@z \
--to=jcgruenhage@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).