Github messages for voidlinux
 help / color / mirror / Atom feed
From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: conduit-0.3.0
Date: Sat, 12 Feb 2022 22:07:42 +0100	[thread overview]
Message-ID: <20220212210742.E7XGInPXH1YqdFjsCw-IW4d1VQm3IreIQaYsauJ3LPQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34568@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/34568#discussion_r805204427

Comment:
Sample config files should be installed using `vsconf`. That would put it into `/usr/share/examples/conduit`, which would be more appropriate anyway, IMO, as it makes it less probable that someone just installs conduit and enables it with the example config without adjusting stuff like the server domain.

  parent reply	other threads:[~2022-02-12 21:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 14:43 [PR PATCH] New package: conduit-0.2.0 TinfoilSubmarine
2022-01-27 15:26 ` steinex
2022-01-27 16:02 ` TinfoilSubmarine
2022-02-04 18:16 ` steinex
2022-02-04 19:12 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-02-04 19:13 ` New package: conduit-0.3.0 TinfoilSubmarine
2022-02-04 23:04 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-02-05 13:57 ` steinex
2022-02-05 14:04 ` TinfoilSubmarine
2022-02-06 23:48 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-02-12 21:07 ` jcgruenhage [this message]
2022-02-14  3:09 ` TinfoilSubmarine
2022-02-14 13:20 ` TinfoilSubmarine
2022-02-14 13:21 ` TinfoilSubmarine
2022-02-14 14:42 ` [PR REVIEW] " jcgruenhage
2022-02-14 15:34 ` TinfoilSubmarine
2022-02-14 15:34 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-02-15  3:20 ` TinfoilSubmarine
2022-03-18 13:40 ` TinfoilSubmarine
2022-03-18 13:40 ` TinfoilSubmarine
2022-03-18 13:41 ` TinfoilSubmarine
2022-03-18 13:45 ` TinfoilSubmarine
2022-03-25 22:12 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220212210742.E7XGInPXH1YqdFjsCw-IW4d1VQm3IreIQaYsauJ3LPQ@z \
    --to=jcgruenhage@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).