From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: ouch-0.3.1
Date: Sun, 13 Feb 2022 10:52:30 +0100 [thread overview]
Message-ID: <20220213095230.iPx_d4lQNxSZDuc2bkuq0w9zYy1Y__kxWgDxsYC-wCQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34931@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
New comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/34931#issuecomment-1037958445
Comment:
So, I was nerd-sniped a bit by this, and wanted to get the completions working at least locally. This turned out to be a slight bit more difficult than anticipated, resulting in two patches I've submit upstream (https://github.com/ouch-org/ouch/pull/251 and https://github.com/ouch-org/ouch/pull/252). One for allowing to override the location of the completions, and one for working around https://github.com/clap-rs/clap/issues/1596, which caused the generated completions to be faulty.
The resulting template and patches can be found at https://github.com/void-linux/void-packages/commit/44cefdee00b3b8ac0a309819fd3fbfce5e24bb08.
@ElDifinitivo Which one would you prefer, including those changes into your PR, or me opening a PR myself?
next prev parent reply other threads:[~2022-02-13 9:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 21:36 [PR PATCH] " ElDifinitivo
2022-01-07 21:39 ` [PR REVIEW] " abenson
2022-01-07 21:39 ` abenson
2022-01-07 21:57 ` [PR PATCH] [Updated] " ElDifinitivo
2022-01-14 15:26 ` ElDifinitivo
2022-02-13 9:27 ` jcgruenhage
2022-02-13 9:52 ` jcgruenhage [this message]
2022-02-13 17:05 ` ElDifinitivo
2022-02-13 17:09 ` ElDifinitivo
2022-02-13 17:18 ` jcgruenhage
2022-02-13 19:25 ` [PR PATCH] [Updated] " ElDifinitivo
2022-02-14 7:20 ` paper42
2022-02-14 14:49 ` [PR PATCH] [Updated] " ElDifinitivo
2022-02-14 14:58 ` ElDifinitivo
2022-02-14 15:55 ` ElDifinitivo
2022-02-14 15:57 ` ElDifinitivo
2022-02-28 15:28 ` ElDifinitivo
2022-03-03 20:04 ` ElDifinitivo
2022-03-03 21:50 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220213095230.iPx_d4lQNxSZDuc2bkuq0w9zYy1Y__kxWgDxsYC-wCQ@z \
--to=jcgruenhage@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).