From: Johnnynator <Johnnynator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Update kiwix-lib-10.0.1 kiwix-tools-3.2.0 libzim-7.2.0 zim-tools-3.1.0
Date: Mon, 14 Feb 2022 19:13:42 +0100 [thread overview]
Message-ID: <20220214181342.mANLfVWRUZLPHy9-6fOGzR2NgTLYQpOpAnj7SMzy8gQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35607@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/35607#issuecomment-1039399973
Comment:
Looks good.
It would be nice if you could fix the tests. (you can pass `-Q` to `./xbps-src` to run them locally). E.g. libzim misses the files from the zim-testing-suite. Check: https://github.com/openzim/libzim/blob/master/scripts/download_test_data.py so `https://github.com/openzim/zim-testing-suite/releases/download/v0.3/zim-testing-suite-0.3.tar.gz` is needed as additional distfile.
next prev parent reply other threads:[~2022-02-14 18:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 8:28 [PR PATCH] " Animeshz
2022-02-14 18:13 ` Johnnynator [this message]
2022-02-15 9:45 ` [PR PATCH] [Updated] " Animeshz
2022-02-15 9:47 ` Animeshz
2022-02-15 9:54 ` Animeshz
2022-02-15 10:44 ` Animeshz
2022-02-15 11:42 ` Animeshz
2022-02-16 5:31 ` [PR PATCH] [Updated] " Animeshz
2022-02-16 5:32 ` Animeshz
2022-02-16 5:36 ` Animeshz
2022-02-16 7:32 ` [PR PATCH] [Updated] " Animeshz
2022-02-16 7:33 ` Animeshz
2022-02-16 7:55 ` [PR PATCH] [Updated] " Animeshz
2022-02-16 19:07 ` Animeshz
2022-03-05 17:14 ` paper42
2022-03-05 17:47 ` Animeshz
2022-06-24 2:16 ` github-actions
2022-07-09 2:13 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214181342.mANLfVWRUZLPHy9-6fOGzR2NgTLYQpOpAnj7SMzy8gQ@z \
--to=johnnynator@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).