Github messages for voidlinux
 help / color / mirror / Atom feed
From: tibequadorian <tibequadorian@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] libgsm: update to 1.0.19.
Date: Tue, 15 Feb 2022 21:07:26 +0100	[thread overview]
Message-ID: <20220215200726.1qS6niMfmWWVMEOBd7jOuqP6xon498AoAM_WtvbYaJc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35647@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages libgsm
https://github.com/void-linux/void-packages/pull/35647

libgsm: update to 1.0.19.
Old distfiles are apparently not deleted, so I changed them to upstream.
I also cleaned up the template a little bit and do the install using the Makefile target instead of doing this manually.
Currently libgsm-devel contains unnecessary header files, because all header files are just copied over.
Also includes manual pages now, which were not installed before.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35647.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libgsm-35647.patch --]
[-- Type: text/x-diff, Size: 2041 bytes --]

From 7a4ec44ea6b9a68c8a415c6d95fd349233d13f87 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Tue, 15 Feb 2022 20:50:54 +0100
Subject: [PATCH] libgsm: update to 1.0.19.

---
 srcpkgs/libgsm/template | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/srcpkgs/libgsm/template b/srcpkgs/libgsm/template
index b6ed1f427d67..208686a591d8 100644
--- a/srcpkgs/libgsm/template
+++ b/srcpkgs/libgsm/template
@@ -1,15 +1,14 @@
 # Template file for 'libgsm'
 pkgname=libgsm
-version=1.0.18
+version=1.0.19
 revision=1
-wrksrc="gsm-1.0-pl18"
-homepage="http://www.quut.com/gsm/"
-# old distfiles from $homepage are deleted when a new version is released
-distfiles="https://deb.debian.org/debian/pool/main/libg/libgsm/libgsm_$version.orig.tar.gz"
+wrksrc="gsm-${version%.*}-pl${version##*.}"
 short_desc="GSM 06.10 lossy speech compression"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="custom"
-checksum=04f68087c3348bf156b78d59f4d8aff545da7f6e14f33be8f47d33f4efae2a10
+license="custom:copyright"
+homepage="http://www.quut.com/gsm/"
+distfiles="http://www.quut.com/gsm/gsm-${version}.tar.gz"
+checksum=4903652f68a8c04d0041f0d19b1eb713ddcd2aa011c5e595b3b8bca2755270f6
 
 do_build() {
 	make CC=$CC LD=$CC AR=$AR CCFLAGS="$CFLAGS -c -DNeedFunctionPrototypes=1"
@@ -22,15 +21,13 @@ do_install() {
 	vmkdir usr/share/man/man3
 	vmkdir usr/share/man/man1
 
-	install -m755 bin/* ${DESTDIR}/usr/bin
-	install -m644 lib/*.a ${DESTDIR}/usr/lib
-	install -m644 inc/* ${DESTDIR}/usr/include/gsm
+	make INSTALL_ROOT="${DESTDIR}"/usr \
+	 GSM_INSTALL_INC="${DESTDIR}"/usr/include/gsm \
+	 GSM_INSTALL_MAN="${DESTDIR}"/usr/share/man/man3 \
+	 TOAST_INSTALL_MAN="${DESTDIR}"/usr/share/man/man1 install
 
-	vinstall lib/libgsm.so.1.0.13 755 usr/lib
-	vcopy lib/libgsm.so usr/lib
-	vcopy lib/libgsm.so.1 usr/lib
+	vcopy lib/libgsm.so* usr/lib
 
-	rm -f ${DESTDIR}/usr/include/gsm/*.orig
 	ln -sfr ${DESTDIR}/usr/include/gsm/gsm.h ${DESTDIR}/usr/include/gsm.h
 
 	vlicense COPYRIGHT

  reply	other threads:[~2022-02-15 20:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 20:02 [PR PATCH] " tibequadorian
2022-02-15 20:07 ` tibequadorian [this message]
2022-02-25 21:40 ` [PR REVIEW] " Piraty
2022-02-25 21:40 ` Piraty
2022-02-25 21:40 ` Piraty
2022-02-25 21:40 ` Piraty
2022-02-26  0:49 ` [PR PATCH] [Updated] " tibequadorian
2022-02-28  0:00 ` tibequadorian
2022-02-28  2:54 ` tibequadorian
2022-02-28 13:40 ` [PR PATCH] [Updated] " tibequadorian
2022-02-28 13:41 ` tibequadorian
2022-03-01 10:32 ` [PR PATCH] [Merged]: " Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220215200726.1qS6niMfmWWVMEOBd7jOuqP6xon498AoAM_WtvbYaJc@z \
    --to=tibequadorian@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).