From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: syncthing-gtk: restore sane versioning, fix tests
Date: Wed, 16 Feb 2022 00:20:25 +0100 [thread overview]
Message-ID: <20220215232025.gudXHKpBn20TZED6XGZB9AtAF0UGqxU6G_hr6UHOf0E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35586@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]
There's a merged pull request on the void-packages repository
syncthing-gtk: restore sane versioning, fix tests
https://github.com/void-linux/void-packages/pull/35586
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
cc @paper42
#### Testing the changes
- I tested the changes in this PR: **briefly**
The new debian version scheme did throw errors like
```
/usr/lib/python3.10/site-packages/pkg_resources/__init__.py:116: PkgResourcesDeprecationWarning: v0.9.4.4-ds-git20220108-9023143f8b93 is an invalid version and will not be supported in a future release
```
This PR restores the old versioning scheme by adding the the following precautions:
* Users on `0.9.4.4` get upgraded to this version due to revision (last in this scheme was 3)
* Users on `0.9.4.4+ds+git20220108+9023143f8b93` get reverted to the old versioning scheme but on this revision
On top of that I added some `checkdepends` to make the checks succeed atleast to a certain point. I'm totally unsure why this wasn't an issue in the past, did anything change there? However, I'm stuck with the check error as seen on CI. Help appreciated.
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
prev parent reply other threads:[~2022-02-15 23:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 16:17 [PR PATCH] syncthing-gtk: restore sane versioning steinex
2022-02-13 21:15 ` [PR REVIEW] " paper42
2022-02-13 21:15 ` paper42
2022-02-14 11:28 ` [PR PATCH] [Updated] " steinex
2022-02-14 11:32 ` [PR PATCH] [Updated] syncthing-gtk: restore sane versioning, fix tests steinex
2022-02-14 11:36 ` steinex
2022-02-14 20:22 ` [PR REVIEW] " paper42
2022-02-15 10:31 ` [PR PATCH] [Updated] " steinex
2022-02-15 23:20 ` paper42 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215232025.gudXHKpBn20TZED6XGZB9AtAF0UGqxU6G_hr6UHOf0E@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).