* [PR PATCH] colord-gtk: update to 0.3.0.
@ 2022-02-17 11:24 tibequadorian
2022-02-19 23:50 ` [PR REVIEW] " paper42
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: tibequadorian @ 2022-02-17 11:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
There is a new pull request by tibequadorian against master on the void-packages repository
https://github.com/tibequadorian/void-packages colord-gtk
https://github.com/void-linux/void-packages/pull/35663
colord-gtk: update to 0.3.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35663.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-colord-gtk-35663.patch --]
[-- Type: text/x-diff, Size: 2433 bytes --]
From 65f425f9fdceebf94ed8bc9fd39bf03c794ec4fd Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Thu, 17 Feb 2022 12:22:51 +0100
Subject: [PATCH] colord-gtk: update to 0.3.0.
---
common/shlibs | 1 +
srcpkgs/colord-gtk/template | 20 ++++++++++----------
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/common/shlibs b/common/shlibs
index 0c60260b4642..ace7f548afc7 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -1133,6 +1133,7 @@ libibus-1.0.so.5 ibus-1.4.99.20120917_1
libxapian.so.30 libxapian-1.4.0_1
libzeitgeist-1.0.so.1 libzeitgeist-0.3.18_1
libcolord-gtk.so.1 colord-gtk-0.1.23_1
+libcolord-gtk4.so.1 colord-gtk-0.3.0_1
libgdm.so.1 libgdm-3.6.0_1
libclutter-gst-2.0.so.0 clutter-gst-1.9.92_1
libcheese.so.8 libcheese-3.17.90_1
diff --git a/srcpkgs/colord-gtk/template b/srcpkgs/colord-gtk/template
index 634a9322dae3..fc7d36aee242 100644
--- a/srcpkgs/colord-gtk/template
+++ b/srcpkgs/colord-gtk/template
@@ -1,26 +1,26 @@
# Template file for 'colord-gtk'
pkgname=colord-gtk
-version=0.2.0
-revision=2
+version=0.3.0
+revision=1
build_style=meson
build_helper=gir
-configure_args="-Dtests=false -Dvapi=$(vopt_if vala true false)
- -Ddocs=$(vopt_if docs true false) -Dman=$(vopt_if man true false)"
+configure_args="-Dtests=false $(vopt_bool vala vapi) $(vopt_bool docs docs)
+ $(vopt_bool man man) $(vopt_bool gir introspection)"
hostmakedepends="pkg-config intltool glib-devel libxslt
$(vopt_if docs gtk-doc) $(vopt_if vala vala-devel)
$(vopt_if man docbook-xsl-ns)"
-makedepends="colord-devel gtk+3-devel"
+makedepends="colord-devel gtk+3-devel gtk4-devel"
short_desc="GTK support library for colord"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/hughsie/colord-gtk"
distfiles="${FREEDESKTOP_SITE}/colord/releases/${pkgname}-${version}.tar.xz"
-checksum=2a4cfae08bc69f000f40374934cd26f4ae86d286ce7de89f1622abc59644c717
+checksum=b9466656d66d9a6ffbc2dd04fa91c8f6af516bf9efaacb69744eec0f56f3c1d0
-build_options="vala docs man"
-build_options_default="vala"
-desc_option_docs="Generate documents"
-desc_option_man="Generate manpage"
+build_options="vala docs gir man"
+build_options_default="vala gir man"
+desc_option_docs="Generate documentation"
+desc_option_man="Generate man pages"
colord-gtk-devel_package() {
depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
@ 2022-02-19 23:50 ` paper42
2022-02-19 23:51 ` paper42
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-02-19 23:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35663#discussion_r810550104
Comment:
```suggestion
hostmakedepends="pkg-config gettext glib-devel libxslt
```
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
2022-02-19 23:50 ` [PR REVIEW] " paper42
@ 2022-02-19 23:51 ` paper42
2022-02-20 0:15 ` [PR PATCH] [Updated] " tibequadorian
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-02-19 23:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35663#discussion_r810550123
Comment:
```suggestion
homepage="https://github.com/hughsie/colord-gtk"
changelog="https://raw.githubusercontent.com/hughsie/colord-gtk/main/NEWS"
```
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
2022-02-19 23:50 ` [PR REVIEW] " paper42
2022-02-19 23:51 ` paper42
@ 2022-02-20 0:15 ` tibequadorian
2022-03-24 21:57 ` tibequadorian
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2022-02-20 0:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
There is an updated pull request by tibequadorian against master on the void-packages repository
https://github.com/tibequadorian/void-packages colord-gtk
https://github.com/void-linux/void-packages/pull/35663
colord-gtk: update to 0.3.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35663.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-colord-gtk-35663.patch --]
[-- Type: text/x-diff, Size: 2568 bytes --]
From eff684683d38c06cac67ca5691b6006e0e4a1646 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Thu, 17 Feb 2022 12:22:51 +0100
Subject: [PATCH] colord-gtk: update to 0.3.0.
---
common/shlibs | 1 +
srcpkgs/colord-gtk/template | 23 ++++++++++++-----------
2 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/common/shlibs b/common/shlibs
index 7c253776c381..beef7b5958cc 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -1133,6 +1133,7 @@ libibus-1.0.so.5 ibus-1.4.99.20120917_1
libxapian.so.30 libxapian-1.4.0_1
libzeitgeist-1.0.so.1 libzeitgeist-0.3.18_1
libcolord-gtk.so.1 colord-gtk-0.1.23_1
+libcolord-gtk4.so.1 colord-gtk-0.3.0_1
libgdm.so.1 libgdm-3.6.0_1
libclutter-gst-2.0.so.0 clutter-gst-1.9.92_1
libcheese.so.8 libcheese-3.17.90_1
diff --git a/srcpkgs/colord-gtk/template b/srcpkgs/colord-gtk/template
index 634a9322dae3..e54e068333e8 100644
--- a/srcpkgs/colord-gtk/template
+++ b/srcpkgs/colord-gtk/template
@@ -1,26 +1,27 @@
# Template file for 'colord-gtk'
pkgname=colord-gtk
-version=0.2.0
-revision=2
+version=0.3.0
+revision=1
build_style=meson
build_helper=gir
-configure_args="-Dtests=false -Dvapi=$(vopt_if vala true false)
- -Ddocs=$(vopt_if docs true false) -Dman=$(vopt_if man true false)"
-hostmakedepends="pkg-config intltool glib-devel libxslt
+configure_args="-Dtests=false $(vopt_bool vala vapi) $(vopt_bool docs docs)
+ $(vopt_bool man man) $(vopt_bool gir introspection)"
+hostmakedepends="pkg-config gettext glib-devel libxslt
$(vopt_if docs gtk-doc) $(vopt_if vala vala-devel)
$(vopt_if man docbook-xsl-ns)"
-makedepends="colord-devel gtk+3-devel"
+makedepends="colord-devel gtk+3-devel gtk4-devel"
short_desc="GTK support library for colord"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/hughsie/colord-gtk"
+changelog="https://raw.githubusercontent.com/hughsie/colord-gtk/main/NEWS"
distfiles="${FREEDESKTOP_SITE}/colord/releases/${pkgname}-${version}.tar.xz"
-checksum=2a4cfae08bc69f000f40374934cd26f4ae86d286ce7de89f1622abc59644c717
+checksum=b9466656d66d9a6ffbc2dd04fa91c8f6af516bf9efaacb69744eec0f56f3c1d0
-build_options="vala docs man"
-build_options_default="vala"
-desc_option_docs="Generate documents"
-desc_option_man="Generate manpage"
+build_options="vala docs gir man"
+build_options_default="vala gir man"
+desc_option_docs="Generate documentation"
+desc_option_man="Generate man pages"
colord-gtk-devel_package() {
depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
` (2 preceding siblings ...)
2022-02-20 0:15 ` [PR PATCH] [Updated] " tibequadorian
@ 2022-03-24 21:57 ` tibequadorian
2022-03-24 22:01 ` tibequadorian
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2022-03-24 21:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
There is an updated pull request by tibequadorian against master on the void-packages repository
https://github.com/tibequadorian/void-packages colord-gtk
https://github.com/void-linux/void-packages/pull/35663
colord-gtk: update to 0.3.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35663.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-colord-gtk-35663.patch --]
[-- Type: text/x-diff, Size: 2496 bytes --]
From f865d009d90d7a80b36cfc40ffe17075f36c3d9c Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Thu, 17 Feb 2022 12:22:51 +0100
Subject: [PATCH] colord-gtk: update to 0.3.0.
---
common/shlibs | 1 +
srcpkgs/colord-gtk/template | 21 +++++++++++----------
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/common/shlibs b/common/shlibs
index 2d8a8b8b0df3..0097d6027807 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -1133,6 +1133,7 @@ libibus-1.0.so.5 ibus-1.4.99.20120917_1
libxapian.so.30 libxapian-1.4.0_1
libzeitgeist-1.0.so.1 libzeitgeist-0.3.18_1
libcolord-gtk.so.1 colord-gtk-0.1.23_1
+libcolord-gtk4.so.1 colord-gtk-0.3.0_1
libgdm.so.1 libgdm-3.6.0_1
libclutter-gst-2.0.so.0 clutter-gst-1.9.92_1
libcheese.so.8 libcheese-3.17.90_1
diff --git a/srcpkgs/colord-gtk/template b/srcpkgs/colord-gtk/template
index 634a9322dae3..bc1c61bdf27f 100644
--- a/srcpkgs/colord-gtk/template
+++ b/srcpkgs/colord-gtk/template
@@ -1,26 +1,27 @@
# Template file for 'colord-gtk'
pkgname=colord-gtk
-version=0.2.0
-revision=2
+version=0.3.0
+revision=1
build_style=meson
build_helper=gir
-configure_args="-Dtests=false -Dvapi=$(vopt_if vala true false)
- -Ddocs=$(vopt_if docs true false) -Dman=$(vopt_if man true false)"
-hostmakedepends="pkg-config intltool glib-devel libxslt
+configure_args="-Dtests=false $(vopt_bool vala vapi) $(vopt_bool docs docs)
+ $(vopt_bool man man)"
+hostmakedepends="pkg-config gettext glib-devel libxslt
$(vopt_if docs gtk-doc) $(vopt_if vala vala-devel)
$(vopt_if man docbook-xsl-ns)"
-makedepends="colord-devel gtk+3-devel"
+makedepends="colord-devel gtk+3-devel gtk4-devel"
short_desc="GTK support library for colord"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/hughsie/colord-gtk"
+changelog="https://raw.githubusercontent.com/hughsie/colord-gtk/main/NEWS"
distfiles="${FREEDESKTOP_SITE}/colord/releases/${pkgname}-${version}.tar.xz"
-checksum=2a4cfae08bc69f000f40374934cd26f4ae86d286ce7de89f1622abc59644c717
+checksum=b9466656d66d9a6ffbc2dd04fa91c8f6af516bf9efaacb69744eec0f56f3c1d0
build_options="vala docs man"
-build_options_default="vala"
-desc_option_docs="Generate documents"
-desc_option_man="Generate manpage"
+build_options_default="vala man"
+desc_option_docs="Generate documentation"
+desc_option_man="Generate man pages"
colord-gtk-devel_package() {
depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
` (3 preceding siblings ...)
2022-03-24 21:57 ` tibequadorian
@ 2022-03-24 22:01 ` tibequadorian
2022-03-24 22:20 ` [PR REVIEW] " paper42
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2022-03-24 22:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/35663#issuecomment-1078424493
Comment:
Thank you, I should've noticed this. It seems that it's required when vala is enabled. The build option is probably useless anyway so I removed it now instead of adding additional checks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
` (4 preceding siblings ...)
2022-03-24 22:01 ` tibequadorian
@ 2022-03-24 22:20 ` paper42
2022-03-24 23:42 ` [PR PATCH] [Updated] " tibequadorian
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-03-24 22:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35663#discussion_r834778298
Comment:
docs should be at least moved to the -devel subpackage
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
` (5 preceding siblings ...)
2022-03-24 22:20 ` [PR REVIEW] " paper42
@ 2022-03-24 23:42 ` tibequadorian
2022-03-24 23:48 ` [PR REVIEW] " tibequadorian
2022-03-25 23:10 ` [PR PATCH] [Merged]: " paper42
8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2022-03-24 23:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
There is an updated pull request by tibequadorian against master on the void-packages repository
https://github.com/tibequadorian/void-packages colord-gtk
https://github.com/void-linux/void-packages/pull/35663
colord-gtk: update to 0.3.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35663.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-colord-gtk-35663.patch --]
[-- Type: text/x-diff, Size: 2697 bytes --]
From 9dd12a219487788a8eda210bc5a2592040aa2066 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Thu, 17 Feb 2022 12:22:51 +0100
Subject: [PATCH] colord-gtk: update to 0.3.0.
---
common/shlibs | 1 +
srcpkgs/colord-gtk/template | 24 ++++++++++++++----------
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/common/shlibs b/common/shlibs
index 2d8a8b8b0df3..0097d6027807 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -1133,6 +1133,7 @@ libibus-1.0.so.5 ibus-1.4.99.20120917_1
libxapian.so.30 libxapian-1.4.0_1
libzeitgeist-1.0.so.1 libzeitgeist-0.3.18_1
libcolord-gtk.so.1 colord-gtk-0.1.23_1
+libcolord-gtk4.so.1 colord-gtk-0.3.0_1
libgdm.so.1 libgdm-3.6.0_1
libclutter-gst-2.0.so.0 clutter-gst-1.9.92_1
libcheese.so.8 libcheese-3.17.90_1
diff --git a/srcpkgs/colord-gtk/template b/srcpkgs/colord-gtk/template
index 634a9322dae3..843320e63089 100644
--- a/srcpkgs/colord-gtk/template
+++ b/srcpkgs/colord-gtk/template
@@ -1,26 +1,27 @@
# Template file for 'colord-gtk'
pkgname=colord-gtk
-version=0.2.0
-revision=2
+version=0.3.0
+revision=1
build_style=meson
build_helper=gir
-configure_args="-Dtests=false -Dvapi=$(vopt_if vala true false)
- -Ddocs=$(vopt_if docs true false) -Dman=$(vopt_if man true false)"
-hostmakedepends="pkg-config intltool glib-devel libxslt
+configure_args="-Dtests=false $(vopt_bool vala vapi) $(vopt_bool docs docs)
+ $(vopt_bool man man)"
+hostmakedepends="pkg-config gettext glib-devel libxslt
$(vopt_if docs gtk-doc) $(vopt_if vala vala-devel)
$(vopt_if man docbook-xsl-ns)"
-makedepends="colord-devel gtk+3-devel"
+makedepends="colord-devel gtk+3-devel gtk4-devel"
short_desc="GTK support library for colord"
maintainer="Orphaned <orphan@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://github.com/hughsie/colord-gtk"
+changelog="https://raw.githubusercontent.com/hughsie/colord-gtk/main/NEWS"
distfiles="${FREEDESKTOP_SITE}/colord/releases/${pkgname}-${version}.tar.xz"
-checksum=2a4cfae08bc69f000f40374934cd26f4ae86d286ce7de89f1622abc59644c717
+checksum=b9466656d66d9a6ffbc2dd04fa91c8f6af516bf9efaacb69744eec0f56f3c1d0
build_options="vala docs man"
-build_options_default="vala"
-desc_option_docs="Generate documents"
-desc_option_man="Generate manpage"
+build_options_default="vala man docs"
+desc_option_docs="Generate documentation"
+desc_option_man="Generate man pages"
colord-gtk-devel_package() {
depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
@@ -33,5 +34,8 @@ colord-gtk-devel_package() {
if [ "$build_option_vala" ]; then
vmove usr/share/vala
fi
+ if [ "$build_option_docs" ]; then
+ vmove usr/share/gtk-doc
+ fi
}
}
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
` (6 preceding siblings ...)
2022-03-24 23:42 ` [PR PATCH] [Updated] " tibequadorian
@ 2022-03-24 23:48 ` tibequadorian
2022-03-25 23:10 ` [PR PATCH] [Merged]: " paper42
8 siblings, 0 replies; 10+ messages in thread
From: tibequadorian @ 2022-03-24 23:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/35663#discussion_r834840965
Comment:
Makes sense. I enabled docs by default now and I wonder if the build option is necessary at all...
Should I rename it to `gtk_doc` to make it consistent with other packages?
`gtk_doc` is also currently missing a description in options.description btw
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Merged]: colord-gtk: update to 0.3.0.
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
` (7 preceding siblings ...)
2022-03-24 23:48 ` [PR REVIEW] " tibequadorian
@ 2022-03-25 23:10 ` paper42
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-03-25 23:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
There's a merged pull request on the void-packages repository
colord-gtk: update to 0.3.0.
https://github.com/void-linux/void-packages/pull/35663
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-03-25 23:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-17 11:24 [PR PATCH] colord-gtk: update to 0.3.0 tibequadorian
2022-02-19 23:50 ` [PR REVIEW] " paper42
2022-02-19 23:51 ` paper42
2022-02-20 0:15 ` [PR PATCH] [Updated] " tibequadorian
2022-03-24 21:57 ` tibequadorian
2022-03-24 22:01 ` tibequadorian
2022-03-24 22:20 ` [PR REVIEW] " paper42
2022-03-24 23:42 ` [PR PATCH] [Updated] " tibequadorian
2022-03-24 23:48 ` [PR REVIEW] " tibequadorian
2022-03-25 23:10 ` [PR PATCH] [Merged]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).