* [PR PATCH] mpv-mpris: update to 0.6
@ 2022-02-13 19:03 corbmr
2022-02-13 19:46 ` Duncaen
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: corbmr @ 2022-02-13 19:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
There is a new pull request by corbmr against master on the void-packages repository
https://github.com/corbmr/void-packages master
https://github.com/void-linux/void-packages/pull/35592
mpv-mpris: update to 0.6
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, aarch64-glibc
I also updated the install directory to `etc/mpv/scripts` as stated in the [package homepage](673aff031e7cc741edea68d7b4b0103d7b031d4a55755abb9e1be5dd4ec4e969) is where mpv actually looks for scripts. It was not being located properly in `/usr/lib/mpv-mpris`.
A patch file from https://github.com/void-linux/void-packages/pull/35592.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-35592.patch --]
[-- Type: text/x-diff, Size: 1216 bytes --]
From 7dbabb5fee613f078d05a575bca3e6bea9d9099e Mon Sep 17 00:00:00 2001
From: Corbett Rider <corbmr@gmail.com>
Date: Sun, 13 Feb 2022 10:56:44 -0800
Subject: [PATCH] mpv-mpris: update to 0.6
---
srcpkgs/mpv-mpris/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/mpv-mpris/template b/srcpkgs/mpv-mpris/template
index 784b45db60c1..d9e5e4d251bf 100644
--- a/srcpkgs/mpv-mpris/template
+++ b/srcpkgs/mpv-mpris/template
@@ -1,7 +1,7 @@
# Template file for 'mpv-mpris'
pkgname=mpv-mpris
-version=0.5
-revision=2
+version=0.6
+revision=1
build_style=gnu-makefile
make_build_target=mpris.so
hostmakedepends="pkg-config"
@@ -12,11 +12,11 @@ maintainer="Alif Rachmawadi <arch@subosito.com>"
license="MIT"
homepage="https://github.com/hoyon/mpv-mpris"
distfiles="https://github.com/hoyon/mpv-mpris/archive/${version}.tar.gz"
-checksum=673aff031e7cc741edea68d7b4b0103d7b031d4a55755abb9e1be5dd4ec4e969
+checksum=8b4493cc29d09f175d6f55e6905e77429228b51241f2ae4c3681e35fefef9ae8
do_install() {
vlicense LICENSE
vdoc README.md
- vmkdir usr/lib/${pkgname}
- vinstall mpris.so 0644 usr/lib/${pkgname}
+ vmkdir etc/mpv/scripts
+ vinstall mpris.so 0644 etc/mpv/scripts
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mpv-mpris: update to 0.6
2022-02-13 19:03 [PR PATCH] mpv-mpris: update to 0.6 corbmr
@ 2022-02-13 19:46 ` Duncaen
2022-02-14 0:43 ` corbmr
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Duncaen @ 2022-02-13 19:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/35592#issuecomment-1038382417
Comment:
Not a fan of putting binaries in /etc, also would probably break current users of the package who load the plugin by configuring mpv.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mpv-mpris: update to 0.6
2022-02-13 19:03 [PR PATCH] mpv-mpris: update to 0.6 corbmr
2022-02-13 19:46 ` Duncaen
@ 2022-02-14 0:43 ` corbmr
2022-02-20 11:12 ` paper42
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: corbmr @ 2022-02-14 0:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by corbmr on void-packages repository
https://github.com/void-linux/void-packages/pull/35592#issuecomment-1038501155
Comment:
Would it make sense to make a link in `/etc/mpv/scripts` instead? Or just leave it as is
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mpv-mpris: update to 0.6
2022-02-13 19:03 [PR PATCH] mpv-mpris: update to 0.6 corbmr
2022-02-13 19:46 ` Duncaen
2022-02-14 0:43 ` corbmr
@ 2022-02-20 11:12 ` paper42
2022-06-24 2:16 ` github-actions
2022-06-24 19:24 ` [PR PATCH] [Closed]: " paper42
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-02-20 11:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35592#issuecomment-1046213948
Comment:
> Would it make sense to make a link in `/etc/mpv/scripts` instead? Or just leave it as is
The mpv-mpris makefile installs it to /var/lib, but also creates a link in /etc/mpv/scripts, so I think we should follow that.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mpv-mpris: update to 0.6
2022-02-13 19:03 [PR PATCH] mpv-mpris: update to 0.6 corbmr
` (2 preceding siblings ...)
2022-02-20 11:12 ` paper42
@ 2022-06-24 2:16 ` github-actions
2022-06-24 19:24 ` [PR PATCH] [Closed]: " paper42
4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-06-24 2:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/35592#issuecomment-1165111220
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Closed]: mpv-mpris: update to 0.6
2022-02-13 19:03 [PR PATCH] mpv-mpris: update to 0.6 corbmr
` (3 preceding siblings ...)
2022-06-24 2:16 ` github-actions
@ 2022-06-24 19:24 ` paper42
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-06-24 19:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
There's a closed pull request on the void-packages repository
mpv-mpris: update to 0.6
https://github.com/void-linux/void-packages/pull/35592
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, aarch64-glibc
I also updated the install directory to `etc/mpv/scripts` as stated in the [package homepage](673aff031e7cc741edea68d7b4b0103d7b031d4a55755abb9e1be5dd4ec4e969) is where mpv actually looks for scripts. It was not being located properly in `/usr/lib/mpv-mpris`.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-24 19:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 19:03 [PR PATCH] mpv-mpris: update to 0.6 corbmr
2022-02-13 19:46 ` Duncaen
2022-02-14 0:43 ` corbmr
2022-02-20 11:12 ` paper42
2022-06-24 2:16 ` github-actions
2022-06-24 19:24 ` [PR PATCH] [Closed]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).