Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New packages: gotify-cli-2.2.1, gotify-server-2.1.3, up_rewrite-1.1.1
Date: Sun, 20 Feb 2022 22:29:43 +0100	[thread overview]
Message-ID: <20220220212943.7O-1C3-FlJ2REdI0w1NG9ShNyttV_EWhdVxbK0rG5EI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34653@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34653#discussion_r810687053

Comment:
We should add `-X $go_import_path/config.Version=$version` to go ldflags

  parent reply	other threads:[~2022-02-20 21:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 23:19 [PR PATCH] New package: gotify-server-2.1.3 TinfoilSubmarine
2021-12-21 23:21 ` [PR PATCH] [Updated] " TinfoilSubmarine
2021-12-23 22:24 ` TinfoilSubmarine
2021-12-23 22:29 ` TinfoilSubmarine
2022-02-20 21:29 ` [PR REVIEW] New packages: gotify-cli-2.2.1, gotify-server-2.1.3, up_rewrite-1.1.1 paper42
2022-02-20 21:29 ` paper42 [this message]
2022-02-20 21:29 ` paper42
2022-02-20 21:29 ` paper42
2022-02-20 23:53 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-05-07 21:16 ` [PR REVIEW] " paper42
2022-05-09 13:48 ` TinfoilSubmarine
2022-05-09 13:49 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-05-09 15:36 ` TinfoilSubmarine
2022-05-09 15:57 ` [PR REVIEW] " paper42
2022-05-09 16:48 ` TinfoilSubmarine
2022-05-09 20:13 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220220212943.7O-1C3-FlJ2REdI0w1NG9ShNyttV_EWhdVxbK0rG5EI@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).