Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New Package: mold-1.0.3
@ 2022-02-02 20:13 basicfunc
  2022-02-02 20:20 ` [PR REVIEW] " kawaiiamber
                   ` (34 more replies)
  0 siblings, 35 replies; 37+ messages in thread
From: basicfunc @ 2022-02-02 20:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

There is a new pull request by basicfunc against master on the void-packages repository

https://github.com/basicfunc/void-packages mold
https://github.com/void-linux/void-packages/pull/35361

New Package: mold-1.0.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

This PR is continuation of [PR 35305](https://github.com/void-linux/void-packages/pull/35305) as I really messed up things.

A patch file from https://github.com/void-linux/void-packages/pull/35361.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mold-35361.patch --]
[-- Type: text/x-diff, Size: 1249 bytes --]

From ab7ac2ce11f2ba06d44722f2aa52e8dae652e500 Mon Sep 17 00:00:00 2001
From: Rahul <basicfunc@gmail.com>
Date: Thu, 3 Feb 2022 01:35:52 +0530
Subject: [PATCH] New Package: mold-1.0.3

---
 srcpkgs/mold/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/mold/template

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
new file mode 100644
index 000000000000..44bcf3660c2e
--- /dev/null
+++ b/srcpkgs/mold/template
@@ -0,0 +1,23 @@
+# Template file for 'mold'
+pkgname=mold
+version=1.0.3
+revision=1
+archs="x86_64 x86_64-musl"
+build_style=gnu-makefile
+hostmakedepends="cmake pkg-config"
+makedepends="libstdc++-devel ripgrep openssl-devel zlib-devel"
+short_desc="High-performance drop-in replacement for existing Unix linkers"
+maintainer="Rahul <basicfunc@gmail.com>"
+license="AGPL-3.0-only"
+homepage="https://github.com/rui314/mold"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=488c12058b4c7c77bff94c6f919e40b2f12c304214e2e0d7d4833c21167837c0
+
+pre_patch() {
+    # chroot-grep is built without PCRE support, so we use ripgrep instead
+    vsed -i test/*.sh -e "s/grep -P/rg -P/;s/rg -\([a-yA-Z]*\)z/rg -\1U/"
+}
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
@ 2022-02-02 20:20 ` kawaiiamber
  2022-02-03  7:17 ` [PR PATCH] [Updated] " basicfunc
                   ` (33 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-02 20:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r797981025

Comment:
x86_64* will include musl. Why restrict archs here beyond just libc?

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
  2022-02-02 20:20 ` [PR REVIEW] " kawaiiamber
@ 2022-02-03  7:17 ` basicfunc
  2022-02-03  7:17 ` [PR REVIEW] " basicfunc
                   ` (32 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-03  7:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

There is an updated pull request by basicfunc against master on the void-packages repository

https://github.com/basicfunc/void-packages mold
https://github.com/void-linux/void-packages/pull/35361

New Package: mold-1.0.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

This PR is continuation of [PR 35305](https://github.com/void-linux/void-packages/pull/35305) as I really messed up things.

A patch file from https://github.com/void-linux/void-packages/pull/35361.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mold-35361.patch --]
[-- Type: text/x-diff, Size: 1923 bytes --]

From ab7ac2ce11f2ba06d44722f2aa52e8dae652e500 Mon Sep 17 00:00:00 2001
From: Rahul <basicfunc@gmail.com>
Date: Thu, 3 Feb 2022 01:35:52 +0530
Subject: [PATCH 1/2] New Package: mold-1.0.3

---
 srcpkgs/mold/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/mold/template

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
new file mode 100644
index 000000000000..44bcf3660c2e
--- /dev/null
+++ b/srcpkgs/mold/template
@@ -0,0 +1,23 @@
+# Template file for 'mold'
+pkgname=mold
+version=1.0.3
+revision=1
+archs="x86_64 x86_64-musl"
+build_style=gnu-makefile
+hostmakedepends="cmake pkg-config"
+makedepends="libstdc++-devel ripgrep openssl-devel zlib-devel"
+short_desc="High-performance drop-in replacement for existing Unix linkers"
+maintainer="Rahul <basicfunc@gmail.com>"
+license="AGPL-3.0-only"
+homepage="https://github.com/rui314/mold"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=488c12058b4c7c77bff94c6f919e40b2f12c304214e2e0d7d4833c21167837c0
+
+pre_patch() {
+    # chroot-grep is built without PCRE support, so we use ripgrep instead
+    vsed -i test/*.sh -e "s/grep -P/rg -P/;s/rg -\([a-yA-Z]*\)z/rg -\1U/"
+}
+
+post_install() {
+	vlicense LICENSE
+}

From 646b8f878d9422b99d25555088eef29dfc676fb7 Mon Sep 17 00:00:00 2001
From: Rahul <84739019+basicfunc@users.noreply.github.com>
Date: Thu, 3 Feb 2022 12:47:15 +0530
Subject: [PATCH 2/2] Update template

---
 srcpkgs/mold/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
index 44bcf3660c2e..26457828aae2 100644
--- a/srcpkgs/mold/template
+++ b/srcpkgs/mold/template
@@ -2,7 +2,7 @@
 pkgname=mold
 version=1.0.3
 revision=1
-archs="x86_64 x86_64-musl"
+archs="x86_64*"
 build_style=gnu-makefile
 hostmakedepends="cmake pkg-config"
 makedepends="libstdc++-devel ripgrep openssl-devel zlib-devel"

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
  2022-02-02 20:20 ` [PR REVIEW] " kawaiiamber
  2022-02-03  7:17 ` [PR PATCH] [Updated] " basicfunc
@ 2022-02-03  7:17 ` basicfunc
  2022-02-21  6:49 ` [PR PATCH] [Updated] " basicfunc
                   ` (31 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-03  7:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r798278751

Comment:
Fixed.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (2 preceding siblings ...)
  2022-02-03  7:17 ` [PR REVIEW] " basicfunc
@ 2022-02-21  6:49 ` basicfunc
  2022-02-21  6:50 ` basicfunc
                   ` (30 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  6:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

There is an updated pull request by basicfunc against master on the void-packages repository

https://github.com/basicfunc/void-packages mold
https://github.com/void-linux/void-packages/pull/35361

New Package: mold-1.0.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

This PR is continuation of [PR 35305](https://github.com/void-linux/void-packages/pull/35305) as I really messed up things.

A patch file from https://github.com/void-linux/void-packages/pull/35361.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mold-35361.patch --]
[-- Type: text/x-diff, Size: 1923 bytes --]

From ab7ac2ce11f2ba06d44722f2aa52e8dae652e500 Mon Sep 17 00:00:00 2001
From: Rahul <basicfunc@gmail.com>
Date: Thu, 3 Feb 2022 01:35:52 +0530
Subject: [PATCH 1/2] New Package: mold-1.0.3

---
 srcpkgs/mold/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/mold/template

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
new file mode 100644
index 000000000000..44bcf3660c2e
--- /dev/null
+++ b/srcpkgs/mold/template
@@ -0,0 +1,23 @@
+# Template file for 'mold'
+pkgname=mold
+version=1.0.3
+revision=1
+archs="x86_64 x86_64-musl"
+build_style=gnu-makefile
+hostmakedepends="cmake pkg-config"
+makedepends="libstdc++-devel ripgrep openssl-devel zlib-devel"
+short_desc="High-performance drop-in replacement for existing Unix linkers"
+maintainer="Rahul <basicfunc@gmail.com>"
+license="AGPL-3.0-only"
+homepage="https://github.com/rui314/mold"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=488c12058b4c7c77bff94c6f919e40b2f12c304214e2e0d7d4833c21167837c0
+
+pre_patch() {
+    # chroot-grep is built without PCRE support, so we use ripgrep instead
+    vsed -i test/*.sh -e "s/grep -P/rg -P/;s/rg -\([a-yA-Z]*\)z/rg -\1U/"
+}
+
+post_install() {
+	vlicense LICENSE
+}

From 646b8f878d9422b99d25555088eef29dfc676fb7 Mon Sep 17 00:00:00 2001
From: Rahul <84739019+basicfunc@users.noreply.github.com>
Date: Thu, 3 Feb 2022 12:47:15 +0530
Subject: [PATCH 2/2] Update template

---
 srcpkgs/mold/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
index 44bcf3660c2e..26457828aae2 100644
--- a/srcpkgs/mold/template
+++ b/srcpkgs/mold/template
@@ -2,7 +2,7 @@
 pkgname=mold
 version=1.0.3
 revision=1
-archs="x86_64 x86_64-musl"
+archs="x86_64*"
 build_style=gnu-makefile
 hostmakedepends="cmake pkg-config"
 makedepends="libstdc++-devel ripgrep openssl-devel zlib-devel"

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR PATCH] [Updated] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (3 preceding siblings ...)
  2022-02-21  6:49 ` [PR PATCH] [Updated] " basicfunc
@ 2022-02-21  6:50 ` basicfunc
  2022-02-21  6:53 ` basicfunc
                   ` (29 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  6:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

There is an updated pull request by basicfunc against master on the void-packages repository

https://github.com/basicfunc/void-packages mold
https://github.com/void-linux/void-packages/pull/35361

New Package: mold-1.0.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

This PR is continuation of [PR 35305](https://github.com/void-linux/void-packages/pull/35305) as I really messed up things.

A patch file from https://github.com/void-linux/void-packages/pull/35361.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mold-35361.patch --]
[-- Type: text/x-diff, Size: 2935 bytes --]

From ab7ac2ce11f2ba06d44722f2aa52e8dae652e500 Mon Sep 17 00:00:00 2001
From: Rahul <basicfunc@gmail.com>
Date: Thu, 3 Feb 2022 01:35:52 +0530
Subject: [PATCH 1/3] New Package: mold-1.0.3

---
 srcpkgs/mold/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/mold/template

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
new file mode 100644
index 000000000000..44bcf3660c2e
--- /dev/null
+++ b/srcpkgs/mold/template
@@ -0,0 +1,23 @@
+# Template file for 'mold'
+pkgname=mold
+version=1.0.3
+revision=1
+archs="x86_64 x86_64-musl"
+build_style=gnu-makefile
+hostmakedepends="cmake pkg-config"
+makedepends="libstdc++-devel ripgrep openssl-devel zlib-devel"
+short_desc="High-performance drop-in replacement for existing Unix linkers"
+maintainer="Rahul <basicfunc@gmail.com>"
+license="AGPL-3.0-only"
+homepage="https://github.com/rui314/mold"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=488c12058b4c7c77bff94c6f919e40b2f12c304214e2e0d7d4833c21167837c0
+
+pre_patch() {
+    # chroot-grep is built without PCRE support, so we use ripgrep instead
+    vsed -i test/*.sh -e "s/grep -P/rg -P/;s/rg -\([a-yA-Z]*\)z/rg -\1U/"
+}
+
+post_install() {
+	vlicense LICENSE
+}

From 646b8f878d9422b99d25555088eef29dfc676fb7 Mon Sep 17 00:00:00 2001
From: Rahul <84739019+basicfunc@users.noreply.github.com>
Date: Thu, 3 Feb 2022 12:47:15 +0530
Subject: [PATCH 2/3] Update template

---
 srcpkgs/mold/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
index 44bcf3660c2e..26457828aae2 100644
--- a/srcpkgs/mold/template
+++ b/srcpkgs/mold/template
@@ -2,7 +2,7 @@
 pkgname=mold
 version=1.0.3
 revision=1
-archs="x86_64 x86_64-musl"
+archs="x86_64*"
 build_style=gnu-makefile
 hostmakedepends="cmake pkg-config"
 makedepends="libstdc++-devel ripgrep openssl-devel zlib-devel"

From e971b35f3a64df15fec45bc17c204a488b5622d3 Mon Sep 17 00:00:00 2001
From: Rahul <basicfunc@gmail.com>
Date: Mon, 21 Feb 2022 12:18:07 +0530
Subject: [PATCH 3/3] Updated mold to v1.1

---
 srcpkgs/mold/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
index 44bcf3660c2e..f256fd979ff3 100644
--- a/srcpkgs/mold/template
+++ b/srcpkgs/mold/template
@@ -1,6 +1,6 @@
 # Template file for 'mold'
 pkgname=mold
-version=1.0.3
+version=1.1
 revision=1
 archs="x86_64 x86_64-musl"
 build_style=gnu-makefile
@@ -11,7 +11,7 @@ maintainer="Rahul <basicfunc@gmail.com>"
 license="AGPL-3.0-only"
 homepage="https://github.com/rui314/mold"
 distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
-checksum=488c12058b4c7c77bff94c6f919e40b2f12c304214e2e0d7d4833c21167837c0
+checksum=2f04bb2cd58797258c4f5f6f29fd2667f8b6c6b2bc76c731fede526884ea9a0c
 
 pre_patch() {
     # chroot-grep is built without PCRE support, so we use ripgrep instead

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (4 preceding siblings ...)
  2022-02-21  6:50 ` basicfunc
@ 2022-02-21  6:53 ` basicfunc
  2022-02-21  7:00 ` kawaiiamber
                   ` (28 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  6:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046528735

Comment:
@paper42 @kawaiiamber, I updated mold to v1.1, can you review it.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (5 preceding siblings ...)
  2022-02-21  6:53 ` basicfunc
@ 2022-02-21  7:00 ` kawaiiamber
  2022-02-21  7:00 ` [PR REVIEW] " kawaiiamber
                   ` (27 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  7:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046532108

Comment:
Squash your 6 commits to 1. `git rebase -i HEAD~6` and squash the last 5. Commit message should just be "New package: mold-1.0.3"

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (6 preceding siblings ...)
  2022-02-21  7:00 ` kawaiiamber
@ 2022-02-21  7:00 ` kawaiiamber
  2022-02-21  7:01 ` kawaiiamber
                   ` (26 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  7:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810824795

Comment:
Why limit the archs?

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (7 preceding siblings ...)
  2022-02-21  7:00 ` [PR REVIEW] " kawaiiamber
@ 2022-02-21  7:01 ` kawaiiamber
  2022-02-21  7:05 ` kawaiiamber
                   ` (25 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  7:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810825224

Comment:
Does it really not build without specifying `libstdc++-devel` pkg in `makedepends`?

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (8 preceding siblings ...)
  2022-02-21  7:01 ` kawaiiamber
@ 2022-02-21  7:05 ` kawaiiamber
  2022-02-21  7:39 ` [PR REVIEW] " basicfunc
                   ` (24 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  7:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046532108

Comment:
Squash your 6 commits to 1. `git rebase -i HEAD~6` and squash the last 5. Commit message should just be "New package: mold-1.0.3" Also consider updating the PR name itself to reflect the new version.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (9 preceding siblings ...)
  2022-02-21  7:05 ` kawaiiamber
@ 2022-02-21  7:39 ` basicfunc
  2022-02-21  7:39 ` basicfunc
                   ` (23 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  7:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810845405

Comment:
The author explicitly mentions it, I'll test without it.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (10 preceding siblings ...)
  2022-02-21  7:39 ` [PR REVIEW] " basicfunc
@ 2022-02-21  7:39 ` basicfunc
  2022-02-21  7:48 ` kawaiiamber
                   ` (22 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  7:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810845651

Comment:
Because I haven't yet tested it on another architectures.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (11 preceding siblings ...)
  2022-02-21  7:39 ` basicfunc
@ 2022-02-21  7:48 ` kawaiiamber
  2022-02-21  7:49 ` basicfunc
                   ` (21 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  7:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810850788

Comment:
Try testing it on other archs. -Q option is xbps-src script. The Manual.md file in the repo will welp.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (12 preceding siblings ...)
  2022-02-21  7:48 ` kawaiiamber
@ 2022-02-21  7:49 ` basicfunc
  2022-02-21  7:51 ` basicfunc
                   ` (20 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  7:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New review comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810851652

Comment:
It's important as `libstdc++` brings `std` library for C++, it brings functions like `strdup`, `memcmp` and many others and both `gcc` and `clang` pulls `libstdc++-devel` as dependency. 

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (13 preceding siblings ...)
  2022-02-21  7:49 ` basicfunc
@ 2022-02-21  7:51 ` basicfunc
  2022-02-21  7:52 ` kawaiiamber
                   ` (19 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  7:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New review comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810853011

Comment:
>mold is written in C++20, so if you build mold yourself, you need a recent version of a C++ compiler and a C++ standard library.

From [mold](https://github.com/rui314/mold#how-to-build)'s github

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (14 preceding siblings ...)
  2022-02-21  7:51 ` basicfunc
@ 2022-02-21  7:52 ` kawaiiamber
  2022-02-21  8:04 ` basicfunc
                   ` (18 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  7:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810853450

Comment:
if gcc and clang pull them as dependencies, you don't need to add them yourself

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (15 preceding siblings ...)
  2022-02-21  7:52 ` kawaiiamber
@ 2022-02-21  8:04 ` basicfunc
  2022-02-21  8:04 ` basicfunc
                   ` (17 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  8:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810860845

Comment:
Yeah, I will do that and update template accordingly.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (16 preceding siblings ...)
  2022-02-21  8:04 ` basicfunc
@ 2022-02-21  8:04 ` basicfunc
  2022-02-21  8:14 ` kawaiiamber
                   ` (16 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  8:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810861142

Comment:
> if gcc and clang pull them as dependencies, you don't need to add them yourself

Ok, I'll remove it

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (17 preceding siblings ...)
  2022-02-21  8:04 ` basicfunc
@ 2022-02-21  8:14 ` kawaiiamber
  2022-02-21  8:15 ` kawaiiamber
                   ` (15 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  8:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046583054

Comment:
From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (18 preceding siblings ...)
  2022-02-21  8:14 ` kawaiiamber
@ 2022-02-21  8:15 ` kawaiiamber
  2022-02-21  9:24 ` [PR REVIEW] " basicfunc
                   ` (14 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  8:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046583054

Comment:
From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (19 preceding siblings ...)
  2022-02-21  8:15 ` kawaiiamber
@ 2022-02-21  9:24 ` basicfunc
  2022-02-21  9:24 ` basicfunc
                   ` (13 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  9:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 7828 bytes --]

New review comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810925426

Comment:

```
void-packages on  mold [!] ❯ ./xbps-src -a aarch64 -Q -j4 pkg mold
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating repositories for target (aarch64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/aarch64/aarch64-repodata' ...
aarch64-repodata: 1591KB [avg rate: 282KB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/aarch64/nonfree/aarch64-repodata' ...
aarch64-repodata: 4962B [avg rate: 61MB/s]
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/aarch64/debug/aarch64-repodata' ...
aarch64-repodata: 713KB [avg rate: 268KB/s]
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> mold-1.1_1: removing autodeps, please wait...
=> mold-1.1_1: removing autocrossdeps, please wait...
=> ERROR: mold-1.1_1: this package cannot be built for aarch64.
void-packages on  mold [!] took 15s ❯ ./xbps-src -a mips pkg mold
ERROR: XBPS_CROSS_TRIPLET is not defined!
```

```
void-packages on  mold [!] ❯ ./xbps-src -a mips-musl pkg mold
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating repositories for target (mips-musl)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/mips-musl-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/musl/mips-musl-repodata': Not Found
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/mips-musl-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/mips-musl-repodata': Not Found
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/debug/mips-musl-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/musl/debug/mips-musl-repodata': Not Found
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> mold-1.1_1: removing autodeps, please wait...
=> mold-1.1_1: removing autocrossdeps, please wait...
=> ERROR: mold-1.1_1: this package cannot be built for mips-musl.
```

```
void-packages on  mold [!] took 7s ❯ ./xbps-src -a mipshf-musl pkg mold
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating repositories for target (mipshf-musl)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/mipshf-musl-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/musl/mipshf-musl-repodata': Not Found
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/mipshf-musl-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/mipshf-musl-repodata': Not Found
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/debug/mipshf-musl-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/musl/debug/mipshf-musl-repodata': Not Found
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> mold-1.1_1: removing autodeps, please wait...
=> mold-1.1_1: removing autocrossdeps, please wait...
=> ERROR: mold-1.1_1: this package cannot be built for mipshf-musl.
```

```
void-packages on  mold [!] took 7s ❯ ./xbps-src -a ppc pkg mold
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating repositories for target (ppc)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/ppc-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/ppc-repodata': Not Found
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/ppc-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/nonfree/ppc-repodata': Not Found
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/ppc-repodata' ...
ERROR: [reposync] failed to fetch file `https://alpha.de.repo.voidlinux.org/current/debug/ppc-repodata': Not Found
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> mold-1.1_1: removing autodeps, please wait...
=> mold-1.1_1: removing autocrossdeps, please wait...
=> ERROR: mold-1.1_1: this package cannot be built for ppc.
```

```
void-packages on  mold [!] took 7s ❯ ./xbps-src -a i686 pkg mold
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating repositories for target (i686)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/i686-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/i686-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/i686-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> mold-1.1_1: removing autodeps, please wait...
=> mold-1.1_1: removing autocrossdeps, please wait...
=> ERROR: mold-1.1_1: this package cannot be built for i686.
```

I think, it can only build for `x86_64`

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (20 preceding siblings ...)
  2022-02-21  9:24 ` [PR REVIEW] " basicfunc
@ 2022-02-21  9:24 ` basicfunc
  2022-02-21  9:45 ` [PR REVIEW] " kawaiiamber
                   ` (12 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: basicfunc @ 2022-02-21  9:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046648050

Comment:
> From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.

Can't I skip tests? As it's a release build and already go through a lot of tests.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (21 preceding siblings ...)
  2022-02-21  9:24 ` basicfunc
@ 2022-02-21  9:45 ` kawaiiamber
  2022-02-21  9:46 ` kawaiiamber
                   ` (11 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810944839

Comment:
Look at what it's saying. It's failing to fetch / sync - not failing to build.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (22 preceding siblings ...)
  2022-02-21  9:45 ` [PR REVIEW] " kawaiiamber
@ 2022-02-21  9:46 ` kawaiiamber
  2022-02-21  9:48 ` kawaiiamber
                   ` (10 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046670284

Comment:
Yes. You can skip CI while you're working on a package. See [Contributing](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md).
> Continuous Integration

> Pull requests are automatically submitted for Continuous Integration (CI) testing to ensure packages build and pass their tests (on native builds) on various combinations of C library and architecture. Packages that take longer than 120 minutes or need more than 14G of storage to complete their build (for example, Firefox or the Linux kernel) will fail CI and should include [ci skip] in the PR title or body (the comment field when the PR is being opened) to avoid wasting CI builder time.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (23 preceding siblings ...)
  2022-02-21  9:46 ` kawaiiamber
@ 2022-02-21  9:48 ` kawaiiamber
  2022-02-21  9:50 ` kawaiiamber
                   ` (9 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046670284

Comment:
Yes. You can skip CI while you're working on a package. See [Contributing](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md).
> Continuous Integration

> Pull requests are automatically submitted for Continuous Integration (CI) testing to ensure packages build and pass their tests (on native builds) on various combinations of C library and architecture. Packages that take longer than 120 minutes or need more than 14G of storage to complete their build (for example, Firefox or the Linux kernel) will fail CI and should include [ci skip] in the PR title or body (the comment field when the PR is being opened) to avoid wasting CI builder time.

You can also name PR to `[WIP] New package: mold-1.1` (the p in package is technically supposed to be lowercase) to indicate that the package is still being worked on.

Executive summary:
* put `[ci skip]` in your PR.
* put [WIP] in PR name

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (24 preceding siblings ...)
  2022-02-21  9:48 ` kawaiiamber
@ 2022-02-21  9:50 ` kawaiiamber
  2022-02-21  9:52 ` kawaiiamber
                   ` (8 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. Consider using checkdepends if `clang` is only needed for the checks.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (25 preceding siblings ...)
  2022-02-21  9:50 ` kawaiiamber
@ 2022-02-21  9:52 ` kawaiiamber
  2022-02-21  9:53 ` kawaiiamber
                   ` (7 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. Consider using `checkdepends` if `clang` is only needed for the checks.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (26 preceding siblings ...)
  2022-02-21  9:52 ` kawaiiamber
@ 2022-02-21  9:53 ` kawaiiamber
  2022-02-21  9:53 ` kawaiiamber
                   ` (6 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046583054

Comment:
From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `checkdepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (27 preceding siblings ...)
  2022-02-21  9:53 ` kawaiiamber
@ 2022-02-21  9:53 ` kawaiiamber
  2022-02-21  9:55 ` [PR REVIEW] " kawaiiamber
                   ` (5 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. It is preferred to try and fix checks rather than abandon them. Consider using `checkdepends` if `clang` is only needed for the checks.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (28 preceding siblings ...)
  2022-02-21  9:53 ` kawaiiamber
@ 2022-02-21  9:55 ` kawaiiamber
  2022-02-21  9:57 ` kawaiiamber
                   ` (4 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r810850788

Comment:
Try testing it on other archs. `-a` option is xbps-src script. The Manual.md file in the repo will welp.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (29 preceding siblings ...)
  2022-02-21  9:55 ` [PR REVIEW] " kawaiiamber
@ 2022-02-21  9:57 ` kawaiiamber
  2022-02-21  9:58 ` kawaiiamber
                   ` (3 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. Consider using `checkdepends` if `clang` is only needed for the checks.

In general, it is heavily preferred to try and fix checks rather than abandon them. From [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md):
> Runtime testing of packages and building with the -Q flag or with XBPS_CHECK_PKGS=yes set in the environment or etc/conf are strongly encouraged. New packages will not be accepted unless they have been runtime tested.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (30 preceding siblings ...)
  2022-02-21  9:57 ` kawaiiamber
@ 2022-02-21  9:58 ` kawaiiamber
  2022-02-21 10:00 ` kawaiiamber
                   ` (2 subsequent siblings)
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21  9:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046670284

Comment:
Yes. You can skip CI while you're working on a package. See [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md).
> Continuous Integration

> Pull requests are automatically submitted for Continuous Integration (CI) testing to ensure packages build and pass their tests (on native builds) on various combinations of C library and architecture. Packages that take longer than 120 minutes or need more than 14G of storage to complete their build (for example, Firefox or the Linux kernel) will fail CI and should include [ci skip] in the PR title or body (the comment field when the PR is being opened) to avoid wasting CI builder time.

You can also name PR to `[WIP] New package: mold-1.1` (the p in package is technically supposed to be lowercase) to indicate that the package is still being worked on.

Executive summary:
* put `[ci skip]` in your PR.
* put [WIP] in PR name

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (31 preceding siblings ...)
  2022-02-21  9:58 ` kawaiiamber
@ 2022-02-21 10:00 ` kawaiiamber
  2022-02-22 17:59 ` [PR REVIEW] " Chocimier
  2022-02-22 18:02 ` Chocimier
  34 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-21 10:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. Consider using `checkdepends` if `clang` is only needed for the checks.

In general, it is heavily preferred to try and fix checks rather than abandon them. From [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md):
> Runtime testing of packages and building with the -Q flag or with XBPS_CHECK_PKGS=yes set in the environment or etc/conf are strongly encouraged. New packages will not be accepted unless they have been runtime tested.

Keep in mind, *they* do checks for a release build. When we fetch and build it, it's important to check it.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: [PR REVIEW] New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (32 preceding siblings ...)
  2022-02-21 10:00 ` kawaiiamber
@ 2022-02-22 17:59 ` Chocimier
  2022-02-22 18:02 ` Chocimier
  34 siblings, 0 replies; 37+ messages in thread
From: Chocimier @ 2022-02-22 17:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#discussion_r812216405

Comment:
"this package cannot be built for" is a message one see when `archs=` is set. Remove it before building for other archs.

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New Package: mold-1.0.3
  2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
                   ` (33 preceding siblings ...)
  2022-02-22 17:59 ` [PR REVIEW] " Chocimier
@ 2022-02-22 18:02 ` Chocimier
  34 siblings, 0 replies; 37+ messages in thread
From: Chocimier @ 2022-02-22 18:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1048067713

Comment:
#31706 is packaging mimalloc separately, and pass more tests

^ permalink raw reply	[flat|nested] 37+ messages in thread

* Re: New package: mold-1.0.3
  2022-01-31 20:04 [PR PATCH] New package: mold-1.0.3 save-buffer
@ 2022-02-02  9:38 ` kawaiiamber
  0 siblings, 0 replies; 37+ messages in thread
From: kawaiiamber @ 2022-02-02  9:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35337#issuecomment-1027748967

Comment:
There's another PR for mold [here](https://github.com/void-linux/void-packages/pull/35305).

^ permalink raw reply	[flat|nested] 37+ messages in thread

end of thread, other threads:[~2022-02-22 18:02 UTC | newest]

Thread overview: 37+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-02 20:13 [PR PATCH] New Package: mold-1.0.3 basicfunc
2022-02-02 20:20 ` [PR REVIEW] " kawaiiamber
2022-02-03  7:17 ` [PR PATCH] [Updated] " basicfunc
2022-02-03  7:17 ` [PR REVIEW] " basicfunc
2022-02-21  6:49 ` [PR PATCH] [Updated] " basicfunc
2022-02-21  6:50 ` basicfunc
2022-02-21  6:53 ` basicfunc
2022-02-21  7:00 ` kawaiiamber
2022-02-21  7:00 ` [PR REVIEW] " kawaiiamber
2022-02-21  7:01 ` kawaiiamber
2022-02-21  7:05 ` kawaiiamber
2022-02-21  7:39 ` [PR REVIEW] " basicfunc
2022-02-21  7:39 ` basicfunc
2022-02-21  7:48 ` kawaiiamber
2022-02-21  7:49 ` basicfunc
2022-02-21  7:51 ` basicfunc
2022-02-21  7:52 ` kawaiiamber
2022-02-21  8:04 ` basicfunc
2022-02-21  8:04 ` basicfunc
2022-02-21  8:14 ` kawaiiamber
2022-02-21  8:15 ` kawaiiamber
2022-02-21  9:24 ` [PR REVIEW] " basicfunc
2022-02-21  9:24 ` basicfunc
2022-02-21  9:45 ` [PR REVIEW] " kawaiiamber
2022-02-21  9:46 ` kawaiiamber
2022-02-21  9:48 ` kawaiiamber
2022-02-21  9:50 ` kawaiiamber
2022-02-21  9:52 ` kawaiiamber
2022-02-21  9:53 ` kawaiiamber
2022-02-21  9:53 ` kawaiiamber
2022-02-21  9:55 ` [PR REVIEW] " kawaiiamber
2022-02-21  9:57 ` kawaiiamber
2022-02-21  9:58 ` kawaiiamber
2022-02-21 10:00 ` kawaiiamber
2022-02-22 17:59 ` [PR REVIEW] " Chocimier
2022-02-22 18:02 ` Chocimier
  -- strict thread matches above, loose matches on Subject: below --
2022-01-31 20:04 [PR PATCH] New package: mold-1.0.3 save-buffer
2022-02-02  9:38 ` kawaiiamber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).