Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] google-chrome: add missing gtk+3 dependency
Date: Thu, 03 Mar 2022 22:53:34 +0100	[thread overview]
Message-ID: <20220303215334.ggfZbVSDWLbB2Gh-_6InHGfVxKgIHm6LpRLyKf6dySE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35916@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/yiz/void-packages google-chrome
https://github.com/void-linux/void-packages/pull/35916

google-chrome: add missing gtk+3 dependency
Google Chrome would crash without gtk+3.

#### Testing the changes
- I tested the changes in this PR: **YES**
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/35916.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-google-chrome-35916.patch --]
[-- Type: text/x-diff, Size: 916 bytes --]

From 5a406f0de18c0f54b7f2689bea8a23a18e64fb22 Mon Sep 17 00:00:00 2001
From: Yi Zhang <23587113+yiz@users.noreply.github.com>
Date: Tue, 1 Mar 2022 20:01:47 -0800
Subject: [PATCH] google-chrome: add missing gtk+3 dependency

---
 srcpkgs/google-chrome/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 51462abfebda..f50d9caa3464 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -1,10 +1,11 @@
 # Template file for 'google-chrome'
 pkgname=google-chrome
 version=99.0.4844.51
-revision=1
+revision=2
 _channel=stable
 archs="x86_64"
 hostmakedepends="curl tar xz python3 python3-html2text python3-setuptools"
+depends="gtk+3"
 short_desc="Attempt at creating a safer, faster, and more stable browser"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="custom:chrome"

  parent reply	other threads:[~2022-03-03 21:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 10:06 [PR PATCH] google-chrome: adds " yiz
2022-03-02 11:24 ` paper42
2022-03-02 11:25 ` paper42
2022-03-02 11:47 ` paper42
2022-03-03  5:18 ` [PR PATCH] [Updated] google-chrome: add " yiz
2022-03-03  5:19 ` yiz
2022-03-03 21:53 ` paper42 [this message]
2022-03-03 21:53 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220303215334.ggfZbVSDWLbB2Gh-_6InHGfVxKgIHm6LpRLyKf6dySE@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).