* [PR PATCH] spotify-qt: add qt5-svg dependency
@ 2022-03-01 22:44 ninewise
2022-03-01 23:43 ` tibequadorian
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: ninewise @ 2022-03-01 22:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
There is a new pull request by ninewise against master on the void-packages repository
https://github.com/ninewise/void-packages-1 fix/spotify-qt
https://github.com/void-linux/void-packages/pull/35911
spotify-qt: add qt5-svg dependency
While the application does run without this dependency, a GUI client without icons is barely usable.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
A patch file from https://github.com/void-linux/void-packages/pull/35911.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/spotify-qt-35911.patch --]
[-- Type: text/x-diff, Size: 844 bytes --]
From dac1f440790f75606107b3ea95ffedc4300bd57d Mon Sep 17 00:00:00 2001
From: Felix Van der Jeugt <felix.vanderjeugt@posteo.net>
Date: Tue, 1 Mar 2022 23:35:30 +0100
Subject: [PATCH] spotify-qt: add qt5-svg dependency
---
srcpkgs/spotify-qt/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/spotify-qt/template b/srcpkgs/spotify-qt/template
index 0fb27d690f5d..aa30046a8778 100644
--- a/srcpkgs/spotify-qt/template
+++ b/srcpkgs/spotify-qt/template
@@ -1,10 +1,11 @@
# Template file for 'spotify-qt'
pkgname=spotify-qt
version=3.8
-revision=1
+revision=2
build_style=cmake
hostmakedepends="pkg-config qt5-devel"
makedepends="qt5-devel qt5-svg-devel"
+depends="qt5-svg"
short_desc="Lightweight Spotify client using Qt"
maintainer="Andrew Benson <abenson+void@gmail.com>"
license="GPL-3.0-or-later"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: spotify-qt: add qt5-svg dependency
2022-03-01 22:44 [PR PATCH] spotify-qt: add qt5-svg dependency ninewise
@ 2022-03-01 23:43 ` tibequadorian
2022-03-02 0:11 ` tibequadorian
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: tibequadorian @ 2022-03-01 23:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/35911#issuecomment-1055977418
Comment:
It's helpful to note the icons in the commit message
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: spotify-qt: add qt5-svg dependency
2022-03-01 22:44 [PR PATCH] spotify-qt: add qt5-svg dependency ninewise
2022-03-01 23:43 ` tibequadorian
@ 2022-03-02 0:11 ` tibequadorian
2022-03-02 7:02 ` [PR PATCH] [Updated] " ninewise
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: tibequadorian @ 2022-03-02 0:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
New comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/35911#issuecomment-1055977418
Comment:
It's helpful to note the icons in the commit message
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] spotify-qt: add qt5-svg dependency
2022-03-01 22:44 [PR PATCH] spotify-qt: add qt5-svg dependency ninewise
2022-03-01 23:43 ` tibequadorian
2022-03-02 0:11 ` tibequadorian
@ 2022-03-02 7:02 ` ninewise
2022-03-03 22:24 ` paper42
2022-03-03 22:31 ` [PR PATCH] [Merged]: " abenson
4 siblings, 0 replies; 6+ messages in thread
From: ninewise @ 2022-03-02 7:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
There is an updated pull request by ninewise against master on the void-packages repository
https://github.com/ninewise/void-packages-1 fix/spotify-qt
https://github.com/void-linux/void-packages/pull/35911
spotify-qt: add qt5-svg dependency
While the application does run without this dependency, a GUI client without icons is barely usable.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
A patch file from https://github.com/void-linux/void-packages/pull/35911.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/spotify-qt-35911.patch --]
[-- Type: text/x-diff, Size: 947 bytes --]
From 92b7744192b3306c9020d28d14706ade7e3c6105 Mon Sep 17 00:00:00 2001
From: Felix Van der Jeugt <felix.vanderjeugt@posteo.net>
Date: Tue, 1 Mar 2022 23:35:30 +0100
Subject: [PATCH] spotify-qt: add qt5-svg dependency for icons
Spotify-qt uses svg icons on buttons, so it's barely usable without
a dependency on qt5-svg.
---
srcpkgs/spotify-qt/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/spotify-qt/template b/srcpkgs/spotify-qt/template
index 0fb27d690f5d..aa30046a8778 100644
--- a/srcpkgs/spotify-qt/template
+++ b/srcpkgs/spotify-qt/template
@@ -1,10 +1,11 @@
# Template file for 'spotify-qt'
pkgname=spotify-qt
version=3.8
-revision=1
+revision=2
build_style=cmake
hostmakedepends="pkg-config qt5-devel"
makedepends="qt5-devel qt5-svg-devel"
+depends="qt5-svg"
short_desc="Lightweight Spotify client using Qt"
maintainer="Andrew Benson <abenson+void@gmail.com>"
license="GPL-3.0-or-later"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: spotify-qt: add qt5-svg dependency
2022-03-01 22:44 [PR PATCH] spotify-qt: add qt5-svg dependency ninewise
` (2 preceding siblings ...)
2022-03-02 7:02 ` [PR PATCH] [Updated] " ninewise
@ 2022-03-03 22:24 ` paper42
2022-03-03 22:31 ` [PR PATCH] [Merged]: " abenson
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-03-03 22:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35911#issuecomment-1058565741
Comment:
@abenson
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: spotify-qt: add qt5-svg dependency
2022-03-01 22:44 [PR PATCH] spotify-qt: add qt5-svg dependency ninewise
` (3 preceding siblings ...)
2022-03-03 22:24 ` paper42
@ 2022-03-03 22:31 ` abenson
4 siblings, 0 replies; 6+ messages in thread
From: abenson @ 2022-03-03 22:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
There's a merged pull request on the void-packages repository
spotify-qt: add qt5-svg dependency
https://github.com/void-linux/void-packages/pull/35911
Description:
While the application does run without this dependency, a GUI client without icons is barely usable.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-03 22:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 22:44 [PR PATCH] spotify-qt: add qt5-svg dependency ninewise
2022-03-01 23:43 ` tibequadorian
2022-03-02 0:11 ` tibequadorian
2022-03-02 7:02 ` [PR PATCH] [Updated] " ninewise
2022-03-03 22:24 ` paper42
2022-03-03 22:31 ` [PR PATCH] [Merged]: " abenson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).