[PR PATCH] nsxiv: update to 29.

[PR PATCH] nsxiv: update to 29.

[MouadCharradi]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

There is a new pull request by MouadCharradi against master on the void-packages repository

https://github.com/MouadCharradi/void-packages nsxiv
https://github.com/void-linux/void-packages/pull/35998

nsxiv: update to 29.
#### Testing the changes
- I tested the changes in this PR: **YES**


- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/35998.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nsxiv-35998.patch --]
[-- Type: text/x-diff, Size: 1024 bytes --]

From 58331abe104033cac3d1d844ff2fca36b20d21a4 Mon Sep 17 00:00:00 2001
From: MouadCharradi <charradimouad58@gmail.com>
Date: Sat, 5 Mar 2022 22:03:52 +0100
Subject: [PATCH] nsxiv: update to 29.

---
 srcpkgs/nsxiv/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nsxiv/template b/srcpkgs/nsxiv/template
index 6ef4a1e207d2..ec561cc9e3b3 100644
--- a/srcpkgs/nsxiv/template
+++ b/srcpkgs/nsxiv/template
@@ -1,6 +1,6 @@
 # Template file for 'nsxiv'
 pkgname=nsxiv
-version=28
+version=29
 revision=1
 build_style=gnu-makefile
 make_install_target=install-all
@@ -11,7 +11,7 @@ maintainer="Sanjay Pavan <tsppavan7@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/nsxiv/nsxiv"
 distfiles="https://github.com/nsxiv/nsxiv/archive/v${version}.tar.gz"
-checksum=38047f60e51854363dd98fb7b3bc9f1cfa9b7d6f9e8788508b6f1e317328dd75
+checksum=564a17d921172336f7cd463bf313e39f84e4bcf4fdc789326f4112f848aad039
 CFLAGS="-I${XBPS_CROSS_BASE}/usr/include/freetype2"
 
 pre_build() {

Re: nsxiv: update to 29.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35998#issuecomment-1059831243

Comment:
duplicate of #35944

Re: [PR PATCH] [Closed]: nsxiv: update to 29.

[MouadCharradi]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

There's a closed pull request on the void-packages repository

nsxiv: update to 29.
https://github.com/void-linux/void-packages/pull/35998

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**


- I built this PR locally for my native architecture, x86_64

Re: nsxiv: update to 29.

[MouadCharradi]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by MouadCharradi on void-packages repository

https://github.com/void-linux/void-packages/pull/35998#issuecomment-1059976450

Comment:
Closing.

Re: nsxiv: update to 29

[WitherCubes]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by WitherCubes on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1071942593

Comment:
I have added the proper patch name and description.

Re: nsxiv: update to 29

[N-R-K]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by N-R-K on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1067893315

Comment:
Description: "Don't rebuild options.o when installing" (?)
Name: idk, "Fix install" maybe.

Re: nsxiv: update to 29

[WitherCubes]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by WitherCubes on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1066735344

Comment:
> Give the patch an appropriate name and a description, this doesn't tell us anything.

I can't come up with a proper name and description, could you please recommend something?

_BTW the issue that is fixed by the patch is [this](https://github.com/nsxiv/nsxiv/issues/237)._

Re: nsxiv: update to 29

[WitherCubes]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by WitherCubes on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1066735344

Comment:
> Give the patch an appropriate name and a description, this doesn't tell us anything.

I can't come up with a proper name and description, could you please recommend something?

_BTW the issue that is fixed by the patch is [this](https://github.com/nsxiv/nsxiv/issues/237)_

Re: nsxiv: update to 29

[paper42]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1066198097

Comment:
Give the patch an appropriate name and a description, this doesn't tell us anything.

Re: nsxiv: update to 29

[N-R-K]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by N-R-K on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058576790

Comment:
Just removing `all` from the `install` prerequisite should work as well. This is what I do on the gentoo::guru package: `sed -i -e '/^install: / s|: all|:|' Makefile`.

Re: nsxiv: update to 29

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058573487

Comment:
With your patch from https://github.com/nsxiv/nsxiv/pull/238 it does work @N-R-K 

Re: nsxiv: update to 29

[paper42]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058507680

Comment:
> Seems to be the case from the [logs](https://github.com/void-linux/void-packages/runs/5407965374?check_suite_focus=true), it compiled fine but then failed when trying to install.

For some reason it tries to create options.o and fails before do_install doesn't set cross flags.

Re: nsxiv: update to 29

[N-R-K]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New comment by N-R-K on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058484119

Comment:
> This could be relevant: [nsxiv/nsxiv#237](https://github.com/nsxiv/nsxiv/issues/237)

Seems to be the case from the [logs](https://github.com/void-linux/void-packages/runs/5407965374?check_suite_focus=true), it compiled fine but then failed when trying to install.

Re: nsxiv: update to 29

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058382131

Comment:
This could be relevant: https://github.com/nsxiv/nsxiv/issues/237

Re: nsxiv: update to 29

[paper42]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058083358

Comment:
Do not add nocross=yes and remove the architecture restriction, so we can see what's happening.

Re: nsxiv: update to 29

[WitherCubes]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by WitherCubes on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058081522

Comment:
I will change it to `nocross=yes` for the moment, I will look into fixing cross builds after discussing with the nsxiv dev team.

Re: nsxiv: update to 29

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/35944#issuecomment-1058074635

Comment:
Build error is probably not architecture related, but fails due to cross compiling. Specify `nocross=yes` instead of restricting archs. But preferably you should figure out how to fix cross builds.