Github messages for voidlinux
 help / color / mirror / Atom feed
From: atk <atk@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] vscode: update to 1.65.1
Date: Fri, 11 Mar 2022 09:37:14 +0100	[thread overview]
Message-ID: <20220311083714.DMS61CMIT1-ztOkjjC7lEL2lCmeeQdp3EJG3lzc4_Y8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35465@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

There is an updated pull request by atk against master on the void-packages repository

https://github.com/atk/void-packages vscode-1.64.0
https://github.com/void-linux/void-packages/pull/35465

vscode: update to 1.65.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

I changed q66's package to replace @vscode/ripgrep to a far simpler version that only exposes the correct path and thus should never need to change and also removes the requirement to copy over files.

A patch file from https://github.com/void-linux/void-packages/pull/35465.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-1.64.0-35465.patch --]
[-- Type: text/x-diff, Size: 6753 bytes --]

From 4cbb383d42840329c666353a5b7b84c57792ba06 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alex.lohr@logmein.com>
Date: Tue, 22 Feb 2022 09:15:54 +0100
Subject: [PATCH] vscode: update to 1.65.2

---
 .../patches/disable-crash-reporter.patch      | 14 -------
 srcpkgs/vscode/patches/product.patch          |  9 ++--
 srcpkgs/vscode/patches/ripgrep.patch          | 42 +++++++++----------
 srcpkgs/vscode/template                       | 11 +++--
 4 files changed, 30 insertions(+), 46 deletions(-)

diff --git a/srcpkgs/vscode/patches/disable-crash-reporter.patch b/srcpkgs/vscode/patches/disable-crash-reporter.patch
index d91f6895969c..dac81e3341c4 100644
--- a/srcpkgs/vscode/patches/disable-crash-reporter.patch
+++ b/srcpkgs/vscode/patches/disable-crash-reporter.patch
@@ -13,20 +13,6 @@ So, disable it entirely. No cookies for you, Visual Studio Code team.
  src/vs/code/electron-main/app.ts |  2 +-
  3 files changed, 1 insertion(+), 20 deletions(-)
 
-diff --git a/src/bootstrap-fork.js b/src/bootstrap-fork.js
-index f7b07e49255..576c82f23e8 100644
---- a/src/bootstrap-fork.js
-+++ b/src/bootstrap-fork.js
-@@ -37,9 +37,6 @@ if (process.env['VSCODE_PARENT_PID']) {
- 	terminateWhenParentTerminates();
- }
- 
--// Configure Crash Reporter
--configureCrashReporter();
--
- // Load AMD entry point
- require('./bootstrap-amd').load(process.env['VSCODE_AMD_ENTRYPOINT']);
- 
 diff --git a/src/main.js b/src/main.js
 index ad838aa245e..e6319e100b9 100644
 --- a/src/main.js
diff --git a/srcpkgs/vscode/patches/product.patch b/srcpkgs/vscode/patches/product.patch
index edeebf5d1439..a7e2b79925bf 100644
--- a/srcpkgs/vscode/patches/product.patch
+++ b/srcpkgs/vscode/patches/product.patch
@@ -1,19 +1,18 @@
 diff --git a/product.json b/product.json
-index 22e93d4b7c3..335cddd4c7c 100644
+index 9d630f23cd7..eea95dce319 100644
 --- a/product.json
 +++ b/product.json
-@@ -25,13 +25,22 @@
+@@ -27,6 +27,9 @@
  	"licenseFileName": "LICENSE.txt",
  	"reportIssueUrl": "https://github.com/microsoft/vscode/issues/new",
  	"urlProtocol": "code-oss",
 +	"quality": "stable",
 +	"documentationUrl": "https://github.com/microsoft/vscode-docs",
 +	"requestFeatureUrl": "https://github.com/Microsoft/vscode/issues",
- 	"webviewContentExternalBaseUrlTemplate": "https://{{uuid}}.vscode-webview.net/insider/c42793d0357ff9c6589cce79a847177fd42852ee/out/vs/workbench/contrib/webview/browser/pre/",
+ 	"webviewContentExternalBaseUrlTemplate": "https://{{uuid}}.vscode-webview.net/insider/93a2a2fa12dd3ae0629eec01c05a28cb60ac1c4b/out/vs/workbench/contrib/webview/browser/pre/",
  	"extensionAllowedProposedApi": [
  		"ms-vscode.vscode-js-profile-flame",
- 		"ms-vscode.vscode-js-profile-table",
-+		"ms-python.python",
+@@ -34,6 +37,11 @@
  		"GitHub.remotehub",
  		"GitHub.remotehub-insiders"
  	],
diff --git a/srcpkgs/vscode/patches/ripgrep.patch b/srcpkgs/vscode/patches/ripgrep.patch
index 6e81145a1cb1..ff0dfc233e41 100644
--- a/srcpkgs/vscode/patches/ripgrep.patch
+++ b/srcpkgs/vscode/patches/ripgrep.patch
@@ -1,32 +1,32 @@
-Ping q66 if this needs updating.
+Ping atk if this needs updating.
 
 This prevents vscode from fetching prebuilt ripgrep from Microsoft
 during build, which unbreaks build on platforms where MS deos not
 ship a prebuilt ripgrep.
 
 diff --git a/package.json b/package.json
-index 6d1fb7cca0c..057ed39ac31 100644
+index 5d6022a2a40..f66ee44eef0 100644
 --- a/package.json
 +++ b/package.json
-@@ -83,7 +83,7 @@
-     "vscode-oniguruma": "1.6.1",
-     "vscode-proxy-agent": "^0.11.0",
-     "vscode-regexpp": "^3.1.0",
--    "vscode-ripgrep": "^1.12.1",
-+    "vscode-ripgrep": "https://github.com/q66/vscode-ripgrep.git",
-     "vscode-textmate": "5.5.0",
-     "xterm": "4.16.0-beta.2",
-     "xterm-addon-search": "0.9.0-beta.6",
+@@ -63,7 +63,7 @@
+     "@parcel/watcher": "2.0.5",
+     "@vscode/debugprotocol": "1.51.0",
+     "@vscode/iconv-lite-umd": "0.7.0",
+-    "@vscode/ripgrep": "^1.14.1",
++    "@vscode/ripgrep": "https://github.com/atk/void-vscode-ripgrep.git",
+     "@vscode/sqlite3": "4.0.12",
+     "@vscode/sudo-prompt": "9.3.1",
+     "@vscode/vscode-languagedetection": "1.0.21",
 diff --git a/remote/package.json b/remote/package.json
-index 662ce3568ab..a79fe3764d9 100644
+index 4bc40998093..9d22d408c02 100644
 --- a/remote/package.json
 +++ b/remote/package.json
-@@ -22,7 +22,7 @@
-     "vscode-oniguruma": "1.6.1",
-     "vscode-proxy-agent": "^0.11.0",
-     "vscode-regexpp": "^3.1.0",
--    "vscode-ripgrep": "^1.12.1",
-+    "vscode-ripgrep": "https://github.com/q66/vscode-ripgrep.git",
-     "vscode-textmate": "5.5.0",
-     "xterm": "4.16.0-beta.2",
-     "xterm-addon-search": "0.9.0-beta.6",
+@@ -6,7 +6,7 @@
+     "@microsoft/applicationinsights-web": "^2.6.4",
+     "@parcel/watcher": "2.0.5",
+     "@vscode/iconv-lite-umd": "0.7.0",
+-    "@vscode/ripgrep": "^1.14.1",
++    "@vscode/ripgrep": "https://github.com/atk/void-vscode-ripgrep.git",
+     "@vscode/vscode-languagedetection": "1.0.21",
+     "applicationinsights": "1.4.2",
+     "cookie": "^0.4.0",
diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index 97f1a142a814..56c66de902ff 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,17 +1,17 @@
 # Template file for 'vscode'
 pkgname=vscode
-version=1.63.2
+version=1.65.2
 revision=1
-_electronver=13.6.1
+_electronver=13.6.7
 hostmakedepends="pkg-config python nodejs yarn tar git ripgrep"
-makedepends="libxkbfile-devel libsecret-devel electron13"
-depends="libXtst libxkbfile nss dejavu-fonts-ttf xdg-utils ripgrep electron13"
+makedepends="libxkbfile-devel libsecret-devel libxml2-devel ncurses-devel electron13"
+depends="libXtst libxkbfile ncurses nss dejavu-fonts-ttf xdg-utils ripgrep electron13"
 short_desc="Microsoft Code for Linux"
 maintainer="shizonic <realtiaz@gmail.com>"
 license="MIT"
 homepage="https://code.visualstudio.com/"
 distfiles="https://github.com/Microsoft/vscode/archive/${version}.tar.gz"
-checksum=21fc9bc17ba4cf480b1e006f298363d86215c339c480f8d781cabcfedad2d624
+checksum=bd59713f001c06b7f0eb5573dd9c020fc98328880e24e2a4281c57d1028ab06e
 nocross=yes # x64 build does not cut it, it contains native code
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
@@ -61,7 +61,6 @@ do_install() {
 	ln -sf /usr/lib/code-oss/resources/app/resources/linux/code.desktop ${DESTDIR}/usr/share/applications/code-oss.desktop
 	vmkdir usr/share/pixmaps
 	ln -sf /usr/lib/code-oss/resources/app/resources/linux/code.png ${DESTDIR}/usr/share/pixmaps/code-oss.png
-	ln -sf /usr/bin/rg ${DESTDIR}/usr/lib/code-oss/resources/app/node_modules.asar.unpacked/vscode-ripgrep/bin/rg
 	vsed \
 	-e "s|ELECTRON=.*|ELECTRON=/usr/lib/electron${_electronver%%.*}/electron|g" \
 	-e 's|"$CLI"|"$CLI" --app="${VSCODE_PATH}/resources/app"|g' \

  parent reply	other threads:[~2022-03-11  8:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 21:44 [PR PATCH] vscode: update to 1.64.0 atk
2022-02-12 20:51 ` tibequadorian
2022-02-12 20:53 ` tibequadorian
2022-02-14  8:22 ` [PR PATCH] [Updated] " atk
2022-02-14  8:23 ` atk
2022-02-14  8:26 ` [PR PATCH] [Updated] vscode: update to 1.64.2 atk
2022-02-20 11:44 ` [PR REVIEW] " paper42
2022-02-20 11:45 ` paper42
2022-02-22  8:15 ` [PR PATCH] [Updated] " atk
2022-02-22  8:15 ` [PR REVIEW] " atk
2022-02-22 10:37 ` atk
2022-02-22 10:45 ` atk
2022-02-27 20:47 ` atk
2022-02-27 20:49 ` [PR PATCH] [Updated] " atk
2022-03-07 12:48 ` atk
2022-03-08 20:45 ` [PR PATCH] [Updated] vscode: update to 1.65.0 atk
2022-03-11  8:37 ` atk [this message]
2022-03-11  8:41 ` vscode: update to 1.65.1 atk
2022-03-13 21:59 ` [PR REVIEW] " paper42
2022-03-13 21:59 ` paper42
2022-03-13 22:02 ` paper42
2022-03-14  6:46 ` atk
2022-03-14  8:39 ` atk
2022-03-14  8:52 ` atk
2022-03-14  8:53 ` atk
2022-03-14  8:53 ` atk
2022-03-14  8:56 ` [PR PATCH] [Updated] " atk
2022-03-14  8:58 ` [PR REVIEW] " atk
2022-03-14  9:04 ` [PR PATCH] [Updated] " atk
2022-03-16  9:28 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220311083714.DMS61CMIT1-ztOkjjC7lEL2lCmeeQdp3EJG3lzc4_Y8@z \
    --to=atk@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).