Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] sqlite: update to 3.38.1.
Date: Sun, 13 Mar 2022 22:03:31 +0100	[thread overview]
Message-ID: <20220313210331.u-GRfkmwGMzf6KOSFPu5yeULk6gfbA4HCEgPmlaZcls@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36114@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36114#discussion_r825503665

Comment:
`common/shlibs` list shlibs and packages in which they are in versions in which they first appeared. `xbps-src` will scan the package for required shlibs, look at this file and create a list of dependencies. Without this change, a new package/an updated one will depend on sqlite>=3.38.0, with this change it will depend on sqlite>=3.38.1.

If there is no good reason to do this, we shouldn't do it. This makes reverts hard and prevents partial updates. It would make sense if sqlite added some new symbols and packages built with this version would crash with the old one. Then we would want new packages (built with new sqlite) to also depend on the new sqlite version, but that's not this case.

  parent reply	other threads:[~2022-03-13 21:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-12 20:26 [PR PATCH] " ologantr
2022-03-13 11:10 ` [PR REVIEW] " paper42
2022-03-13 20:36 ` ologantr
2022-03-13 21:03 ` paper42
2022-03-13 21:03 ` paper42 [this message]
2022-03-13 21:24 ` [PR PATCH] [Updated] " ologantr
2022-03-13 22:06 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220313210331.u-GRfkmwGMzf6KOSFPu5yeULk6gfbA4HCEgPmlaZcls@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).