Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] tigervnc: update to 1.12.0
@ 2022-01-26 16:58 Emru1
  2022-03-18 18:28 ` [PR REVIEW] " ahesford
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Emru1 @ 2022-01-26 16:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

There is a new pull request by Emru1 against master on the void-packages repository

https://github.com/Emru1/void-packages tigervnc
https://github.com/void-linux/void-packages/pull/35249

tigervnc: update to 1.12.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
 
#### Local build testing
- I built this PR locally for my native architecture, (amd64, amd64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l



Builded and tested on amd64, builded on amd64-musl, crossbuilded on amd64 for armv7l.
TigerVNC now demands presence of PAM


A patch file from https://github.com/void-linux/void-packages/pull/35249.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tigervnc-35249.patch --]
[-- Type: text/x-diff, Size: 1866 bytes --]

From 7e97b1445fe84d31781352e39c658ee080a4919f Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emil.tomczyk@skni.umcs.pl>
Date: Wed, 26 Jan 2022 17:34:17 +0100
Subject: [PATCH] tigervnc: update to 1.12.0

---
 srcpkgs/tigervnc/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/tigervnc/template b/srcpkgs/tigervnc/template
index 432505d58882..746a8057e141 100644
--- a/srcpkgs/tigervnc/template
+++ b/srcpkgs/tigervnc/template
@@ -1,20 +1,21 @@
 # Template file for 'tigervnc'
 pkgname=tigervnc
-version=1.10.1
-revision=3
+version=1.12.0
+revision=1
 _xorg_version=1.20.0
 build_style=cmake
-hostmakedepends="automake gettext xorg-util-macros font-util pkg-config libtool xtrans"
-makedepends="fltk-devel zlib-devel libXtst-devel libjpeg-turbo-devel pixman-devel
- xorgproto libxkbfile-devel libXrandr-devel libXfont2-devel gnutls-devel libdrm-devel"
-depends="perl xauth xkeyboard-config"
+hostmakedepends="automake gettext xorg-util-macros font-util pkg-config libtool xtrans pam"
+makedepends="fltk-devel zlib-devel libXtst-devel libjpeg-turbo-devel pixman-devel pam-devel
+ xorgproto libxkbfile-devel libXrandr-devel libXfont2-devel gnutls-devel libdrm-devel
+ libxshmfence-devel"
+depends="perl xauth xkeyboard-config pam"
 short_desc="High performance, multi-platform VNC client and server"
 maintainer="Evan Deaubl <evan@deaubl.name>"
 license="GPL-2.0-or-later"
 homepage="https://www.tigervnc.org"
 distfiles="https://github.com/TigerVNC/tigervnc/archive/v${version}.tar.gz>tigervnc-${version}.tar.gz
  ${XORG_SITE}/xserver/xorg-server-${_xorg_version}.tar.bz2"
-checksum="19fcc80d7d35dd58115262e53cac87d8903180261d94c2a6b0c19224f50b58c4
+checksum="9ff3f3948f2a4e8cc06ee598ee4b1096beb62094c13e0b1462bff78587bed789
  9d967d185f05709274ee0c4f861a4672463986e550ca05725ce27974f550d3e6"
 conflicts="turbovnc>=0"
 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] tigervnc: update to 1.12.0
  2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
@ 2022-03-18 18:28 ` ahesford
  2022-03-18 18:28 ` ahesford
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2022-03-18 18:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/35249#discussion_r830254673

Comment:
Drop `pam` from `depends`; just let `xbps-src` automatically resolve the `pam-libs` dependency.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] tigervnc: update to 1.12.0
  2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
  2022-03-18 18:28 ` [PR REVIEW] " ahesford
  2022-03-18 18:28 ` ahesford
@ 2022-03-18 18:28 ` ahesford
  2022-04-12  8:04 ` [PR PATCH] [Updated] " Emru1
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2022-03-18 18:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/35249#discussion_r830252813

Comment:
`pam` isn't required in `hostmakedepends`; adding `pam-devel` to `makedepends` is sufficient.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] tigervnc: update to 1.12.0
  2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
  2022-03-18 18:28 ` [PR REVIEW] " ahesford
@ 2022-03-18 18:28 ` ahesford
  2022-03-18 18:28 ` ahesford
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2022-03-18 18:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/35249#discussion_r830253653

Comment:
Please re-wrap to 80 columns.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] tigervnc: update to 1.12.0
  2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
                   ` (2 preceding siblings ...)
  2022-03-18 18:28 ` ahesford
@ 2022-04-12  8:04 ` Emru1
  2022-04-12  8:06 ` Emru1
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Emru1 @ 2022-04-12  8:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

There is an updated pull request by Emru1 against master on the void-packages repository

https://github.com/Emru1/void-packages tigervnc
https://github.com/void-linux/void-packages/pull/35249

tigervnc: update to 1.12.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
 
#### Local build testing
- I built this PR locally for my native architecture, (amd64, amd64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l



Builded and tested on amd64, builded on amd64-musl, crossbuilded on amd64 for armv7l.
TigerVNC now demands presence of PAM


A patch file from https://github.com/void-linux/void-packages/pull/35249.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tigervnc-35249.patch --]
[-- Type: text/x-diff, Size: 3530 bytes --]

From 5b6c72761244e3f348d0ac03b6b4375f29884e88 Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emil.tomczyk@skni.umcs.pl>
Date: Wed, 26 Jan 2022 17:34:17 +0100
Subject: [PATCH 1/2] tigervnc: update to 1.12.0

---
 srcpkgs/tigervnc/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/tigervnc/template b/srcpkgs/tigervnc/template
index 432505d58882..746a8057e141 100644
--- a/srcpkgs/tigervnc/template
+++ b/srcpkgs/tigervnc/template
@@ -1,20 +1,21 @@
 # Template file for 'tigervnc'
 pkgname=tigervnc
-version=1.10.1
-revision=3
+version=1.12.0
+revision=1
 _xorg_version=1.20.0
 build_style=cmake
-hostmakedepends="automake gettext xorg-util-macros font-util pkg-config libtool xtrans"
-makedepends="fltk-devel zlib-devel libXtst-devel libjpeg-turbo-devel pixman-devel
- xorgproto libxkbfile-devel libXrandr-devel libXfont2-devel gnutls-devel libdrm-devel"
-depends="perl xauth xkeyboard-config"
+hostmakedepends="automake gettext xorg-util-macros font-util pkg-config libtool xtrans pam"
+makedepends="fltk-devel zlib-devel libXtst-devel libjpeg-turbo-devel pixman-devel pam-devel
+ xorgproto libxkbfile-devel libXrandr-devel libXfont2-devel gnutls-devel libdrm-devel
+ libxshmfence-devel"
+depends="perl xauth xkeyboard-config pam"
 short_desc="High performance, multi-platform VNC client and server"
 maintainer="Evan Deaubl <evan@deaubl.name>"
 license="GPL-2.0-or-later"
 homepage="https://www.tigervnc.org"
 distfiles="https://github.com/TigerVNC/tigervnc/archive/v${version}.tar.gz>tigervnc-${version}.tar.gz
  ${XORG_SITE}/xserver/xorg-server-${_xorg_version}.tar.bz2"
-checksum="19fcc80d7d35dd58115262e53cac87d8903180261d94c2a6b0c19224f50b58c4
+checksum="9ff3f3948f2a4e8cc06ee598ee4b1096beb62094c13e0b1462bff78587bed789
  9d967d185f05709274ee0c4f861a4672463986e550ca05725ce27974f550d3e6"
 conflicts="turbovnc>=0"
 

From 763600ad8a2f00ca9808c894dd6a74dd253fa7ad Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emil.tomczyk@skni.umcs.pl>
Date: Tue, 12 Apr 2022 10:04:26 +0200
Subject: [PATCH 2/2] tigervnc: Fixed style, removed redundant depends

---
 srcpkgs/tigervnc/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/tigervnc/template b/srcpkgs/tigervnc/template
index 746a8057e141..dc481febf0dc 100644
--- a/srcpkgs/tigervnc/template
+++ b/srcpkgs/tigervnc/template
@@ -1,16 +1,17 @@
 # Template file for 'tigervnc'
 pkgname=tigervnc
 version=1.12.0
-revision=1
+revision=2
 _xorg_version=1.20.0
 build_style=cmake
-hostmakedepends="automake gettext xorg-util-macros font-util pkg-config libtool xtrans pam"
-makedepends="fltk-devel zlib-devel libXtst-devel libjpeg-turbo-devel pixman-devel pam-devel
- xorgproto libxkbfile-devel libXrandr-devel libXfont2-devel gnutls-devel libdrm-devel
- libxshmfence-devel"
-depends="perl xauth xkeyboard-config pam"
+hostmakedepends="automake gettext xorg-util-macros font-util pkg-config libtool
+  xtrans"
+makedepends="fltk-devel zlib-devel libXtst-devel libjpeg-turbo-devel
+  pixman-devel pam-devel xorgproto libxkbfile-devel libXrandr-devel
+  libXfont2-devel gnutls-devel libdrm-devel libxshmfence-devel"
+depends="perl xauth xkeyboard-config"
 short_desc="High performance, multi-platform VNC client and server"
-maintainer="Evan Deaubl <evan@deaubl.name>"
+maintainer="Emil Tomczyk <emil.tomczyk@skni.umcs.pl>"
 license="GPL-2.0-or-later"
 homepage="https://www.tigervnc.org"
 distfiles="https://github.com/TigerVNC/tigervnc/archive/v${version}.tar.gz>tigervnc-${version}.tar.gz

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: tigervnc: update to 1.12.0
  2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
                   ` (3 preceding siblings ...)
  2022-04-12  8:04 ` [PR PATCH] [Updated] " Emru1
@ 2022-04-12  8:06 ` Emru1
  2022-04-13 14:00 ` [PR REVIEW] " ahesford
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Emru1 @ 2022-04-12  8:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by Emru1 on void-packages repository

https://github.com/void-linux/void-packages/pull/35249#issuecomment-1096315112

Comment:
@ahesford 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] tigervnc: update to 1.12.0
  2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
                   ` (4 preceding siblings ...)
  2022-04-12  8:06 ` Emru1
@ 2022-04-13 14:00 ` ahesford
  2022-07-13  2:15 ` github-actions
  2022-07-28  2:15 ` [PR PATCH] [Closed]: " github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2022-04-13 14:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/35249#discussion_r849519084

Comment:
This still needs to be `revision=1`, and please squash the commits to one. After that, this is good to go.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: tigervnc: update to 1.12.0
  2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
                   ` (5 preceding siblings ...)
  2022-04-13 14:00 ` [PR REVIEW] " ahesford
@ 2022-07-13  2:15 ` github-actions
  2022-07-28  2:15 ` [PR PATCH] [Closed]: " github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-07-13  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/35249#issuecomment-1182688702

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: tigervnc: update to 1.12.0
  2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
                   ` (6 preceding siblings ...)
  2022-07-13  2:15 ` github-actions
@ 2022-07-28  2:15 ` github-actions
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-07-28  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

There's a closed pull request on the void-packages repository

tigervnc: update to 1.12.0
https://github.com/void-linux/void-packages/pull/35249

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
 
#### Local build testing
- I built this PR locally for my native architecture, (amd64, amd64-musl)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l



Builded and tested on amd64, builded on amd64-musl, crossbuilded on amd64 for armv7l.
TigerVNC now demands presence of PAM


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-07-28  2:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 16:58 [PR PATCH] tigervnc: update to 1.12.0 Emru1
2022-03-18 18:28 ` [PR REVIEW] " ahesford
2022-03-18 18:28 ` ahesford
2022-03-18 18:28 ` ahesford
2022-04-12  8:04 ` [PR PATCH] [Updated] " Emru1
2022-04-12  8:06 ` Emru1
2022-04-13 14:00 ` [PR REVIEW] " ahesford
2022-07-13  2:15 ` github-actions
2022-07-28  2:15 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).