From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] mosh: update to 20220318
Date: Fri, 18 Mar 2022 20:40:19 +0100 [thread overview]
Message-ID: <20220318194019.-I4QKsONiXTw5K2b17HhVHPXdEbKlg-M0Vh-RYkb-Ds@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36211@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/36211#discussion_r830303401
Comment:
maybe a version like `1.3.2+20220318` or adding the commit hash or something would be better? If mosh gets another release in the future, I think that will break version comparison, as `20220318` is larger than `1`.
next prev parent reply other threads:[~2022-03-18 19:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 19:30 [PR PATCH] " jbenden
2022-03-18 19:40 ` classabbyamp [this message]
2022-03-18 19:47 ` leahneukirchen
2022-03-18 20:17 ` [PR PATCH] [Updated] " jbenden
2022-03-18 20:18 ` [PR REVIEW] " jbenden
2022-03-18 20:21 ` jbenden
2022-06-29 2:15 ` github-actions
2022-07-13 2:15 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318194019.-I4QKsONiXTw5K2b17HhVHPXdEbKlg-M0Vh-RYkb-Ds@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).