Re: [PR PATCH] [Updated] orocos-kdl: update to 1.5.1.

[knusbaum <knusbaum@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

There is an updated pull request by knusbaum against master on the void-packages repository

https://github.com/knusbaum/void-packages UPDATE-orocos-kdl-1.5.1
https://github.com/void-linux/void-packages/pull/34890

orocos-kdl: update to 1.5.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR:  **briefly**
I've added a check target to run the orocos tests, which pass.

Not sure if this update is wanted, I'm just making a sweep through my out-of-date packages.
I don't have a good grasp on how to test this other than the provided test suite, it was added on request (#8965)

A patch file from https://github.com/void-linux/void-packages/pull/34890.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-UPDATE-orocos-kdl-1.5.1-34890.patch --]
[-- Type: text/x-diff, Size: 3555 bytes --]

From 8f21ab6179346ef87c15e2cf2a4ac758a814f88d Mon Sep 17 00:00:00 2001
From: Kyle Nusbaum <KyleJNusbaum@gmail.com>
Date: Wed, 5 Jan 2022 19:02:04 +0000
Subject: [PATCH 1/2] orocos-kdl: update to 1.5.1.

---
 common/shlibs                       |  2 +-
 srcpkgs/orocos-kdl/template         | 18 +++++++++++++++---
 srcpkgs/python3-orocos-kdl/template |  2 +-
 3 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 999d3ad714b8..e36d82a82b64 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3617,7 +3617,7 @@ librocksdb.so.5 rocksdb-5.17.2_1
 libfrr.so.0 libfrr-6.0_1
 libkaccounts.so.2 kaccounts-integration-20.04.3_1
 libfrrospfapiclient.so.0 libfrrospfapiclient-6.0_1
-liborocos-kdl.so.1.4 orocos-kdl-1.4.0_1
+liborocos-kdl.so.1.5 orocos-kdl-1.5.1_1
 libibumad.so.3 rdma-core-22.1_1
 libibverbs.so.1 rdma-core-22.1_1
 librdmacm.so.1 rdma-core-22.1_1
diff --git a/srcpkgs/orocos-kdl/template b/srcpkgs/orocos-kdl/template
index 544720b59a97..f00f2762b003 100644
--- a/srcpkgs/orocos-kdl/template
+++ b/srcpkgs/orocos-kdl/template
@@ -1,17 +1,29 @@
 # Template file for 'orocos-kdl'
 pkgname=orocos-kdl
-version=1.4.0
+version=1.5.1
 revision=1
 wrksrc=orocos_kinematics_dynamics-${version}
 build_wrksrc=orocos_kdl
 build_style=cmake
-makedepends="eigen3.2"
+makedepends="eigen3.2 libcppunit-devel"
 short_desc="Orocos Kinematics and Dynamics C++ library"
 maintainer="Kyle Nusbaum <knusbaum+void@sdf.org>"
 license="LGPL-2.1-only"
 homepage="http://www.orocos.org/kdl"
 distfiles="https://github.com/orocos/orocos_kinematics_dynamics/archive/v${version}.tar.gz"
-checksum=05b93e759923684dc07433ccae1e476d158d89b3c2be5079c20062406da7b4dd
+checksum=5acb90acd82b10971717aca6c17874390762ecdaa3a8e4db04984ea1d4a2af9b
+
+do_check() {
+	cd build
+	if [[ "$XBPS_LIBC" == "musl" ]]; then
+		## the __APPLE__ definition causes some typedefs that musl needs for tests.
+		cmake .. -DENABLE_TESTS:BOOL=ON -D 'CMAKE_CXX_FLAGS=-D__APPLE__=1'
+	else
+		cmake .. -DENABLE_TESTS:BOOL=ON
+	fi
+	ninja tests/all
+	ninja check
+}
 
 orocos-kdl-devel_package() {
 	short_desc+=" - development files"
diff --git a/srcpkgs/python3-orocos-kdl/template b/srcpkgs/python3-orocos-kdl/template
index 1c4f9d92ed89..6596a5c0a91c 100644
--- a/srcpkgs/python3-orocos-kdl/template
+++ b/srcpkgs/python3-orocos-kdl/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-orocos-kdl'
 pkgname=python3-orocos-kdl
 version=1.4.0
-revision=4
+revision=5
 wrksrc=orocos_kinematics_dynamics-${version}
 build_wrksrc=python_orocos_kdl
 build_style=cmake

From 26bc056729219de73857500c2b94f9ca99439405 Mon Sep 17 00:00:00 2001
From: Kyle Nusbaum <kjn@9project.net>
Date: Sat, 19 Mar 2022 06:23:34 +0000
Subject: [PATCH 2/2] Update srcpkgs/orocos-kdl/template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Érico Nogueira Rolim <34201958+ericonr@users.noreply.github.com>
---
 srcpkgs/orocos-kdl/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/orocos-kdl/template b/srcpkgs/orocos-kdl/template
index f00f2762b003..24a7d41c375a 100644
--- a/srcpkgs/orocos-kdl/template
+++ b/srcpkgs/orocos-kdl/template
@@ -15,7 +15,7 @@ checksum=5acb90acd82b10971717aca6c17874390762ecdaa3a8e4db04984ea1d4a2af9b
 
 do_check() {
 	cd build
-	if [[ "$XBPS_LIBC" == "musl" ]]; then
+	if [ "$XBPS_LIBC" = musl ]; then
 		## the __APPLE__ definition causes some typedefs that musl needs for tests.
 		cmake .. -DENABLE_TESTS:BOOL=ON -D 'CMAKE_CXX_FLAGS=-D__APPLE__=1'
 	else