From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: BAND-1.10.9
Date: Mon, 21 Mar 2022 23:42:55 +0100 [thread overview]
Message-ID: <20220321224255.n7sxXG9EoWJYpuJ8WRcxSMNKlFoyf4voqjv2k4M2MU4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36252@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/36252#discussion_r831598943
Comment:
```suggestion
do_install() {
vmkdir opt
vcopy opt/BAND opt
vinstall usr/share/applications/band.desktop 0644 usr/share/applications
vcopy usr/share/icons usr/share
vmkdir usr/bin
ln -s /opt/BAND/band ${DESTDIR}/usr/bin/band
}
post_install() {
vlicense opt/BAND/resources/LICENSE
}
```
I've simplified what you wrote a bit. The icons are already in the proper structure, no need to manually do it :).
I'm not convinced it's necessary to include that changelog (if it isn't, the gzip line in extract isn't necessary).
next prev parent reply other threads:[~2022-03-21 22:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 3:10 [PR PATCH] " CabrioletDiskette
2022-03-21 4:25 ` [PR PATCH] [Updated] " CabrioletDiskette
2022-03-21 17:13 ` CabrioletDiskette
2022-03-21 22:42 ` [PR REVIEW] " classabbyamp
2022-03-21 22:42 ` classabbyamp
2022-03-21 22:42 ` classabbyamp [this message]
2022-03-21 22:43 ` classabbyamp
2022-03-22 0:24 ` [PR PATCH] [Updated] " CabrioletDiskette
2022-03-22 0:34 ` CabrioletDiskette
2022-03-22 0:37 ` CabrioletDiskette
2022-03-22 0:41 ` [PR PATCH] [Updated] " CabrioletDiskette
2022-03-22 6:34 ` CabrioletDiskette
2022-03-22 17:45 ` CabrioletDiskette
2022-03-23 4:13 ` CabrioletDiskette
2022-03-23 19:58 ` CabrioletDiskette
2022-03-23 20:00 ` CabrioletDiskette
2022-03-24 6:33 ` CabrioletDiskette
2022-03-24 16:39 ` CabrioletDiskette
2022-03-27 23:33 ` CabrioletDiskette
2022-04-04 4:47 ` CabrioletDiskette
2022-04-13 1:56 ` CabrioletDiskette
2022-04-13 2:08 ` CabrioletDiskette
2022-04-13 2:10 ` CabrioletDiskette
2022-05-17 16:55 ` [PR PATCH] [Closed]: " CabrioletDiskette
2022-05-17 16:55 ` CabrioletDiskette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321224255.n7sxXG9EoWJYpuJ8WRcxSMNKlFoyf4voqjv2k4M2MU4@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).