[PR PATCH] fish-shell: update to 3.4.0.

[PR PATCH] fish-shell: update to 3.4.0.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages fish-3.4.0
https://github.com/void-linux/void-packages/pull/36121

fish-shell: update to 3.4.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

If you use an older Fish version as your shell and update to 3.4.0, you'll get the following (I believe harmless) error after the upgrade command finishes running and in some other instances:
```
/usr/share/fish/functions/fish_title.fish (line 7): $(...) is not supported. In fish, please use '(prompt_hostname)'.
        and set ssh "[$(prompt_hostname | string sub -l 10)]"
                      ^
from sourcing file /usr/share/fish/functions/fish_title.fish
in command substitution
source: Error while reading file “/usr/share/fish/functions/fish_title.fish”
```

Am I supposed to handle that somehow?

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds): 


A patch file from https://github.com/void-linux/void-packages/pull/36121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fish-3.4.0-36121.patch --]
[-- Type: text/x-diff, Size: 1124 bytes --]

From 6c00c859ae3271ec849b10c6dca5ee426606d638 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 13 Mar 2022 13:53:20 +0300
Subject: [PATCH] fish-shell: update to 3.4.0.

---
 srcpkgs/fish-shell/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/fish-shell/template b/srcpkgs/fish-shell/template
index 657e5604c3d6..130e59c514d4 100644
--- a/srcpkgs/fish-shell/template
+++ b/srcpkgs/fish-shell/template
@@ -1,6 +1,6 @@
 # Template file for 'fish-shell'
 pkgname=fish-shell
-version=3.3.1
+version=3.4.0
 revision=1
 wrksrc="fish-${version}"
 build_style=cmake
@@ -14,7 +14,7 @@ license="GPL-2.0-only"
 homepage="https://fishshell.com/"
 changelog="https://github.com/fish-shell/fish-shell/raw/master/CHANGELOG.rst"
 distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.xz"
-checksum=b5b4ee1a5269762cbbe993a4bd6507e675e4100ce9bbe84214a5eeb2b19fae89
+checksum=b5b48ab8486b19ef716a32f7f46b88b9ea5356155f0e967ee99f4093645413c5
 register_shell="/bin/fish /usr/bin/fish"
 # tests don't work as root
 make_check=ci-skip

Re: fish-shell: update to 3.4.0.

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067392671

Comment:
Looks like I found [solution](https://github.com/fish-shell/fish-shell/blob/master/share/functions/fish_title.fish)

Maybe add patch for it?
Never do that ...

change
"[$(prompt_hostname | string sub -l 10)]"
to
"["(prompt_hostname | string sub -l 10 | string collect)"]"

no error for me after change...

Re: fish-shell: update to 3.4.0.

[zen0bit]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

New comment by zen0bit on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067392671

Comment:
Looks like I found [solution](https://github.com/fish-shell/fish-shell/blob/master/share/functions/fish_title.fish)

Maybe add patch for it?
Never do that ...

change
`"[$(prompt_hostname | string sub -l 10)]"`
to
`"["(prompt_hostname | string sub -l 10 | string collect)"]"`

no error for me after change...

Re: fish-shell: update to 3.4.0.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067409478

Comment:
The error only occurs because Fish 3.4.0 introduces a new syntax that the script in question was modified to use in Fish 3.4.0, and older Fish versions error out on that syntax. I think applying such a patch is not a good idea, but I'll leave that to the maintainers.

Re: fish-shell: update to 3.4.0.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067409478

Comment:
The error only occurs because Fish 3.4.0 introduces a new syntax that the script in question was modified to use in Fish 3.4.0, and older Fish versions error out on that syntax. I think applying such a patch is not a good idea, but I'll leave that choice to the maintainers.

Re: fish-shell: update to 3.4.0.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1067409478

Comment:
The error only occurs because Fish 3.4.0 introduces a new syntax that the script in question was modified to use in Fish 3.4.0, and older Fish versions don't recognize that syntax. Thus, any Fish sessions started after the update will not be affected. I think applying such a patch is not a good idea, but I'll leave that choice to the maintainers.

Re: fish-shell: update to 3.4.0.

[Vistaus]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by Vistaus on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1073044266

Comment:
I also don't think applying such a patch is a good idea. Just restart your fish shell.

Re: fish-shell: update to 3.4.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1073361157

Comment:
Is this something that will happen only in specific circumstances or for all users? If this would happen to all users, we could add an install message. 

Re: fish-shell: update to 3.4.0.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1073942094

Comment:
@paper42 well, not strictly all users it seems. From https://fishshell.com/docs/current/cmds/fish_title.html:

> This requires that your terminal supports programmable titles and the feature is turned on.

I'm not sure about this, but it probably also wouldn't affect those who have a custom `fish_title` function (as shown in the example in the URL above). However, it's not like we know how many Fish users aren't affected, so it may be safe to assume that the majority _will_ face that error.

Re: fish-shell: update to 3.4.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1073947817

Comment:
> However, it's not like we know how many Fish users aren't affected, so it may be safe to assume that the majority _will_ face that error.

In that case let's add an install message, we can remove it with the next update.

Re: fish-shell: update to 3.4.0.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1077966399

Comment:
Upsteam patched out new syntax, i would prefer to import that.
https://github.com/fish-shell/fish-shell/commit/c5a8764db1c94f386f0546bd9a25ea3520eb15b8

Re: fish-shell: update to 3.4.0.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1077975495

Comment:
@Chocimier guess I'll do that.

Re: [PR PATCH] [Updated] fish-shell: update to 3.4.0.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages fish-3.4.0
https://github.com/void-linux/void-packages/pull/36121

fish-shell: update to 3.4.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

If you use an older Fish version as your shell and update to 3.4.0, you'll get the following (I believe harmless) error after the upgrade command finishes running and in some other instances:
```
/usr/share/fish/functions/fish_title.fish (line 7): $(...) is not supported. In fish, please use '(prompt_hostname)'.
        and set ssh "[$(prompt_hostname | string sub -l 10)]"
                      ^
from sourcing file /usr/share/fish/functions/fish_title.fish
in command substitution
source: Error while reading file “/usr/share/fish/functions/fish_title.fish”
```

(To be clear this does not happen when running the updated Fish 3.4.0)

Am I supposed to handle that somehow?

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/36121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fish-3.4.0-36121.patch --]
[-- Type: text/x-diff, Size: 1124 bytes --]

From d40549620418ce35c25f0bf354f0d5a1efd0dfec Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 13 Mar 2022 13:53:20 +0300
Subject: [PATCH] fish-shell: update to 3.4.1.

---
 srcpkgs/fish-shell/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/fish-shell/template b/srcpkgs/fish-shell/template
index 657e5604c3d6..0fc86db7e7b0 100644
--- a/srcpkgs/fish-shell/template
+++ b/srcpkgs/fish-shell/template
@@ -1,6 +1,6 @@
 # Template file for 'fish-shell'
 pkgname=fish-shell
-version=3.3.1
+version=3.4.1
 revision=1
 wrksrc="fish-${version}"
 build_style=cmake
@@ -14,7 +14,7 @@ license="GPL-2.0-only"
 homepage="https://fishshell.com/"
 changelog="https://github.com/fish-shell/fish-shell/raw/master/CHANGELOG.rst"
 distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.xz"
-checksum=b5b4ee1a5269762cbbe993a4bd6507e675e4100ce9bbe84214a5eeb2b19fae89
+checksum=b6f23b3843b04db6b0a90fea1f6f0d0e40cc027b4a732098200863f2864a94ea
 register_shell="/bin/fish /usr/bin/fish"
 # tests don't work as root
 make_check=ci-skip

Re: fish-shell: update to 3.4.1.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36121#issuecomment-1079658929

Comment:
I updated the PR to Fish 3.4.1, which fixes that issue (see https://github.com/fish-shell/fish-shell/releases/tag/3.4.1).

Re: [PR PATCH] [Merged]: fish-shell: update to 3.4.1.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]

There's a merged pull request on the void-packages repository

fish-shell: update to 3.4.1.
https://github.com/void-linux/void-packages/pull/36121

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<strike>If you use an older Fish version as your shell and update to 3.4.0, you'll get the following (I believe harmless) error after the upgrade command finishes running and in some other instances:</strike>
```
/usr/share/fish/functions/fish_title.fish (line 7): $(...) is not supported. In fish, please use '(prompt_hostname)'.
        and set ssh "[$(prompt_hostname | string sub -l 10)]"
                      ^
from sourcing file /usr/share/fish/functions/fish_title.fish
in command substitution
source: Error while reading file “/usr/share/fish/functions/fish_title.fish”
```
<strike>
To be clear this does not happen when running the updated Fish 3.4.0)

Am I supposed to handle that somehow?</strike> Fixed in 3.4.1.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc