From: benalb <benalb@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] qpdf: changed build_style to cmake.
Date: Fri, 25 Mar 2022 13:06:29 +0100 [thread overview]
Message-ID: <20220325120629.hJjYe6E8wk0fMgIu07SZxjJJSDoPYsCg-3-zuAM7RqM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36330@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
There is an updated pull request by benalb against master on the void-packages repository
https://github.com/benalb/void-packages qpdf
https://github.com/void-linux/void-packages/pull/36330
qpdf: changed build_style to cmake.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (X86-64-LIBC)
A patch file from https://github.com/void-linux/void-packages/pull/36330.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qpdf-36330.patch --]
[-- Type: text/x-diff, Size: 3371 bytes --]
From dc8d69809c97c4a6ff3b5d1f61d8c5936662130f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 12:28:53 +0100
Subject: [PATCH 1/2] qpdf: changed build_style to cmake.
---
srcpkgs/qpdf/template | 45 ++++++++++++++++++-------------------------
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 324de5aefaa2..1a376a4ad78d 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -1,45 +1,38 @@
# Template file for 'qpdf'
pkgname=qpdf
-version=10.6.3
+version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
-build_style=gnu-configure
-hostmakedepends="perl gettext tar"
-makedepends="pcre-devel libjpeg-turbo-devel"
+build_style=cmake
+hostmakedepends="perl"
+makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/qpdf/qpdf"
changelog="https://raw.githubusercontent.com/qpdf/qpdf/stable/manual/release-notes.rst"
distfiles="${homepage}/archive/release-qpdf-${version}.tar.gz"
-checksum=64bbb654ec19b6812284ef1bc40c57b091de5281f265f1c3c83dd8ccf6bedcf5
+checksum=729112f37d5eb53060cc8f5c4346e814670f147cb8498d47d010415754ce8087
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
- makedepends+=" libatomic-devel"
- LDFLAGS+=" -latomic"
+ makedepends+=" libatomic-devel"
+ LDFLAGS+=" -latomic"
fi
-do_check() {
- # libtsdc++ throws an exception on musl if std::locale("") is used, since
- # its generic locale implementation only supports the C locale.
- # by forcing LANG=C, no exception is thrown and the test suite can run to completion
- LANG=C make check
-}
-
libqpdf_package() {
- short_desc+=" - shared library"
- pkg_install() {
- vmove "usr/lib/*.so.*"
- }
+ short_desc+=" - shared library"
+ pkg_install() {
+ vmove "usr/lib/*.so.*"
+ }
}
libqpdf-devel_package() {
- depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
- short_desc+=" - development files"
- pkg_install() {
- vmove usr/include
- vmove usr/lib/pkgconfig
- vmove "usr/lib/*.a"
- vmove "usr/lib/*.so"
- }
+ depends="libqpdf>=${version}_${revision} libjpeg-turbo zlib-devel"
+ short_desc+=" - development files"
+ pkg_install() {
+ vmove usr/include
+ vmove usr/lib/pkgconfig
+ vmove "usr/lib/*.a"
+ vmove "usr/lib/*.so"
+ }
}
From 334f7d4c16d9f91a763af5eec37efbc1b209dd2f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Fri, 25 Mar 2022 13:06:18 +0100
Subject: [PATCH 2/2] added pkg-config to hostmakedepends
---
srcpkgs/qpdf/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/qpdf/template b/srcpkgs/qpdf/template
index 1a376a4ad78d..0b8b4d806984 100644
--- a/srcpkgs/qpdf/template
+++ b/srcpkgs/qpdf/template
@@ -4,7 +4,7 @@ version=10.6.3.0cmake1
revision=1
wrksrc="qpdf-release-qpdf-${version}"
build_style=cmake
-hostmakedepends="perl"
+hostmakedepends="perl pkg-config"
makedepends="zlib-devel libjpeg-turbo-devel"
short_desc="Content-Preserving PDF Transformation System"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
next prev parent reply other threads:[~2022-03-25 12:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 11:30 [PR PATCH] " benalb
2022-03-25 12:06 ` benalb [this message]
2022-03-25 13:51 ` [PR REVIEW] " TinfoilSubmarine
2022-03-25 13:52 ` TinfoilSubmarine
2022-03-25 14:06 ` [PR REVIEW] " tibequadorian
2022-03-25 14:07 ` tibequadorian
2022-03-25 14:11 ` tibequadorian
2022-03-25 14:12 ` TinfoilSubmarine
2022-03-25 14:12 ` TinfoilSubmarine
2022-03-26 22:06 ` [PR PATCH] [Updated] " benalb
2022-03-26 22:20 ` [PR REVIEW] " tibequadorian
2022-03-27 5:45 ` [PR PATCH] [Updated] " benalb
2022-03-27 12:47 ` [PR REVIEW] " tibequadorian
2022-03-27 12:47 ` tibequadorian
2022-03-27 13:55 ` [PR PATCH] [Updated] " benalb
2022-03-27 14:14 ` benalb
2022-03-27 14:20 ` [PR REVIEW] " tibequadorian
2022-05-28 23:04 ` Piraty
2022-05-29 5:59 ` benalb
2022-05-29 16:50 ` [PR REVIEW] " tibequadorian
2022-06-04 10:37 ` tibequadorian
2022-09-03 2:14 ` github-actions
2022-09-11 14:23 ` benalb
2022-09-11 14:23 ` [PR PATCH] [Closed]: " benalb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325120629.hJjYe6E8wk0fMgIu07SZxjJJSDoPYsCg-3-zuAM7RqM@z \
--to=benalb@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).