Re: [PR PATCH] [Updated] fish-shell: update to 3.4.0.

[mhmdanas <mhmdanas@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages fish-3.4.0
https://github.com/void-linux/void-packages/pull/36121

fish-shell: update to 3.4.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

If you use an older Fish version as your shell and update to 3.4.0, you'll get the following (I believe harmless) error after the upgrade command finishes running and in some other instances:
```
/usr/share/fish/functions/fish_title.fish (line 7): $(...) is not supported. In fish, please use '(prompt_hostname)'.
        and set ssh "[$(prompt_hostname | string sub -l 10)]"
                      ^
from sourcing file /usr/share/fish/functions/fish_title.fish
in command substitution
source: Error while reading file “/usr/share/fish/functions/fish_title.fish”
```

(To be clear this does not happen when running the updated Fish 3.4.0)

Am I supposed to handle that somehow?

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/36121.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fish-3.4.0-36121.patch --]
[-- Type: text/x-diff, Size: 1124 bytes --]

From d40549620418ce35c25f0bf354f0d5a1efd0dfec Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 13 Mar 2022 13:53:20 +0300
Subject: [PATCH] fish-shell: update to 3.4.1.

---
 srcpkgs/fish-shell/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/fish-shell/template b/srcpkgs/fish-shell/template
index 657e5604c3d6..0fc86db7e7b0 100644
--- a/srcpkgs/fish-shell/template
+++ b/srcpkgs/fish-shell/template
@@ -1,6 +1,6 @@
 # Template file for 'fish-shell'
 pkgname=fish-shell
-version=3.3.1
+version=3.4.1
 revision=1
 wrksrc="fish-${version}"
 build_style=cmake
@@ -14,7 +14,7 @@ license="GPL-2.0-only"
 homepage="https://fishshell.com/"
 changelog="https://github.com/fish-shell/fish-shell/raw/master/CHANGELOG.rst"
 distfiles="https://github.com/fish-shell/fish-shell/releases/download/${version}/fish-${version}.tar.xz"
-checksum=b5b4ee1a5269762cbbe993a4bd6507e675e4100ce9bbe84214a5eeb2b19fae89
+checksum=b6f23b3843b04db6b0a90fea1f6f0d0e40cc027b4a732098200863f2864a94ea
 register_shell="/bin/fish /usr/bin/fish"
 # tests don't work as root
 make_check=ci-skip