[PR PATCH] New package: giph-1.1.1

[PR PATCH] New package: giph-1.1.1

[notchtc]

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

There is a new pull request by notchtc against master on the void-packages repository

https://github.com/notchtc/void-packages giph
https://github.com/void-linux/void-packages/pull/36363

New package: giph-1.1.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l


A patch file from https://github.com/void-linux/void-packages/pull/36363.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-giph-36363.patch --]
[-- Type: text/x-diff, Size: 1097 bytes --]

From f77bc47e2de3d2dc44d9ce626a635dc4a20a2bd8 Mon Sep 17 00:00:00 2001
From: chtc <notnotcha0t1c@protonmail.com>
Date: Sat, 26 Mar 2022 17:38:54 +0100
Subject: [PATCH] New package: giph-1.1.1

---
 srcpkgs/giph/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/giph/template

diff --git a/srcpkgs/giph/template b/srcpkgs/giph/template
new file mode 100644
index 000000000000..f04aa756b726
--- /dev/null
+++ b/srcpkgs/giph/template
@@ -0,0 +1,18 @@
+# Template file for 'giph'
+pkgname=giph
+version=1.1.1
+revision=1
+build_style=gnu-makefile
+depends="ffmpeg xdotool slop libnotify procps-ng"
+short_desc="Simple video (gif, webm, mp4) recorder"
+maintainer="chtc <notnotcha0t1c@protonmail.com>"
+license="MIT"
+homepage="https://github.com/phisch/giph"
+distfiles="${homepage}/archive/refs/tags/${version}.tar.gz>${pkgname}-${version}.tar.gz"
+checksum=09fc964cc3cfcd942d5d2983667b65bf126fbfbba53cdcfb80fe3d87d1240667
+
+do_install() {
+	make PREFIX=/usr DESTDIR=$DESTDIR install
+	vinstall README.md 644 usr/share/doc/$pkgname
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: giph-1.1.1

[subnut]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/36363#discussion_r835787544

Comment:
huh? What's with the trailing `>${pkgname}-${version}.tar.gz` ?

Please go through the [manual](https://github.com/void-linux/void-packages/blob/master/manual.md) once.

Re: New package: giph-1.1.1

[subnut]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/36363#issuecomment-1079736130

Comment:
This package does **NOT** meet the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) -
1. :no_entry_sign: System: It's a single shell script, and can be run just as well from the `~/.local/bin` directory.
2. :no_entry_sign: Compiled: It isn't. It's a simple shell script.
3. :no_entry_sign: Required: No other package requires it.

Please close this PR

Re: New package: giph-1.1.1

[subnut]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/36363#issuecomment-1079736130

Comment:
This package does **NOT** meet the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements) -
1. :no_entry_sign: System: It's a single shell script, and can be run just as well from the `~/.local/bin` directory.
2. :no_entry_sign: Compiled: It isn't. It's a simple shell script.
3. :no_entry_sign: Required: No other package requires it.

Re: [PR PATCH] [Closed]: New package: giph-1.1.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

There's a closed pull request on the void-packages repository

New package: giph-1.1.1
https://github.com/void-linux/void-packages/pull/36363

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv7l

Re: New package: giph-1.1.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36363#issuecomment-1079737376

Comment:
This package doesn't meet quality requirements.

Re: [PR REVIEW] New package: giph-1.1.1

[notchtc]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New review comment by notchtc on void-packages repository

https://github.com/void-linux/void-packages/pull/36363#discussion_r835792860

Comment:
It is used to specify the filename. In this scenario it's actually useless because the filename isn't different but I was copy and pasting from another template I made.

Re: [PR REVIEW] New package: giph-1.1.1

[subnut]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/36363#discussion_r835787544

Comment:
huh? What's with the trailing `>${pkgname}-${version}.tar.gz` ?

Please go through the [manual](https://github.com/void-linux/void-packages/blob/master/manual.md) once.