Github messages for voidlinux
 help / color / mirror / Atom feed
From: subnut <subnut@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: glirc-2.38
Date: Sat, 26 Mar 2022 19:24:30 +0100	[thread overview]
Message-ID: <20220326182430.YOb76FNtpj60TeZp7nx1YE5xmoCc1_Qc0_E1dhXNzn4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36362@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/36362#discussion_r835794441

Comment:
> There should be no external commands run on top level of template.

okay, I've removed them in the latest commit.  
But may I know the reason behind this rule? Also, is it mentioned in the [Manual.md](https://github.com/void-linux/void-packages/blob/master/Manual.md)?

  parent reply	other threads:[~2022-03-26 18:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26 14:15 [PR PATCH] " subnut
2022-03-26 14:25 ` [PR PATCH] [Updated] " subnut
2022-03-26 17:29 ` [PR PATCH] [Closed]: " subnut
2022-03-26 17:30 ` subnut
2022-03-26 18:21 ` [PR REVIEW] " Chocimier
2022-03-26 18:23 ` [PR PATCH] [Updated] " subnut
2022-03-26 18:24 ` subnut [this message]
2022-03-26 18:37 ` [PR REVIEW] " subnut
2022-03-27  2:03 ` [PR PATCH] [Updated] " subnut
2022-06-18 18:47 ` subnut
2022-07-31  4:41 ` subnut
2022-10-07  9:16 ` leahneukirchen
2022-10-25 18:04 ` [PR PATCH] [Updated] " subnut
2022-10-26 15:52 ` [PR PATCH] [Merged]: New package: glirc-2.39.0.1 leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220326182430.YOb76FNtpj60TeZp7nx1YE5xmoCc1_Qc0_E1dhXNzn4@z \
    --to=subnut@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).