From 053b72f1b64e86bdbc5aa6d15fbf2491951fa402 Mon Sep 17 00:00:00 2001 From: 0x5c Date: Tue, 29 Mar 2022 05:26:18 -0400 Subject: [PATCH] onboard: fix SyntaxWarnings and disable tests - A missing % operator was breaking a c-style format string, causing a SyntaxWarning to be trown twice at package install time (during byte-compilation). - The tests were failing since they try to run 'killall' before executing onboard in xautomation(7), both not being possible in xbps-src. --- srcpkgs/onboard/patches/fix-brokenformat.patch | 15 +++++++++++++++ srcpkgs/onboard/template | 4 +++- 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 srcpkgs/onboard/patches/fix-brokenformat.patch diff --git a/srcpkgs/onboard/patches/fix-brokenformat.patch b/srcpkgs/onboard/patches/fix-brokenformat.patch new file mode 100644 index 000000000000..e5d200208a93 --- /dev/null +++ b/srcpkgs/onboard/patches/fix-brokenformat.patch @@ -0,0 +1,15 @@ +Fix for https://bugs.launchpad.net/onboard/+bug/1948723 + + +-- +--- a/Onboard/LayoutLoaderSVG.py ++++ b/Onboard/LayoutLoaderSVG.py +@@ -445,7 +445,7 @@ + except KeyError as ex: + (strerror) = ex + raise Exceptions.LayoutFileError("Unrecognized modifier %s in" \ +- "definition of %s" (strerror, full_id)) ++ "definition of %s" % (strerror, full_id)) + + value = attributes.get("action") + if value: diff --git a/srcpkgs/onboard/template b/srcpkgs/onboard/template index c147bf58a65c..b138fae61897 100644 --- a/srcpkgs/onboard/template +++ b/srcpkgs/onboard/template @@ -1,7 +1,7 @@ # Template file for 'onboard' pkgname=onboard version=1.4.1 -revision=9 +revision=10 build_style=python3-module hostmakedepends="intltool pkg-config python3-distutils-extra" makedepends="dconf-devel eudev-libudev-devel gtk+3-devel hunspell-devel @@ -14,3 +14,5 @@ license="GPL-3.0-or-later" homepage="https://launchpad.net/onboard" distfiles="https://launchpad.net/${pkgname}/${version%.*}/${version}/+download/${pkgname}-${version}.tar.gz" checksum=01cae1ac5b1ef1ab985bd2d2d79ded6fc99ee04b1535cc1bb191e43a231a3865 +# Tries to run onboard in tests, using xautomation(7) +make_check=no