Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libsigrok: fix missing plugdev group
@ 2022-03-14 23:28 0x5c
  2022-03-15  3:23 ` Duncaen
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: 0x5c @ 2022-03-14 23:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

There is a new pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages sigrok-plugdev
https://github.com/void-linux/void-packages/pull/36144

libsigrok: fix missing plugdev group
Fixes #23580
Closes #23581 (obsoletes the PR)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36144.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sigrok-plugdev-36144.patch --]
[-- Type: text/x-diff, Size: 1505 bytes --]

From c0127b6cfa312f7045ec51fb52e5059635f2b721 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Mon, 14 Mar 2022 19:25:52 -0400
Subject: [PATCH] libsigrok: fix missing plugdev group

Fixes #23580
Closes #23581 (obsoletes the PR)
---
 srcpkgs/libsigrok/INSTALL.msg | 3 +++
 srcpkgs/libsigrok/template    | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/libsigrok/INSTALL.msg

diff --git a/srcpkgs/libsigrok/INSTALL.msg b/srcpkgs/libsigrok/INSTALL.msg
new file mode 100644
index 000000000000..520c03af7d17
--- /dev/null
+++ b/srcpkgs/libsigrok/INSTALL.msg
@@ -0,0 +1,3 @@
+To use devices with libsigrok, add your user to the 'plugdev' group.
+
+    # usermod -aG plugdev <username>
diff --git a/srcpkgs/libsigrok/template b/srcpkgs/libsigrok/template
index 87939ce82fa8..ea7f09e2ebf8 100644
--- a/srcpkgs/libsigrok/template
+++ b/srcpkgs/libsigrok/template
@@ -1,7 +1,7 @@
 # Template file for 'libsigrok'
 pkgname=libsigrok
 version=0.5.2
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="pkg-config doxygen python3"
 makedepends="glib-devel libzip-devel glibmm-devel libserialport-devel
@@ -12,6 +12,7 @@ license="GPL-3.0-or-later"
 homepage="https://sigrok.org/"
 distfiles="https://sigrok.org/download/source/${pkgname}/${pkgname}-${version}.tar.gz"
 checksum=4d341f90b6220d3e8cb251dacf726c41165285612248f2c52d15df4590a1ce3c
+system_groups="plugdev"
 
 case $XBPS_TARGET_MACHINE in
 	i686*|x86_64*|ppc64*) makedepends+=" libieee1284-devel";;

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: libsigrok: fix missing plugdev group
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
@ 2022-03-15  3:23 ` Duncaen
  2022-03-15 19:55 ` q66
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Duncaen @ 2022-03-15  3:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/36144#issuecomment-1067522118

Comment:
Please no `INSTALL.msg` for this, if this needs documentation, add a `README.void` instead.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: libsigrok: fix missing plugdev group
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
  2022-03-15  3:23 ` Duncaen
@ 2022-03-15 19:55 ` q66
  2022-03-15 19:56 ` q66
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: q66 @ 2022-03-15 19:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/36144#issuecomment-1068408458

Comment:
i don't really like this idea, IMO we should add plugdev to default groups in base-files (in debian it's gid 46, here we could simply add it among the base groups (after input, before nogroup) and for existing setups, put a groupadd in an upgrade hook)

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: libsigrok: fix missing plugdev group
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
  2022-03-15  3:23 ` Duncaen
  2022-03-15 19:55 ` q66
@ 2022-03-15 19:56 ` q66
  2022-03-15 20:44 ` 0x5c
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: q66 @ 2022-03-15 19:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/36144#issuecomment-1068408458

Comment:
i don't really like this idea, IMO we should add plugdev to default groups in base-files (in debian it's gid 46, here we could simply add it among the base groups (after input, before nogroup) and for existing setups, put a groupadd in an upgrade hook)

either that, or change the udev files here to use another, existing group

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: libsigrok: fix missing plugdev group
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
                   ` (2 preceding siblings ...)
  2022-03-15 19:56 ` q66
@ 2022-03-15 20:44 ` 0x5c
  2022-03-20  5:06 ` [PR PATCH] [Updated] " 0x5c
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: 0x5c @ 2022-03-15 20:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36144#issuecomment-1068452444

Comment:
> i don't really like this idea, IMO we should add plugdev to default groups in base-files (in debian it's gid 46, here we could simply add it among the base groups (after input, before nogroup) and for existing setups, put a groupadd in an upgrade hook)
> 
> either that, or change the udev files here to use another, existing group

That would be cleaner it seems and would allow cleanup in *many* templates, but can this be done without breaking current installations? The `plugdev` group already exist with a different GID for many users, will the change take that into account?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] libsigrok: fix missing plugdev group
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
                   ` (3 preceding siblings ...)
  2022-03-15 20:44 ` 0x5c
@ 2022-03-20  5:06 ` 0x5c
  2022-03-20  5:13 ` 0x5c
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: 0x5c @ 2022-03-20  5:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

There is an updated pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages sigrok-plugdev
https://github.com/void-linux/void-packages/pull/36144

libsigrok: fix missing plugdev group
Fixes #23580
Closes #23581 (obsoletes the PR)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36144.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sigrok-plugdev-36144.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From b8fe0ad34a8fcca48148ad4a91b45bb17c2320d4 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Sun, 20 Mar 2022 00:41:04 -0400
Subject: [PATCH] libsigrok: fix on systems without logind

Fixes #23580
Closes #23581 (obsoletes the PR)
---
 srcpkgs/libsigrok/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/libsigrok/template b/srcpkgs/libsigrok/template
index 87939ce82fa8..0243925a7312 100644
--- a/srcpkgs/libsigrok/template
+++ b/srcpkgs/libsigrok/template
@@ -1,7 +1,7 @@
 # Template file for 'libsigrok'
 pkgname=libsigrok
 version=0.5.2
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="pkg-config doxygen python3"
 makedepends="glib-devel libzip-devel glibmm-devel libserialport-devel
@@ -20,6 +20,7 @@ esac
 post_install() {
 	vinstall contrib/60-libsigrok.rules 0644 /usr/lib/udev/rules.d
 	vinstall contrib/61-libsigrok-uaccess.rules 0644 /usr/lib/udev/rules.d
+	vinstall contrib/61-libsigrok-plugdev.rules 0644 /usr/lib/udev/rules.d
 }
 
 libsigrok-devel_package() {

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: libsigrok: fix missing plugdev group
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
                   ` (4 preceding siblings ...)
  2022-03-20  5:06 ` [PR PATCH] [Updated] " 0x5c
@ 2022-03-20  5:13 ` 0x5c
  2022-03-20  5:14 ` 0x5c
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: 0x5c @ 2022-03-20  5:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36144#issuecomment-1073170367

Comment:
I realised that the original fix in this PR was bogus resulting from improper testing.

With #36238 taking care of adding the plugdev group, we still need to have the package install the missing udev rules. This PR has been updated to do that.

This PR is dependent on #36238 being merged.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: libsigrok: fix missing plugdev group
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
                   ` (5 preceding siblings ...)
  2022-03-20  5:13 ` 0x5c
@ 2022-03-20  5:14 ` 0x5c
  2022-03-29 10:10 ` [PR PATCH] [Updated] libsigrok: fix missing udev rules 0x5c
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: 0x5c @ 2022-03-20  5:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36144#issuecomment-1073170367

Comment:
I realised that the original fix in this PR was bogus resulting from improper testing.

With #36238 taking care of adding the plugdev group, we still need to have the package install the missing udev rules. This PR has been updated to do that. It has been successfully tested on a machine that does not have elogind.

This PR is dependent on #36238 being merged.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] libsigrok: fix missing udev rules
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
                   ` (6 preceding siblings ...)
  2022-03-20  5:14 ` 0x5c
@ 2022-03-29 10:10 ` 0x5c
  2022-04-06 22:47 ` 0x5c
  2022-04-07  1:58 ` [PR PATCH] [Merged]: " abenson
  9 siblings, 0 replies; 11+ messages in thread
From: 0x5c @ 2022-03-29 10:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

There is an updated pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages sigrok-plugdev
https://github.com/void-linux/void-packages/pull/36144

libsigrok: fix missing udev rules
Fixes #23580
Closes #23581 (obsoletes the PR)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

### **This PR is dependent on #36238 being merged.**

A patch file from https://github.com/void-linux/void-packages/pull/36144.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sigrok-plugdev-36144.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From 94b19dd5c2d7a184aefff810cae8f6f60550cee3 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Sun, 20 Mar 2022 00:41:04 -0400
Subject: [PATCH] libsigrok: fix on systems without logind

Fixes #23580
Closes #23581 (obsoletes the PR)
---
 srcpkgs/libsigrok/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/libsigrok/template b/srcpkgs/libsigrok/template
index 87939ce82fa8..0243925a7312 100644
--- a/srcpkgs/libsigrok/template
+++ b/srcpkgs/libsigrok/template
@@ -1,7 +1,7 @@
 # Template file for 'libsigrok'
 pkgname=libsigrok
 version=0.5.2
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="pkg-config doxygen python3"
 makedepends="glib-devel libzip-devel glibmm-devel libserialport-devel
@@ -20,6 +20,7 @@ esac
 post_install() {
 	vinstall contrib/60-libsigrok.rules 0644 /usr/lib/udev/rules.d
 	vinstall contrib/61-libsigrok-uaccess.rules 0644 /usr/lib/udev/rules.d
+	vinstall contrib/61-libsigrok-plugdev.rules 0644 /usr/lib/udev/rules.d
 }
 
 libsigrok-devel_package() {

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] libsigrok: fix missing udev rules
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
                   ` (7 preceding siblings ...)
  2022-03-29 10:10 ` [PR PATCH] [Updated] libsigrok: fix missing udev rules 0x5c
@ 2022-04-06 22:47 ` 0x5c
  2022-04-07  1:58 ` [PR PATCH] [Merged]: " abenson
  9 siblings, 0 replies; 11+ messages in thread
From: 0x5c @ 2022-04-06 22:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

There is an updated pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages sigrok-plugdev
https://github.com/void-linux/void-packages/pull/36144

libsigrok: fix missing udev rules
Fixes #23580
Closes #23581 (obsoletes the PR)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

### **This PR is dependent on #36238 being merged.**

A patch file from https://github.com/void-linux/void-packages/pull/36144.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sigrok-plugdev-36144.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From 28874a15c1726cef47e66b2919f0c94c3a85658d Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Sun, 20 Mar 2022 00:41:04 -0400
Subject: [PATCH] libsigrok: fix on systems without logind

Fixes #23580
Closes #23581 (obsoletes the PR)
---
 srcpkgs/libsigrok/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/libsigrok/template b/srcpkgs/libsigrok/template
index 87939ce82fa8..0243925a7312 100644
--- a/srcpkgs/libsigrok/template
+++ b/srcpkgs/libsigrok/template
@@ -1,7 +1,7 @@
 # Template file for 'libsigrok'
 pkgname=libsigrok
 version=0.5.2
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="pkg-config doxygen python3"
 makedepends="glib-devel libzip-devel glibmm-devel libserialport-devel
@@ -20,6 +20,7 @@ esac
 post_install() {
 	vinstall contrib/60-libsigrok.rules 0644 /usr/lib/udev/rules.d
 	vinstall contrib/61-libsigrok-uaccess.rules 0644 /usr/lib/udev/rules.d
+	vinstall contrib/61-libsigrok-plugdev.rules 0644 /usr/lib/udev/rules.d
 }
 
 libsigrok-devel_package() {

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Merged]: libsigrok: fix missing udev rules
  2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
                   ` (8 preceding siblings ...)
  2022-04-06 22:47 ` 0x5c
@ 2022-04-07  1:58 ` abenson
  9 siblings, 0 replies; 11+ messages in thread
From: abenson @ 2022-04-07  1:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

There's a merged pull request on the void-packages repository

libsigrok: fix missing udev rules
https://github.com/void-linux/void-packages/pull/36144

Description:
Fixes #23580
Closes #23581 (obsoletes the PR)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

### ~~**This PR is dependent on #36238 being merged.**~~

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-04-07  1:58 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 23:28 [PR PATCH] libsigrok: fix missing plugdev group 0x5c
2022-03-15  3:23 ` Duncaen
2022-03-15 19:55 ` q66
2022-03-15 19:56 ` q66
2022-03-15 20:44 ` 0x5c
2022-03-20  5:06 ` [PR PATCH] [Updated] " 0x5c
2022-03-20  5:13 ` 0x5c
2022-03-20  5:14 ` 0x5c
2022-03-29 10:10 ` [PR PATCH] [Updated] libsigrok: fix missing udev rules 0x5c
2022-04-06 22:47 ` 0x5c
2022-04-07  1:58 ` [PR PATCH] [Merged]: " abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).