Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: lsp-plugins-1.1.30
@ 2021-04-01 14:09 paper42
  2021-04-01 14:12 ` [PR REVIEW] " ericonr
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: paper42 @ 2021-04-01 14:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages lsp-plugins
https://github.com/void-linux/void-packages/pull/29932

New package: lsp-plugins-1.1.30
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
very useful with pulseeffects

A patch file from https://github.com/void-linux/void-packages/pull/29932.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsp-plugins-29932.patch --]
[-- Type: text/x-diff, Size: 1190 bytes --]

From 056f3e59a8b169e5ccc1579556288aa15d138097 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Sat, 20 Mar 2021 23:19:47 +0100
Subject: [PATCH] New package: lsp-plugins-1.1.30

---
 srcpkgs/lsp-plugins/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/lsp-plugins/template

diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
new file mode 100644
index 000000000000..052294c1296c
--- /dev/null
+++ b/srcpkgs/lsp-plugins/template
@@ -0,0 +1,18 @@
+# Template file for 'lsp-plugins'
+pkgname=lsp-plugins
+version=1.1.30
+revision=1
+build_style=gnu-makefile
+hostmakedepends="pkg-config php"
+makedepends="libsndfile-devel libX11-devel libglvnd-devel lv2 cairo-devel ladspa-sdk
+ jack-devel libstdc++-devel"
+short_desc="Collection of free plugins compatible with LADSPA, LV2 and LinuxVST"
+maintainer="Paper <paper@tilde.institute>"
+license="LGPL-3.0-or-later"
+homepage="https://lsp-plug.in/"
+distfiles="https://github.com/sadko4u/lsp-plugins/archive/${version}/${version}.tar.gz"
+checksum=9cf43257729093c240375b3640b1514dff34b092b83b54a5ee68d7e8565c8f80
+
+do_build() {
+    make CFLAGS="-fno-rtti"
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
  2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
@ 2021-04-01 14:12 ` ericonr
  2021-04-01 14:24 ` sgn
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-04-01 14:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/29932#discussion_r605690759

Comment:
Can you leave a comment explaining this?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
  2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
                   ` (2 preceding siblings ...)
  2021-04-01 14:24 ` sgn
@ 2021-04-01 14:24 ` sgn
  2021-06-26 15:15 ` Logarithmus
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2021-04-01 14:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29932#discussion_r605694381

Comment:
Don't put `libstdc++-devel` there.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
  2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
  2021-04-01 14:12 ` [PR REVIEW] " ericonr
@ 2021-04-01 14:24 ` sgn
  2021-04-01 14:24 ` sgn
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2021-04-01 14:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29932#discussion_r605695858

Comment:
Please patch their Makefile, remove all change to `CFLAGS` `CXXFLAGS` for `test` target.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: lsp-plugins-1.1.30
  2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
  2021-04-01 14:12 ` [PR REVIEW] " ericonr
  2021-04-01 14:24 ` sgn
@ 2021-04-01 14:24 ` sgn
  2021-04-01 14:24 ` sgn
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2021-04-01 14:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/29932#discussion_r605699358

Comment:
Don't do this, it will reset our hardening `CFLAGS`, put it outside of `do_build` instead. Anyway, isn't `-fno-rtti` for C++ only?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: lsp-plugins-1.1.30
  2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
                   ` (3 preceding siblings ...)
  2021-04-01 14:24 ` sgn
@ 2021-06-26 15:15 ` Logarithmus
  2022-03-29 20:46 ` paper42
  2022-03-29 20:46 ` [PR PATCH] [Closed]: " paper42
  6 siblings, 0 replies; 10+ messages in thread
From: Logarithmus @ 2021-06-26 15:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by Logarithmus on void-packages repository

https://github.com/void-linux/void-packages/pull/29932#issuecomment-869016942

Comment:
@paper42 seems this PR haven't been active for a while, so I decided to create another one based on your work: https://github.com/void-linux/void-packages/pull/31663

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: lsp-plugins-1.1.30
  2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
                   ` (4 preceding siblings ...)
  2021-06-26 15:15 ` Logarithmus
@ 2022-03-29 20:46 ` paper42
  2022-03-29 20:46 ` [PR PATCH] [Closed]: " paper42
  6 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-03-29 20:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/29932#issuecomment-1082357531

Comment:
outdated and superseded by 3 other PRs

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: New package: lsp-plugins-1.1.30
  2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
                   ` (5 preceding siblings ...)
  2022-03-29 20:46 ` paper42
@ 2022-03-29 20:46 ` paper42
  6 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2022-03-29 20:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

There's a closed pull request on the void-packages repository

New package: lsp-plugins-1.1.30
https://github.com/void-linux/void-packages/pull/29932

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->
very useful with pulseeffects

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: New package: lsp-plugins-1.1.30
  2021-10-21 15:35 [PR PATCH] " lemmi
@ 2022-06-23  2:15 ` github-actions
  0 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2022-06-23  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

There's a closed pull request on the void-packages repository

New package: lsp-plugins-1.1.30
https://github.com/void-linux/void-packages/pull/33672

Description:
Required for the EQ with easyeffects to work 

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->

#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: New package: lsp-plugins-1.1.30
  2021-06-26 15:59 [PR PATCH] " Logarithmus
@ 2022-04-11 13:21 ` Logarithmus
  0 siblings, 0 replies; 10+ messages in thread
From: Logarithmus @ 2022-04-11 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

There's a closed pull request on the void-packages repository

New package: lsp-plugins-1.1.30
https://github.com/void-linux/void-packages/pull/31664

Description:
Required by `pulseeffects` compressor, equalizer, delay & loudness compensator effects.
Also used by `easyeffects`, `pulseeffects`' successor 
Continuation of https://github.com/void-linux/void-packages/pull/29932

TODO:
- [ ] wait for https://github.com/sadko4u/lsp-plugins/pull/198
- [ ] implement `VERBOSE` option into `lsp-plugins` Makefiles to save my sanity debugging them
https://github.com/sadko4u/lsp-plugins/pull/200
- [ ] polish & upstream cross build patch https://github.com/sadko4u/lsp-plugins/pull/202
- [x] fix `i686`
- [x] fix `armv6`
- [x] split the package (ladspa, lv2, vst, jack, doc)
- [x] remove parallel check commit 

<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-06-23  2:15 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 14:09 [PR PATCH] New package: lsp-plugins-1.1.30 paper42
2021-04-01 14:12 ` [PR REVIEW] " ericonr
2021-04-01 14:24 ` sgn
2021-04-01 14:24 ` sgn
2021-04-01 14:24 ` sgn
2021-06-26 15:15 ` Logarithmus
2022-03-29 20:46 ` paper42
2022-03-29 20:46 ` [PR PATCH] [Closed]: " paper42
2021-06-26 15:59 [PR PATCH] " Logarithmus
2022-04-11 13:21 ` [PR PATCH] [Closed]: " Logarithmus
2021-10-21 15:35 [PR PATCH] " lemmi
2022-06-23  2:15 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).