Re: [PR REVIEW] wireplumber: Add runit service

[ahesford <ahesford@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/36416#discussion_r838491204

Comment:
`sv check pipewire` can't tell you if pipewire is running. It will only tell you if the service is linked in the service directory. For example, I believe `sv down pipewire` will still cause `sv check pipewire` to return success.

This works as most people expect for `sv check dbus` because `/etc/sv/dbus/check` exists and actually requires that the system bus be reachable before returning success. However, the pipewire service defines no `check` script so the check doesn't provide any real information.

If wireplumber *can* start before pipewire and will still do the right thing once the pipewire process is running, I would just drop the check altogether. If wireplumber dies when it starts before pipewire is running, dropping the check is OK too, because the service will just be retried until pipewire is up. However, if wireplumber starts but gets itself into an unrecoverable state (*e.g.*, starts its own pipewire process or simply hangs forever because it didn't find pipewire at startup) then something needs to be figured out to determine that pipewire is actually functional. This could be done here, or it could be done in an `/etc/sv/pipewire/check` script to make it available to all consumers.