From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [ci skip] Add cmake_generator variable
Date: Fri, 01 Apr 2022 16:54:52 +0200 [thread overview]
Message-ID: <20220401145452.obzccwabyaOPkRptb2khhmEDKvvyfZaiwD_mbLYsuf4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36455@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/36455#issuecomment-1085998886
Comment:
I don't think this adds any value. `CMAKE_GENERATOR` is already expected by CMake itself. The build style just sets a default if one isn't provided. Why define another variable, adding documentation and an xlint rule, just to copy it over?
next prev parent reply other threads:[~2022-04-01 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 14:50 [PR PATCH] " subnut
2022-04-01 14:54 ` ahesford [this message]
2022-04-04 15:44 ` [PR PATCH] [Closed]: [RFC][skip ci] " subnut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401145452.obzccwabyaOPkRptb2khhmEDKvvyfZaiwD_mbLYsuf4@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).