From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC]: xbps-src: add make_check_pre
Date: Wed, 06 Apr 2022 19:42:50 +0200 [thread overview]
Message-ID: <20220406174250.5IQWVVLQURjbnMp-XGYAIHfjMK9uCpUeXccwTag_6ww@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35888@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35888#issuecomment-1090548764
Comment:
> This is fine as is, but you could also consider `make_check_wrapper` or `make_check_runner` if you think those names make their purpose a little more obvious than `_pre`.
We can also set env. variables with make_check_pre, so I think make_check_pre is better, but if other people think make_check_wrap(per) would be better, I can switch it.
next prev parent reply other threads:[~2022-04-06 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 13:51 [PR PATCH] " paper42
2022-02-28 14:25 ` [PR PATCH] [Updated] " paper42
2022-02-28 14:29 ` tibequadorian
2022-03-27 22:01 ` paper42
2022-04-06 17:42 ` paper42 [this message]
2022-04-13 12:59 ` tibequadorian
2022-05-01 20:01 ` [PR PATCH] [Updated] " paper42
2022-05-04 8:46 ` [PR PATCH] [Merged]: " paper42
2022-05-08 1:16 ` sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406174250.5IQWVVLQURjbnMp-XGYAIHfjMK9uCpUeXccwTag_6ww@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).