Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Jupyter notebook updates
Date: Fri, 08 Apr 2022 16:06:45 +0200	[thread overview]
Message-ID: <20220408140645.Avbd-x9P086-KPDRYPkfJkkuKalhF3jd1UUg4kPTV8w@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36569@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

New review comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/36569#discussion_r846148315

Comment:
That is ugly. Also, `-k` doesn't seem to support syntax like `-k not(TestWebPDFExporter::test_webpdf_without_chromium)`. One can get away with `--deselect` but this requires passing the complete prefix (which includes the full path to the python file where the test is located).

I came up with this
```
make_check_args="-m not(network) -k not(test_webpdf_without_chromium)"
```
matching precisely the three tests that have to be disabled... but it's hard to extend, I'm almost inclined to prefer the completely explicit (but very verbose)
```
make_check_args="
 --deselect nbconvert/exporters/tests/test_webpdf.py::TestWebPDFExporter::test_export
 --deselect nbconvert/exporters/tests/test_webpdf.py::TestWebPDFExporter::test_webpdf_without_chromium
 --deselect nbconvert/tests/test_nbconvertapp.py::TestNbConvertApp::test_webpdf_with_chromium"
```
At least with this syntax is very clear what tests are being deselected and how to add more tests later...

I guess the optimal situation would be if upstream would mark these tests as requiring pyppeteer and skiping them if not available.

  parent reply	other threads:[~2022-04-08 14:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  1:52 [PR PATCH] " tornaria
2022-04-08  2:01 ` [PR REVIEW] " ahesford
2022-04-08  2:01 ` ahesford
2022-04-08 12:42 ` tornaria
2022-04-08 14:06 ` tornaria [this message]
2022-04-08 14:08 ` [PR PATCH] [Updated] " tornaria
2022-04-08 14:11 ` [PR REVIEW] " tornaria
2022-04-08 14:12 ` tornaria
2022-04-08 14:13 ` tornaria
2022-04-08 14:43 ` ahesford
2022-04-08 14:45 ` ahesford
2022-04-09  8:02 ` dkwo
2022-04-09  8:02 ` dkwo
2022-04-10 20:51 ` tornaria
2022-04-10 21:18 ` [PR PATCH] [Merged]: " ahesford
2022-04-11  0:42 ` tsndqst
2022-04-11  1:35 ` ahesford
2022-04-11  2:22 ` tornaria
2022-04-11  2:30 ` ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220408140645.Avbd-x9P086-KPDRYPkfJkkuKalhF3jd1UUg4kPTV8w@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).