From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] git-cliff: update to 0.6.1.
Date: Sat, 09 Apr 2022 11:50:03 +0200 [thread overview]
Message-ID: <20220409095003.EdGxLHjrpTGOzBMdSCC_4S5Csn8vbx-mvNNKxjOv2Pw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36588@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
New review comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/36588#discussion_r846608073
Comment:
like so?
```patch
diff --git a/srcpkgs/git-cliff/template b/srcpkgs/git-cliff/template
index 64c55a3c6d..96743e5781 100644
--- a/srcpkgs/git-cliff/template
+++ b/srcpkgs/git-cliff/template
@@ -17,8 +17,7 @@ checksum=045fb10ad0ee340172397f2bb6521c7ee0a83dca2c9f9d177300601f6c60184f
post_install() {
vdoc README.md
- mkdir completions
- OUT_DIR=completions vtargetrun ${DESTDIR}/usr/bin/git-cliff-completions
+ OUT_DIR=${PWD} vtargetrun ${DESTDIR}/usr/bin/git-cliff-completions
vcompletion "completions/_git-cliff" zsh
vcompletion "completions/git-cliff.fish" fish
```
next prev parent reply other threads:[~2022-04-09 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 12:27 [PR PATCH] " jcgruenhage
2022-04-09 9:17 ` jcgruenhage
2022-04-09 9:19 ` [PR PATCH] [Updated] " jcgruenhage
2022-04-09 9:46 ` [PR REVIEW] " paper42
2022-04-09 9:50 ` jcgruenhage [this message]
2022-04-09 10:01 ` [PR PATCH] [Updated] " jcgruenhage
2022-04-09 10:01 ` [PR REVIEW] " jcgruenhage
2022-04-09 10:02 ` [PR PATCH] [Updated] " jcgruenhage
2022-04-09 10:14 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220409095003.EdGxLHjrpTGOzBMdSCC_4S5Csn8vbx-mvNNKxjOv2Pw@z \
--to=jcgruenhage@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).