Github messages for voidlinux
 help / color / mirror / Atom feed
From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-GitPython: update to 3.1.27.
Date: Sat, 09 Apr 2022 12:37:01 +0200	[thread overview]
Message-ID: <20220409103701.b2nBMkaQnLo5wIyI5ak2SS3jOKMH9SNKPJoNkzYEniQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36597@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/36597#issuecomment-1093878257

Comment:
I might. As far as I know, most of it's functionality is implemented natively in python instead of by calling the git executable, but yeah, it does support calling the git executable.

In the tests it still fails to call the git executable though, even when git is in `depends` and `checkdepends`. Any ideas here? Those tests are still marked to be skipped as before, so no real changes here, but it'd be good to get this resolved in the long run.

```
>               raise GitCommandNotFound("git", err)
E               git.exc.GitCommandNotFound: Cmd('git') not found due to: 'Bad git executable.
E               The git executable must be specified in one of the following ways:
E                   - be included in your $PATH
E                   - be set via $GIT_PYTHON_GIT_EXECUTABLE
E                   - explicitly set via git.refresh()
E               '
E                 cmdline: git

git/cmd.py:365: GitCommandNotFound
----------------------------- Captured stderr call -----------------------------
/bin/sh: line 1: which: command not found
```

This is the relevant output from the tests, when they aren't being skipped. Happens both with `git` just being in the path, and `GIT_PYTHON_GIT_EXECUTABLE` explicitly being set to `/usr/bin/git`.

  reply	other threads:[~2022-04-09 10:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09  9:32 [PR PATCH] " jcgruenhage
2022-04-09 10:37 ` jcgruenhage [this message]
2022-04-09 10:37 ` [PR PATCH] [Updated] " jcgruenhage
2022-04-09 10:46 ` jcgruenhage
2022-04-09 10:49 ` jcgruenhage
2022-06-10 13:18 ` [PR PATCH] [Merged]: " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220409103701.b2nBMkaQnLo5wIyI5ak2SS3jOKMH9SNKPJoNkzYEniQ@z \
    --to=jcgruenhage@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).