[PR PATCH] vscode: update to 1.66.1

[PR PATCH] vscode: update to 1.66.1

[atk]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

There is a new pull request by atk against master on the void-packages repository

https://github.com/atk/void-packages vscode-1.66.1
https://github.com/void-linux/void-packages/pull/36633

vscode: update to 1.66.1
+ fix issue with node-gyp by moving npm installation before its compilation

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-1.66.1-36633.patch --]
[-- Type: text/x-diff, Size: 1962 bytes --]

From 582a3eb970c0ada51570132da9e73920128cdd61 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alexthkloss@web.de>
Date: Mon, 11 Apr 2022 09:40:43 +0200
Subject: [PATCH] vscode: update to 1.66.1

+ fix issue with node-gyp compilation, which may also depend on npm
---
 srcpkgs/vscode/template | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index 0b9efda224d0..3e3956fa5644 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,6 +1,6 @@
 # Template file for 'vscode'
 pkgname=vscode
-version=1.66.0
+version=1.66.1
 revision=1
 _electronver=13.6.7
 _npmver=8.6.0
@@ -11,8 +11,8 @@ short_desc="Microsoft Code for Linux"
 maintainer="shizonic <realtiaz@gmail.com>, Alex Lohr <alex.lohr@logmein.com>"
 license="MIT"
 homepage="https://code.visualstudio.com/"
-distfiles="https://github.com/Microsoft/vscode/archive/${version}.tar.gz"
-checksum=1c93918ebd00b8e9fc0d8fea13cbe2947f5b83d2d8f5c8d1b00bde885bb925d7
+distfiles="https://github.com/Microsoft/vscode/archive/refs/tags/${version}.tar.gz"
+checksum=243a25d7214ceba5abf510dc890c64a8cc36ccacd97f4b8c666b8b7bab9c5a28
 nocross=yes # x64 build does not cut it, it contains native code
 
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
@@ -38,6 +38,9 @@ do_configure() {
 }
 
 do_build() {
+	# Update to a more recent npm version to fix some issues
+	npm install -g npm@${_npmver}
+
 	# The default memory limit may be too low for current versions of node
 	# to successfully build vscode.  This sets it to 4GB, but
 	# change this number if it still doesn't work for your system.
@@ -48,8 +51,7 @@ do_build() {
 	--target=$_electronver \
 	--tarball=/usr/include/electron${_electronver%%.*}/node_headers.tar.gz
 
-	npm install -g npm@${_npmver} && \
-		yarn install --ignore-engines --arch=x64
+	yarn install --ignore-engines --arch=x64
 
 	export CFLAGS="$CFLAGS -I/usr/include/node"
 	yarn run gulp vscode-linux-x64-min

Re: vscode: update to 1.66.1

[atk]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/36633#issuecomment-1094673443

Comment:
This one was too fast for the revamping of our node packages.

Re: [PR PATCH] [Merged]: vscode: update to 1.66.1

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

There's a merged pull request on the void-packages repository

vscode: update to 1.66.1
https://github.com/void-linux/void-packages/pull/36633

Description:
+ fix issue with node-gyp by moving npm installation before its compilation

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->