[PR PATCH] curl: restore libcurl-gnutls symlink from libcurl.

[PR PATCH] curl: restore libcurl-gnutls symlink from libcurl.

[prez]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

There is a new pull request by prez against master on the void-packages repository

https://github.com/prez/void-packages curl
https://github.com/void-linux/void-packages/pull/36619

curl: restore libcurl-gnutls symlink from libcurl.
Without this, many proprietary audio plugins aren't functional.


A patch file from https://github.com/void-linux/void-packages/pull/36619.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-curl-36619.patch --]
[-- Type: text/x-diff, Size: 1452 bytes --]

From f140bcad7d2de95ee151bb0775f882b9a2c46cf7 Mon Sep 17 00:00:00 2001
From: prez <prez@national.shitposting.agency>
Date: Sun, 10 Apr 2022 19:52:38 +0200
Subject: [PATCH] curl: restore libcurl-gnutls symlink from libcurl.

---
 common/shlibs         | 1 +
 srcpkgs/curl/template | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/common/shlibs b/common/shlibs
index 673c62085f5b..0858cc096712 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -366,6 +366,7 @@ libnssdbm3.so nss-3.12.4_1
 libnssckbi.so nss-3.12.4_1
 libnss3.so nss-3.12.4_1
 libcurl.so.4 libcurl-7.75.0_2
+libcurl-gnutls.so.4 libcurl-7.75.0_2
 libdaemon.so.0 libdaemon-0.14_1
 libavahi-common.so.3 avahi-libs-0.6.25_1
 libavahi-core.so.7 avahi-libs-0.6.25_1
diff --git a/srcpkgs/curl/template b/srcpkgs/curl/template
index 16a1abd02150..2c1e70f314b1 100644
--- a/srcpkgs/curl/template
+++ b/srcpkgs/curl/template
@@ -1,7 +1,7 @@
 # Template file for 'curl'
 pkgname=curl
 version=7.82.0
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="ac_cv_sizeof_off_t=8 --enable-threaded-resolver --enable-ipv6
  $(vopt_with rtmp) $(vopt_with gssapi) $(vopt_enable ldap) $(vopt_with gnutls)
@@ -66,8 +66,10 @@ post_install() {
 
 libcurl_package() {
 	short_desc="Multiprotocol file transfer library"
+	shlib_provides="libcurl-gnutls.so.4"
 	pkg_install() {
 		vmove "usr/lib/*.so.*"
+		ln -sf libcurl.so.4 ${PKGDESTDIR}/usr/lib/libcurl-gnutls.so.4
 	}
 }
 

Re: curl: restore libcurl-gnutls symlink from libcurl.

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1095318831

Comment:
This sounds wrong, we use openssl by default for libcurl.

Re: curl: restore libcurl-gnutls symlink from libcurl.

[prez]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1095336132

Comment:
Do you think we shouldn't do this since it's too ugly for making some broken programs work?
Using patchelf in those cases might be possible I think? 

But I don't see how this could be detrimental, given that this compatibility symlink was already present up until recently.

Re: curl: restore libcurl-gnutls symlink from libcurl.

[fdziarmagowski]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by fdziarmagowski on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1159058714

Comment:
What would be the "void" way of fixing that? Building a separate libcurl-gnutls? Or extend the original curl package it and provide gnutls linked version? For sake of completeness: this pull request is totally bogus. 

Re: curl: restore libcurl-gnutls symlink from libcurl.

[prez]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1159124898

Comment:
> For sake of completeness: this pull request is totally bogus

Elaborate.

Re: curl: restore libcurl-gnutls symlink from libcurl.

[fdziarmagowski]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

New comment by fdziarmagowski on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1159199864

Comment:
You can't just create a soname to a incompatible library version and even worse, make the build system using it (setting bogus shlib_provides). this is not improving Void in any form, just making it broken (therefore used "bogus" to describe that)
What about less ugly workaround? https://gist.github.com/fdziarmagowski/8e7616910fa1ababb7ce3321e3e63c03
Btw, I use the plugins you mentioned (i.e. Audio Assault), but they are creating Linux packages for mainstream distributions. I was thinking about asking the support to create a "static" version of their plugins, this should be sufficient to run it everywhere, even on Void.

Re: curl: restore libcurl-gnutls symlink from libcurl.

[prez]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1159280896

Comment:
>You can't just create a soname to a incompatible library version and even worse, make the build system using it (setting bogus shlib_provides). this is not improving Void in any form, [...]

As stated in the first comment, this was just a revert of something that was present in Void before, I'm merely trying to un-break things.

>What about less ugly workaround? https://gist.github.com/fdziarmagowski/8e7616910fa1ababb7ce3321e3e63c03

Having two versions of libcurl as packages that differ in the TLS lib seems very ugly to me.

>I was thinking about asking the support to create a "static" version of their plugins, this should be sufficient to run it everywhere, even on Void.

Not a solution, imho. I don't even remember what plugin it was, since I just created the symlink and moved on. But there are probably a number of proprietary applications that rely on the existence of said symlink. 

Re: curl: restore libcurl-gnutls symlink from libcurl.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1186593922

Comment:
> You can't just create a soname to a incompatible library version and even worse, make the build system using it (setting bogus shlib_provides). this is not improving Void in any form, just making it broken (therefore used "bogus" to describe that)

It's not incompatible. The issue is Debian doing Debian things and naming their libcurl after the TLS library used to build it, for whatever license compatibility reason. The libcurl API/ABI is the same across the library versions.

We removed the workaround from the curl package because that felt like the wrong place for it; it's not really our place to provide this fix.

> I was thinking about asking the support to create a "static" version of their plugins, this should be sufficient to run it everywhere, even on Void.

How would that work? If plugins are dlopened, linking them as statically as possible can be complicated business.

Re: curl: restore libcurl-gnutls symlink from libcurl.

[fdziarmagowski]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by fdziarmagowski on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1190742640

Comment:
@ericonr Thanks for clarifying. It wasn't clear to me about the compatibility of both versions.
@prez sorry for being rude, your change wasn't as I called it bogus.

Re: curl: restore libcurl-gnutls symlink from libcurl.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1283293049

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: curl: restore libcurl-gnutls symlink from libcurl.

[biopsin]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1283410240

Comment:
Also makes no sense why Juce is forcing dep on libcurl in the first place see my question @ https://github.com/reales/OB-Xd/issues/46

Re: curl: restore libcurl-gnutls symlink from libcurl.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/36619#issuecomment-1396344651

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: curl: restore libcurl-gnutls symlink from libcurl.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

There's a closed pull request on the void-packages repository

curl: restore libcurl-gnutls symlink from libcurl.
https://github.com/void-linux/void-packages/pull/36619

Description:
Without this, many proprietary audio plugins aren't functional.
Removed in https://github.com/void-linux/void-packages/pull/25764