Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] threejs-sage: make it available as a jupyter nbextension
@ 2022-04-11 20:58 tornaria
  2022-04-12 17:46 ` [PR PATCH] [Merged]: " leahneukirchen
  0 siblings, 1 reply; 2+ messages in thread
From: tornaria @ 2022-04-11 20:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages threejs
https://github.com/void-linux/void-packages/pull/36644

threejs-sage: make it available as a jupyter nbextension
Adds a symlink in /usr/share/jupyter/nbextensions, so that the js is available in a jupyter notebook.

Otherwise, using 3d plots in the jupyter notebook will hit jsdelivr.net.

#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/36644.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-threejs-36644.patch --]
[-- Type: text/x-diff, Size: 1310 bytes --]

From 2db5f8d9713631d27a12bf14399006f23e0979bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 11 Apr 2022 17:49:21 -0300
Subject: [PATCH] threejs-sage: make it available as a jupyter nbextension

Adds a symlink in /usr/share/jupyter/nbextensions, so that the js is
available in a jupyter notebook.

Otherwise, using 3d plots in the jupyter notebook will hit jsdelivr.net.
---
 srcpkgs/threejs-sage/template | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/threejs-sage/template b/srcpkgs/threejs-sage/template
index cb5c87a19c12..9cdb0fb3848d 100644
--- a/srcpkgs/threejs-sage/template
+++ b/srcpkgs/threejs-sage/template
@@ -1,7 +1,7 @@
 # Template file for 'threejs-sage'
 pkgname=threejs-sage
 version=r122
-revision=1
+revision=2
 short_desc="Custom build of three.js for sagemath"
 maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
 license="MIT"
@@ -13,4 +13,8 @@ do_install() {
 	vlicense LICENSE
 	vinstall version 644 usr/share/sagemath/threejs-sage
 	vinstall build/three.min.js 644 usr/share/sagemath/threejs-sage/$version
+
+	# make threejs available as a jupyter notebook extension
+	vmkdir usr/share/jupyter/nbextensions
+	ln -s /usr/share/sagemath/threejs-sage ${DESTDIR}/usr/share/jupyter/nbextensions
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: threejs-sage: make it available as a jupyter nbextension
  2022-04-11 20:58 [PR PATCH] threejs-sage: make it available as a jupyter nbextension tornaria
@ 2022-04-12 17:46 ` leahneukirchen
  0 siblings, 0 replies; 2+ messages in thread
From: leahneukirchen @ 2022-04-12 17:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There's a merged pull request on the void-packages repository

threejs-sage: make it available as a jupyter nbextension
https://github.com/void-linux/void-packages/pull/36644

Description:
Adds a symlink in /usr/share/jupyter/nbextensions, so that the js is available in a jupyter notebook.

Otherwise, using 3d plots in the jupyter notebook will hit jsdelivr.net.

#### Testing the changes
- I tested the changes in this PR: **YES**

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-12 17:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 20:58 [PR PATCH] threejs-sage: make it available as a jupyter nbextension tornaria
2022-04-12 17:46 ` [PR PATCH] [Merged]: " leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).