Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] common/hooks/pre-pkg/04-generate-runtime-deps.sh: sort deps for reproducibility
Date: Wed, 13 Apr 2022 20:12:19 +0200	[thread overview]
Message-ID: <20220413181219._moWcEl-VtZ2NKrTVJt5uKGrJWS5FZ96fyjUpGgl_aY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36659@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/36659#discussion_r849762085

Comment:
Reading and writing same file in one pipeline looks like race which can truncate file, did you test?

It can be simplified to 

        printf -- "${_curdep}\n"
      done | sort | xargs > ${PKGDESTDIR}/rdeps
    fi

without truncating file inside `if`.

  parent reply	other threads:[~2022-04-13 18:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 19:29 [PR PATCH] " classabbyamp
2022-04-13 18:10 ` [PR REVIEW] " Chocimier
2022-04-13 18:10 ` Chocimier
2022-04-13 18:12 ` Chocimier [this message]
2022-04-13 18:12 ` Chocimier
2022-04-13 18:16 ` classabbyamp
2022-04-13 18:16 ` [PR PATCH] [Updated] " classabbyamp
2022-04-13 18:17 ` [PR REVIEW] " classabbyamp
2022-04-13 18:18 ` classabbyamp
2022-04-13 23:31 ` Duncaen
2022-04-13 23:34 ` classabbyamp
2022-04-13 23:35 ` classabbyamp
2022-04-13 23:36 ` classabbyamp
2022-04-13 23:36 ` classabbyamp
2022-04-14 18:29 ` [PR PATCH] [Updated] " classabbyamp
2022-04-14 18:43 ` classabbyamp
2022-04-19 15:30 ` classabbyamp
2022-04-19 17:45 ` [PR REVIEW] " Chocimier
2022-04-19 17:49 ` [PR PATCH] [Updated] " classabbyamp
2022-04-19 17:49 ` [PR REVIEW] " classabbyamp
2022-04-25 14:52 ` [PR PATCH] [Updated] " classabbyamp
2022-05-07 15:15 ` classabbyamp
2022-05-13 19:21 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220413181219._moWcEl-VtZ2NKrTVJt5uKGrJWS5FZ96fyjUpGgl_aY@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).