[PR PATCH] Fix some checks

[PR PATCH] Fix some checks

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages fix-some-checks
https://github.com/void-linux/void-packages/pull/36616

Fix some checks
<!-- Uncomment relevant sections and delete options which are not applicable -->

Credit goes to author of https://github.com/void-linux/void-packages/pull/34489 for helping me figure out how to fix these.

#### Testing the changes
- I tested the changes in this PR: I ran `./xbps-src check` on the changed packages

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36616.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-some-checks-36616.patch --]
[-- Type: text/x-diff, Size: 4080 bytes --]

From 400b025f032e76236960d716a624f218ed7fcec4 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:32:51 +0300
Subject: [PATCH 1/5] python3-click-log: fix tests.

---
 srcpkgs/python3-click-log/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/python3-click-log/template b/srcpkgs/python3-click-log/template
index 6f966c248fc9..07f1c5b0eba5 100644
--- a/srcpkgs/python3-click-log/template
+++ b/srcpkgs/python3-click-log/template
@@ -6,6 +6,7 @@ wrksrc="click-log-${version}"
 build_style="python3-module"
 hostmakedepends="python3-setuptools"
 depends="python3-click"
+checkdepends="$depends python3-pytest"
 short_desc="Logging integration for Click (Python3)"
 maintainer="Oliver Kiddle <okiddle@yahoo.co.uk>"
 license="MIT"

From 4190449f109a91e4488c83bafb9d5b972974deaf Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:33:13 +0300
Subject: [PATCH 2/5] python3-click-plugins: fix tests.

---
 srcpkgs/python3-click-plugins/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/python3-click-plugins/template b/srcpkgs/python3-click-plugins/template
index 142900633bb6..d3f93864a349 100644
--- a/srcpkgs/python3-click-plugins/template
+++ b/srcpkgs/python3-click-plugins/template
@@ -7,6 +7,7 @@ build_style=python3-module
 pycompile_module="click-plugins"
 hostmakedepends="python3-setuptools"
 depends="python3-click"
+checkdepends="$depends python3-pytest"
 short_desc="Python3-click module extension to register CLI commands"
 maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="BSD-2-Clause"

From 84bbde41c647ff6c0f71cd824a7e2290bb19e8f9 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:33:43 +0300
Subject: [PATCH 3/5] python3-click-repl: disable tests.

---
 srcpkgs/python3-click-repl/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/python3-click-repl/template b/srcpkgs/python3-click-repl/template
index b5cf6e495fcb..d4c78ba72332 100644
--- a/srcpkgs/python3-click-repl/template
+++ b/srcpkgs/python3-click-repl/template
@@ -12,6 +12,8 @@ license="MIT"
 homepage="https://github.com/click-contrib/click-repl"
 distfiles="${PYPI_SITE}/c/click-repl/click-repl-${version}.tar.gz"
 checksum=b9f29d52abc4d6059f8e276132a111ab8d94980afe6a5432b9d996544afa95d5
+# The tarball from PyPI has no tests.
+make_check=no
 
 post_install() {
 	vlicense LICENSE

From 6e738328ffb9c976f021b59932f82777cb58424b Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:35:14 +0300
Subject: [PATCH 4/5] python3-click-threading: fix tests.

---
 srcpkgs/python3-click-threading/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/python3-click-threading/template b/srcpkgs/python3-click-threading/template
index b639065db3d6..66bd90de3fd8 100644
--- a/srcpkgs/python3-click-threading/template
+++ b/srcpkgs/python3-click-threading/template
@@ -6,6 +6,7 @@ wrksrc="click-threading-${version}"
 build_style="python3-module"
 hostmakedepends="python3-setuptools"
 depends="python3-click"
+checkdepends="$depends python3-pytest"
 short_desc="Multithreaded Click apps made easy (Python3)"
 maintainer="Oliver Kiddle <okiddle@yahoo.co.uk>"
 license="MIT"

From f4a5f6afdee5c7cd48cedb5c7db3ade7f031941a Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:35:25 +0300
Subject: [PATCH 5/5] python3-userpath: fix tests.

---
 srcpkgs/python3-userpath/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/python3-userpath/template b/srcpkgs/python3-userpath/template
index b557bc2528af..e8c900b2315a 100644
--- a/srcpkgs/python3-userpath/template
+++ b/srcpkgs/python3-userpath/template
@@ -7,6 +7,7 @@ build_style=python3-module
 pycompile_module="userpath"
 hostmakedepends="python3-setuptools"
 depends="python3-click"
+checkdepends="$depends python3-pytest"
 short_desc="Cross-platform tool for adding locations to the user PATH"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="MIT, Apache-2.0"

Re: Fix some checks

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36616#issuecomment-1094329575

Comment:
Shall I also fix the lint failures? (they're not due to my changes to be clear)

Re: Fix some checks

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36616#issuecomment-1094329575

Comment:
Shall I also fix the lint failures? (they're unrelated to my changes to be clear)

Re: Fix some checks

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36616#issuecomment-1097040880

Comment:
> Shall I also fix the lint failures?

those are simple enough to fix, I think it's reasonable to do it in this PR

Re: [PR PATCH] [Updated] Fix some checks

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages fix-some-checks
https://github.com/void-linux/void-packages/pull/36616

Fix some checks
<!-- Uncomment relevant sections and delete options which are not applicable -->

Credit goes to author of https://github.com/void-linux/void-packages/pull/34489 for helping me figure out how to fix these.

#### Testing the changes
- I ran `./xbps-src check` on the changed packages

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36616.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-some-checks-36616.patch --]
[-- Type: text/x-diff, Size: 4231 bytes --]

From 400b025f032e76236960d716a624f218ed7fcec4 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:32:51 +0300
Subject: [PATCH 1/5] python3-click-log: fix tests.

---
 srcpkgs/python3-click-log/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/python3-click-log/template b/srcpkgs/python3-click-log/template
index 6f966c248fc9..07f1c5b0eba5 100644
--- a/srcpkgs/python3-click-log/template
+++ b/srcpkgs/python3-click-log/template
@@ -6,6 +6,7 @@ wrksrc="click-log-${version}"
 build_style="python3-module"
 hostmakedepends="python3-setuptools"
 depends="python3-click"
+checkdepends="$depends python3-pytest"
 short_desc="Logging integration for Click (Python3)"
 maintainer="Oliver Kiddle <okiddle@yahoo.co.uk>"
 license="MIT"

From 38cfcda463ac13d83fbed050f5c21341a4528160 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:33:13 +0300
Subject: [PATCH 2/5] python3-click-plugins: fix tests.

---
 srcpkgs/python3-click-plugins/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/python3-click-plugins/template b/srcpkgs/python3-click-plugins/template
index 142900633bb6..3fffc0e849fc 100644
--- a/srcpkgs/python3-click-plugins/template
+++ b/srcpkgs/python3-click-plugins/template
@@ -4,9 +4,9 @@ version=1.1.1
 revision=4
 wrksrc="click-plugins-${version}"
 build_style=python3-module
-pycompile_module="click-plugins"
 hostmakedepends="python3-setuptools"
 depends="python3-click"
+checkdepends="$depends python3-pytest"
 short_desc="Python3-click module extension to register CLI commands"
 maintainer="Alex Childs <misuchiru03+void@gmail.com>"
 license="BSD-2-Clause"

From c697fb168032aedfeeeab7814d90f1f1d9c36728 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:33:43 +0300
Subject: [PATCH 3/5] python3-click-repl: disable tests.

---
 srcpkgs/python3-click-repl/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/python3-click-repl/template b/srcpkgs/python3-click-repl/template
index b5cf6e495fcb..d4c78ba72332 100644
--- a/srcpkgs/python3-click-repl/template
+++ b/srcpkgs/python3-click-repl/template
@@ -12,6 +12,8 @@ license="MIT"
 homepage="https://github.com/click-contrib/click-repl"
 distfiles="${PYPI_SITE}/c/click-repl/click-repl-${version}.tar.gz"
 checksum=b9f29d52abc4d6059f8e276132a111ab8d94980afe6a5432b9d996544afa95d5
+# The tarball from PyPI has no tests.
+make_check=no
 
 post_install() {
 	vlicense LICENSE

From b6a6f0c5c6d955f1692e3156e45f40b722c1509c Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:35:14 +0300
Subject: [PATCH 4/5] python3-click-threading: fix tests.

---
 srcpkgs/python3-click-threading/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/python3-click-threading/template b/srcpkgs/python3-click-threading/template
index b639065db3d6..66bd90de3fd8 100644
--- a/srcpkgs/python3-click-threading/template
+++ b/srcpkgs/python3-click-threading/template
@@ -6,6 +6,7 @@ wrksrc="click-threading-${version}"
 build_style="python3-module"
 hostmakedepends="python3-setuptools"
 depends="python3-click"
+checkdepends="$depends python3-pytest"
 short_desc="Multithreaded Click apps made easy (Python3)"
 maintainer="Oliver Kiddle <okiddle@yahoo.co.uk>"
 license="MIT"

From 20d2a172bef27a22dd5bee5277a4182517346d2e Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Sun, 10 Apr 2022 19:35:25 +0300
Subject: [PATCH 5/5] python3-userpath: fix tests.

---
 srcpkgs/python3-userpath/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/python3-userpath/template b/srcpkgs/python3-userpath/template
index b557bc2528af..8fc30c9a52f5 100644
--- a/srcpkgs/python3-userpath/template
+++ b/srcpkgs/python3-userpath/template
@@ -4,9 +4,9 @@ version=1.7.0
 revision=2
 wrksrc="userpath-${version}"
 build_style=python3-module
-pycompile_module="userpath"
 hostmakedepends="python3-setuptools"
 depends="python3-click"
+checkdepends="$depends python3-pytest"
 short_desc="Cross-platform tool for adding locations to the user PATH"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="MIT, Apache-2.0"

Re: Fix some checks

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36616#issuecomment-1097959733

Comment:
@classabbyamp done.

Re: [PR PATCH] [Merged]: Fix some checks

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

There's a merged pull request on the void-packages repository

Fix some checks
https://github.com/void-linux/void-packages/pull/36616

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

Credit goes to author of https://github.com/void-linux/void-packages/pull/34489 for helping me figure out how to fix these.

#### Testing the changes
- I ran `./xbps-src check` on the changed packages

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->