[PR PATCH] New package: SDRPlusPlus-1.0.4

[PR PATCH] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

There is a new pull request by TorMFinn against master on the void-packages repository

https://github.com/TorMFinn/void-packages master
https://github.com/void-linux/void-packages/pull/36666

New package: SDRPlusPlus-1.0.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/36666.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-36666.patch --]
[-- Type: text/x-diff, Size: 1337 bytes --]

From ace15a33611e35f94a4711e3180a2a095bf49714 Mon Sep 17 00:00:00 2001
From: Tor Morten Finnesand <tmf@kvstech.no>
Date: Wed, 13 Apr 2022 09:02:10 +0200
Subject: [PATCH] New package: SDRPlusPlus-1.0.4

---
 srcpkgs/SDRPlusPlus/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/SDRPlusPlus/template

diff --git a/srcpkgs/SDRPlusPlus/template b/srcpkgs/SDRPlusPlus/template
new file mode 100644
index 000000000000..d5d5c904a00a
--- /dev/null
+++ b/srcpkgs/SDRPlusPlus/template
@@ -0,0 +1,17 @@
+# Template file for 'SDRPlusPlus'
+pkgname=SDRPlusPlus
+version=1.0.4
+revision=1
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DOPT_BUILD_AIRSPYHF_SOURCE=OFF
+ -DOPT_BUILD_PLUTOSDR_SOURCE=OFF"
+hostmakedepends="cmake pkg-config"
+makedepends="glfw-devel librtlsdr-devel glew-devel libhackrf-devel libusb-devel
+ SoapySDR-devel libairspy-devel rtaudio-devel alsa-lib-devel pulseaudio-devel
+ jack-devel fftw-devel volk-devel"
+short_desc="SDR++ is a cross-platform and open source SDR software"
+maintainer="Tor Morten Finnesand <tmf@kvstech.no>"
+license="GPL-3.0-or-later"
+homepage="https://www.sdrpp.org/"
+distfiles="https://github.com/AlexandreRouma/SDRPlusPlus/archive/refs/tags/${version}.tar.gz"
+checksum="251256de6725ceb4f9fb2823c7ad825068ad16cf9b5fb894259b173aae5a69ea"

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r849166704

Comment:
it might not be optimal to have this depend on alsa, pulse, *and* jack (assuming those become shlib deps for the final package)

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r849162572

Comment:
this is a bit of a useless description, and should generally be in the form of a phrase

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[paper42]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r849229250

Comment:
I think it's ok, it will only depend on libjack, libpulseaudio and alsa-lib

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

New review comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r849451553

Comment:
It does not seem to pick up either of them as runtime dependencies, so I guess the user will have to install the audio packages they want to use themselves. Is my observations correct?

`=> SDRPlusPlus-1.0.4_1: running pre-pkg hook: 999-collected-rdeps ...
   libstdc++>=4.4.0_1 libgcc>=4.4.0_1 glibc>=2.32_1 volk>=2.5.0_1 rtaudio>=5.1.0_1 SoapySDR>=0.7.0_1 libairspy>=1.0.9_1 librtlsdr>=0.5.3_1 libhackrf>=2017.02.1_1 libglvnd>=1.3.0_1 glew>=2.2.0_1 libfftw>=3.3_1 glfw>=3.0.4_1 
`

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New review comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r849453279

Comment:
I agree, though I picked the description from the official [documentation.](https://github.com/AlexandreRouma/SDRPlusPlus) Not sure what else to call it

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r849640972

Comment:
i guess then something like "open source SDR software" 

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r849642300

Comment:
then it probably `dlopen()`s the audio shlibs,and the user would have to install one themself. 

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r850267636

Comment:
> then it probably `dlopen()`s the audio shlibs,and the user would have to install one themself.

That's perfect then :)

Re: [PR PATCH] [Updated] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

There is an updated pull request by TorMFinn against master on the void-packages repository

https://github.com/TorMFinn/void-packages master
https://github.com/void-linux/void-packages/pull/36666

New package: SDRPlusPlus-1.0.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/36666.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-36666.patch --]
[-- Type: text/x-diff, Size: 1307 bytes --]

From ccfef3e2f0c50673865d5396aec0399a4a76ff18 Mon Sep 17 00:00:00 2001
From: Tor Morten Finnesand <tmf@kvstech.no>
Date: Wed, 13 Apr 2022 09:02:10 +0200
Subject: [PATCH] New package: SDRPlusPlus-1.0.4

---
 srcpkgs/SDRPlusPlus/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/SDRPlusPlus/template

diff --git a/srcpkgs/SDRPlusPlus/template b/srcpkgs/SDRPlusPlus/template
new file mode 100644
index 000000000000..c6dc35d5ec0d
--- /dev/null
+++ b/srcpkgs/SDRPlusPlus/template
@@ -0,0 +1,17 @@
+# Template file for 'SDRPlusPlus'
+pkgname=SDRPlusPlus
+version=1.0.4
+revision=1
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DOPT_BUILD_AIRSPYHF_SOURCE=OFF
+ -DOPT_BUILD_PLUTOSDR_SOURCE=OFF"
+hostmakedepends="cmake pkg-config"
+makedepends="glfw-devel librtlsdr-devel glew-devel libhackrf-devel libusb-devel
+ SoapySDR-devel libairspy-devel rtaudio-devel alsa-lib-devel pulseaudio-devel
+ jack-devel fftw-devel volk-devel"
+short_desc="open source SDR software"
+maintainer="Tor Morten Finnesand <tmf@kvstech.no>"
+license="GPL-3.0-or-later"
+homepage="https://www.sdrpp.org/"
+distfiles="https://github.com/AlexandreRouma/SDRPlusPlus/archive/refs/tags/${version}.tar.gz"
+checksum="251256de6725ceb4f9fb2823c7ad825068ad16cf9b5fb894259b173aae5a69ea"

Re: [PR REVIEW] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New review comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#discussion_r850270388

Comment:
> i guess then something like "open source SDR software"

Updated 

Re: New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#issuecomment-1102203229

Comment:
Anything else required from me before this can be merged?

Re: [PR PATCH] [Updated] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

There is an updated pull request by TorMFinn against master on the void-packages repository

https://github.com/TorMFinn/void-packages master
https://github.com/void-linux/void-packages/pull/36666

New package: SDRPlusPlus-1.0.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/36666.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-36666.patch --]
[-- Type: text/x-diff, Size: 1307 bytes --]

From 2e5ed1db99d8cffa9c277fadc72e24df7920bcbc Mon Sep 17 00:00:00 2001
From: Tor Morten Finnesand <tmf@kvstech.no>
Date: Wed, 13 Apr 2022 09:02:10 +0200
Subject: [PATCH] New package: SDRPlusPlus-1.0.4

---
 srcpkgs/SDRPlusPlus/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/SDRPlusPlus/template

diff --git a/srcpkgs/SDRPlusPlus/template b/srcpkgs/SDRPlusPlus/template
new file mode 100644
index 000000000000..c6dc35d5ec0d
--- /dev/null
+++ b/srcpkgs/SDRPlusPlus/template
@@ -0,0 +1,17 @@
+# Template file for 'SDRPlusPlus'
+pkgname=SDRPlusPlus
+version=1.0.4
+revision=1
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DOPT_BUILD_AIRSPYHF_SOURCE=OFF
+ -DOPT_BUILD_PLUTOSDR_SOURCE=OFF"
+hostmakedepends="cmake pkg-config"
+makedepends="glfw-devel librtlsdr-devel glew-devel libhackrf-devel libusb-devel
+ SoapySDR-devel libairspy-devel rtaudio-devel alsa-lib-devel pulseaudio-devel
+ jack-devel fftw-devel volk-devel"
+short_desc="open source SDR software"
+maintainer="Tor Morten Finnesand <tmf@kvstech.no>"
+license="GPL-3.0-or-later"
+homepage="https://www.sdrpp.org/"
+distfiles="https://github.com/AlexandreRouma/SDRPlusPlus/archive/refs/tags/${version}.tar.gz"
+checksum="251256de6725ceb4f9fb2823c7ad825068ad16cf9b5fb894259b173aae5a69ea"

Re: [PR PATCH] [Updated] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

There is an updated pull request by TorMFinn against master on the void-packages repository

https://github.com/TorMFinn/void-packages master
https://github.com/void-linux/void-packages/pull/36666

New package: SDRPlusPlus-1.0.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/36666.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-36666.patch --]
[-- Type: text/x-diff, Size: 1307 bytes --]

From 250533c80cbfe977dbe059c081588d319a49d756 Mon Sep 17 00:00:00 2001
From: Tor Morten Finnesand <tmf@kvstech.no>
Date: Wed, 13 Apr 2022 09:02:10 +0200
Subject: [PATCH] New package: SDRPlusPlus-1.0.4

---
 srcpkgs/SDRPlusPlus/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/SDRPlusPlus/template

diff --git a/srcpkgs/SDRPlusPlus/template b/srcpkgs/SDRPlusPlus/template
new file mode 100644
index 000000000000..c6dc35d5ec0d
--- /dev/null
+++ b/srcpkgs/SDRPlusPlus/template
@@ -0,0 +1,17 @@
+# Template file for 'SDRPlusPlus'
+pkgname=SDRPlusPlus
+version=1.0.4
+revision=1
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DOPT_BUILD_AIRSPYHF_SOURCE=OFF
+ -DOPT_BUILD_PLUTOSDR_SOURCE=OFF"
+hostmakedepends="cmake pkg-config"
+makedepends="glfw-devel librtlsdr-devel glew-devel libhackrf-devel libusb-devel
+ SoapySDR-devel libairspy-devel rtaudio-devel alsa-lib-devel pulseaudio-devel
+ jack-devel fftw-devel volk-devel"
+short_desc="open source SDR software"
+maintainer="Tor Morten Finnesand <tmf@kvstech.no>"
+license="GPL-3.0-or-later"
+homepage="https://www.sdrpp.org/"
+distfiles="https://github.com/AlexandreRouma/SDRPlusPlus/archive/refs/tags/${version}.tar.gz"
+checksum="251256de6725ceb4f9fb2823c7ad825068ad16cf9b5fb894259b173aae5a69ea"

Re: New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by TorMFinn on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#issuecomment-1111364118

Comment:
@paper42 Could you re-run the pipeline? I saw it was triggered recently but failed due to my branch being out of date.

Re: [PR PATCH] [Updated] New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

There is an updated pull request by TorMFinn against master on the void-packages repository

https://github.com/TorMFinn/void-packages master
https://github.com/void-linux/void-packages/pull/36666

New package: SDRPlusPlus-1.0.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/36666.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-36666.patch --]
[-- Type: text/x-diff, Size: 1307 bytes --]

From 290add2ec27e48923c55ac06388d12a675a48021 Mon Sep 17 00:00:00 2001
From: Tor Morten Finnesand <tmf@kvstech.no>
Date: Wed, 13 Apr 2022 09:02:10 +0200
Subject: [PATCH] New package: SDRPlusPlus-1.0.4

---
 srcpkgs/SDRPlusPlus/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/SDRPlusPlus/template

diff --git a/srcpkgs/SDRPlusPlus/template b/srcpkgs/SDRPlusPlus/template
new file mode 100644
index 000000000000..051a85f989f8
--- /dev/null
+++ b/srcpkgs/SDRPlusPlus/template
@@ -0,0 +1,17 @@
+# Template file for 'SDRPlusPlus'
+pkgname=SDRPlusPlus
+version=1.0.4
+revision=1
+build_style=cmake
+configure_args="-DCMAKE_BUILD_TYPE=Release -DOPT_BUILD_AIRSPYHF_SOURCE=OFF
+ -DOPT_BUILD_PLUTOSDR_SOURCE=OFF"
+hostmakedepends="cmake pkg-config"
+makedepends="glfw-devel librtlsdr-devel glew-devel libhackrf-devel libusb-devel
+ SoapySDR-devel libairspy-devel rtaudio-devel alsa-lib-devel pulseaudio-devel
+ jack-devel fftw-devel volk-devel"
+short_desc="Open source SDR software"
+maintainer="Tor Morten Finnesand <tmf@kvstech.no>"
+license="GPL-3.0-or-later"
+homepage="https://www.sdrpp.org/"
+distfiles="https://github.com/AlexandreRouma/SDRPlusPlus/archive/refs/tags/${version}.tar.gz"
+checksum="251256de6725ceb4f9fb2823c7ad825068ad16cf9b5fb894259b173aae5a69ea"

Re: [PR PATCH] [Closed]: New package: SDRPlusPlus-1.0.4

[TorMFinn]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

There's a closed pull request on the void-packages repository

New package: SDRPlusPlus-1.0.4
https://github.com/void-linux/void-packages/pull/36666

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Re: New package: SDRPlusPlus-1.0.4

[paper42]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36666#issuecomment-1114960122

Comment:
Why did you close this?