Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: gettext: fix cross compile
Date: Sun, 17 Apr 2022 19:34:18 +0200	[thread overview]
Message-ID: <20220417173418.KbxjCZHJbpUYxs3q0stZ5pVm8aIODVmByqhy2RMh5tg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34866@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

There's a closed pull request on the void-packages repository

gettext: fix cross compile
https://github.com/void-linux/void-packages/pull/34866

Description:
For gettext-0.21 cross-compile does not work, because the pre-configure step tries to run `autoreconf -fi`, which fails with the error

    configure.ac:25: error: AC_INIT should be called with package and version arguments
    : gl_AM_INIT_AUTOMAKE is expanded from...
    /usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
    configure.ac:25: the top level
    autom4te: /usr/bin/m4 failed with exit status: 1
    aclocal: error: /usr/bin/autom4te failed with exit status: 1
    autoreconf: aclocal failed with exit status: 1

This pre-configure step was added back in commit 17f6ad8b for gettext-0.18.3, but its not clear what the error seen back then was, and now cross-compiling without running autoreconf works fine.

So this PR just removes the pre-configure step, reverting 17f6ad8b. This fixes #34810.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures:
  - aarch64-musl
  - armv5tel-musl
  - i686-musl


      parent reply	other threads:[~2022-04-17 17:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 13:54 [PR PATCH] " lfdebrux
2022-01-05 15:14 ` [PR PATCH] [Updated] " lfdebrux
2022-01-05 20:41 ` Chocimier
2022-01-06  9:15 ` lfdebrux
2022-04-12  2:05 ` github-actions
2022-04-17 17:34 ` paper42 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220417173418.KbxjCZHJbpUYxs3q0stZ5pVm8aIODVmByqhy2RMh5tg@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).