Github messages for voidlinux
 help / color / mirror / Atom feed
From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] kitinerary: temporarily ignore test failures
Date: Mon, 18 Apr 2022 20:27:01 +0200	[thread overview]
Message-ID: <20220418182701.61eApEQ_V-_FrAOBnOvQZJABw1ivEoe4rv-0VIbOlhI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36746@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages kittest
https://github.com/void-linux/void-packages/pull/36746

kitinerary: temporarily ignore test failures
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so it's probably best to just ignore it for now, I checked it and the tests do succeed with `kitinerary-22.03.80` so once that reaches stable, it can be removed.

Closes: https://github.com/void-linux/void-packages/issues/36734

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36746.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kittest-36746.patch --]
[-- Type: text/x-diff, Size: 999 bytes --]

From 4d439d9cb1a79441a3425175d2b4d2b0a0e40f87 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 17 Apr 2022 15:55:01 -0700
Subject: [PATCH] kitinerary: temporarily ignore test failures

The tests were fixed upstream, so this should be
 able to be removed after the next update
---
 srcpkgs/kitinerary/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/kitinerary/template b/srcpkgs/kitinerary/template
index aa5ad07fe219..2d003c5974fc 100644
--- a/srcpkgs/kitinerary/template
+++ b/srcpkgs/kitinerary/template
@@ -13,6 +13,7 @@ homepage="https://kontact.kde.org"
 changelog="https://kde.org/announcements/changelogs/gear/${version}/#kitinerary"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
 checksum=b15f8aac50ac7eaf2fc23e40c7a165283e99844f88d96cb2a45face8a3cc8c4d
+make_check=no # can be removed after next release
 
 kitinerary-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"

  parent reply	other threads:[~2022-04-18 18:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17 22:59 [PR PATCH] " oreo639
2022-04-17 23:00 ` [PR PATCH] [Updated] " oreo639
2022-04-17 23:08 ` oreo639
2022-04-18 18:17 ` [PR REVIEW] " paper42
2022-04-18 18:26 ` oreo639
2022-04-18 18:27 ` oreo639 [this message]
2022-04-18 18:28 ` paper42
2022-04-18 18:31 ` oreo639
2022-04-18 18:43 ` [PR PATCH] [Updated] " oreo639
2022-04-18 18:46 ` oreo639
2022-04-18 18:49 ` oreo639
2022-04-18 19:51 ` [PR REVIEW] " oreo639
2022-04-18 20:49 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220418182701.61eApEQ_V-_FrAOBnOvQZJABw1ivEoe4rv-0VIbOlhI@z \
    --to=oreo639@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).