Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] kitinerary: temporarily ignore test failures
@ 2022-04-17 22:59 oreo639
  2022-04-17 23:00 ` [PR PATCH] [Updated] " oreo639
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: oreo639 @ 2022-04-17 22:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages kittest
https://github.com/void-linux/void-packages/pull/36746

kitinerary: temporarily ignore test failures
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so let's just ignore it for now, I tested it and the tests do succeed with `kitinerary-22.03.80` so once that is fully released, it can be removed.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36746.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kittest-36746.patch --]
[-- Type: text/x-diff, Size: 1027 bytes --]

From c2c151700defabb13e6d5c7c706eeb426a6be31e Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 17 Apr 2022 15:55:01 -0700
Subject: [PATCH] kitinerary: temporarily ignore test failures

The tests were fixed upstream, so this shoul be able to be removed after the next update
---
 srcpkgs/kitinerary/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/kitinerary/template b/srcpkgs/kitinerary/template
index aa5ad07fe219..934ba35bc012 100644
--- a/srcpkgs/kitinerary/template
+++ b/srcpkgs/kitinerary/template
@@ -14,6 +14,11 @@ changelog="https://kde.org/announcements/changelogs/gear/${version}/#kitinerary"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
 checksum=b15f8aac50ac7eaf2fc23e40c7a165283e99844f88d96cb2a45face8a3cc8c4d
 
+do_check() {
+	# can be removed after next update
+	make check || :
+}
+
 kitinerary-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
@ 2022-04-17 23:00 ` oreo639
  2022-04-17 23:08 ` oreo639
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-17 23:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages kittest
https://github.com/void-linux/void-packages/pull/36746

kitinerary: temporarily ignore test failures
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so let's just ignore it for now, I tested it and the tests do succeed with `kitinerary-22.03.80` so once that is fully released, it can be removed.

Closes: https://github.com/void-linux/void-packages/issues/36734

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36746.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kittest-36746.patch --]
[-- Type: text/x-diff, Size: 1029 bytes --]

From 221fb496729cc87b26ef9e389677b0a561614011 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 17 Apr 2022 15:55:01 -0700
Subject: [PATCH] kitinerary: temporarily ignore test failures

The tests were fixed upstream, so this should be
 able to be removed after the next update
---
 srcpkgs/kitinerary/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/kitinerary/template b/srcpkgs/kitinerary/template
index aa5ad07fe219..934ba35bc012 100644
--- a/srcpkgs/kitinerary/template
+++ b/srcpkgs/kitinerary/template
@@ -14,6 +14,11 @@ changelog="https://kde.org/announcements/changelogs/gear/${version}/#kitinerary"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
 checksum=b15f8aac50ac7eaf2fc23e40c7a165283e99844f88d96cb2a45face8a3cc8c4d
 
+do_check() {
+	# can be removed after next update
+	make check || :
+}
+
 kitinerary-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
  2022-04-17 23:00 ` [PR PATCH] [Updated] " oreo639
@ 2022-04-17 23:08 ` oreo639
  2022-04-18 18:17 ` [PR REVIEW] " paper42
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-17 23:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages kittest
https://github.com/void-linux/void-packages/pull/36746

kitinerary: temporarily ignore test failures
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so it's probably best to just ignore it for now, I checked it and the tests do succeed with `kitinerary-22.03.80` so once that reaches stable, it can be removed.

Closes: https://github.com/void-linux/void-packages/issues/36734

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36746.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kittest-36746.patch --]
[-- Type: text/x-diff, Size: 1030 bytes --]

From fd1b58eb7bef55ef7e41eac4abd40384e04bb7e1 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 17 Apr 2022 15:55:01 -0700
Subject: [PATCH] kitinerary: temporarily ignore test failures

The tests were fixed upstream, so this should be
 able to be removed after the next update
---
 srcpkgs/kitinerary/template | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/srcpkgs/kitinerary/template b/srcpkgs/kitinerary/template
index aa5ad07fe219..29aacb097465 100644
--- a/srcpkgs/kitinerary/template
+++ b/srcpkgs/kitinerary/template
@@ -14,6 +14,11 @@ changelog="https://kde.org/announcements/changelogs/gear/${version}/#kitinerary"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
 checksum=b15f8aac50ac7eaf2fc23e40c7a165283e99844f88d96cb2a45face8a3cc8c4d
 
+do_check() {
+	# can be removed after next release
+	make check || :
+}
+
 kitinerary-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
  2022-04-17 23:00 ` [PR PATCH] [Updated] " oreo639
  2022-04-17 23:08 ` oreo639
@ 2022-04-18 18:17 ` paper42
  2022-04-18 18:26 ` oreo639
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2022-04-18 18:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36746#discussion_r852309693

Comment:
Can we just use `make_check=no` with a comment?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (2 preceding siblings ...)
  2022-04-18 18:17 ` [PR REVIEW] " paper42
@ 2022-04-18 18:26 ` oreo639
  2022-04-18 18:27 ` [PR PATCH] [Updated] " oreo639
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-18 18:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/36746#discussion_r852315291

Comment:
Sure, just thought it was worth still allowing the other tests to run, since it is just one test that is failing.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (3 preceding siblings ...)
  2022-04-18 18:26 ` oreo639
@ 2022-04-18 18:27 ` oreo639
  2022-04-18 18:28 ` [PR REVIEW] " paper42
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-18 18:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages kittest
https://github.com/void-linux/void-packages/pull/36746

kitinerary: temporarily ignore test failures
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so it's probably best to just ignore it for now, I checked it and the tests do succeed with `kitinerary-22.03.80` so once that reaches stable, it can be removed.

Closes: https://github.com/void-linux/void-packages/issues/36734

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36746.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kittest-36746.patch --]
[-- Type: text/x-diff, Size: 999 bytes --]

From 4d439d9cb1a79441a3425175d2b4d2b0a0e40f87 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 17 Apr 2022 15:55:01 -0700
Subject: [PATCH] kitinerary: temporarily ignore test failures

The tests were fixed upstream, so this should be
 able to be removed after the next update
---
 srcpkgs/kitinerary/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/kitinerary/template b/srcpkgs/kitinerary/template
index aa5ad07fe219..2d003c5974fc 100644
--- a/srcpkgs/kitinerary/template
+++ b/srcpkgs/kitinerary/template
@@ -13,6 +13,7 @@ homepage="https://kontact.kde.org"
 changelog="https://kde.org/announcements/changelogs/gear/${version}/#kitinerary"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
 checksum=b15f8aac50ac7eaf2fc23e40c7a165283e99844f88d96cb2a45face8a3cc8c4d
+make_check=no # can be removed after next release
 
 kitinerary-devel_package() {
 	depends="${sourcepkg}>=${version}_${revision}"

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (4 preceding siblings ...)
  2022-04-18 18:27 ` [PR PATCH] [Updated] " oreo639
@ 2022-04-18 18:28 ` paper42
  2022-04-18 18:31 ` oreo639
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2022-04-18 18:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36746#discussion_r852316438

Comment:
Running them and ignoring the result is useless, but we could disable that one test.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (5 preceding siblings ...)
  2022-04-18 18:28 ` [PR REVIEW] " paper42
@ 2022-04-18 18:31 ` oreo639
  2022-04-18 18:43 ` [PR PATCH] [Updated] " oreo639
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-18 18:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/36746#discussion_r852318527

Comment:
Alright, I can look into that.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (6 preceding siblings ...)
  2022-04-18 18:31 ` oreo639
@ 2022-04-18 18:43 ` oreo639
  2022-04-18 18:46 ` oreo639
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-18 18:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages kittest
https://github.com/void-linux/void-packages/pull/36746

kitinerary: temporarily ignore test failures
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so it's probably best to just ignore it for now, I checked it and the tests do succeed with `kitinerary-22.03.80` so once that reaches stable, it can be removed.

Closes: https://github.com/void-linux/void-packages/issues/36734

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36746.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kittest-36746.patch --]
[-- Type: text/x-diff, Size: 1674 bytes --]

From ae09f5eb2d720e2c752f6accfb94b59045f17660 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 17 Apr 2022 15:55:01 -0700
Subject: [PATCH] kitinerary: temporarily ignore test failure

This test was fixed upstream, so this should be
 able to be removed after the next update
---
 .../patches/temporarily-disable-broken-test.patch | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch

diff --git a/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch b/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch
new file mode 100644
index 000000000000..8d966237e099
--- /dev/null
+++ b/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch
@@ -0,0 +1,15 @@
+This test has been fixed upstream, so this should be able to be
+ removed in the next release.
+
+diff -Naur a/autotests/CMakeLists.txt b/autotests/CMakeLists.txt
+--- a/autotests/CMakeLists.txt	2022-04-18 11:34:57.356111303 -0700
++++ b/autotests/CMakeLists.txt	2022-04-18 11:33:56.175938220 -0700
+@@ -35,7 +35,7 @@
+ ecm_add_test(postprocessortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+ ecm_add_test(extractorvalidatortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+ if (TARGET KF5::CalendarCore)
+-    ecm_add_test(calendarhandlertest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
++   #ecm_add_test(calendarhandlertest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+     ecm_add_test(extractortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary KPim::PkPass)
+ endif()
+ ecm_add_test(documentutiltest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (7 preceding siblings ...)
  2022-04-18 18:43 ` [PR PATCH] [Updated] " oreo639
@ 2022-04-18 18:46 ` oreo639
  2022-04-18 18:49 ` oreo639
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-18 18:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages kittest
https://github.com/void-linux/void-packages/pull/36746

kitinerary: temporarily ignore test failures
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so it's probably best to just ignore it for now, I checked it and the tests do succeed with `kitinerary-22.03.80` so once that reaches stable, it can be removed.

Closes: https://github.com/void-linux/void-packages/issues/36734

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36746.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kittest-36746.patch --]
[-- Type: text/x-diff, Size: 1674 bytes --]

From e67c9e739431c6bcb5fea4581303f8c7f93a2ea8 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 17 Apr 2022 15:55:01 -0700
Subject: [PATCH] kitinerary: temporarily ignore test failure

This test was fixed upstream, so this should be
 able to be removed after the next update
---
 .../patches/temporarily-disable-broken-test.patch | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch

diff --git a/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch b/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch
new file mode 100644
index 000000000000..8d966237e099
--- /dev/null
+++ b/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch
@@ -0,0 +1,15 @@
+This test has been fixed upstream, so this should be able to be
+ removed in the next release.
+
+diff -Naur a/autotests/CMakeLists.txt b/autotests/CMakeLists.txt
+--- a/autotests/CMakeLists.txt	2022-04-18 11:34:57.356111303 -0700
++++ b/autotests/CMakeLists.txt	2022-04-18 11:33:56.175938220 -0700
+@@ -35,7 +35,7 @@
+ ecm_add_test(postprocessortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+ ecm_add_test(extractorvalidatortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+ if (TARGET KF5::CalendarCore)
+-    ecm_add_test(calendarhandlertest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
++   #ecm_add_test(calendarhandlertest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+     ecm_add_test(extractortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary KPim::PkPass)
+ endif()
+ ecm_add_test(documentutiltest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (8 preceding siblings ...)
  2022-04-18 18:46 ` oreo639
@ 2022-04-18 18:49 ` oreo639
  2022-04-18 19:51 ` [PR REVIEW] " oreo639
  2022-04-18 20:49 ` [PR PATCH] [Merged]: " paper42
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-18 18:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages kittest
https://github.com/void-linux/void-packages/pull/36746

kitinerary: temporarily ignore test failures
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so it's probably best to just ignore it for now, I checked it and the tests do succeed with `kitinerary-22.03.80` so once that reaches stable, it can be removed.

Closes: https://github.com/void-linux/void-packages/issues/36734

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36746.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kittest-36746.patch --]
[-- Type: text/x-diff, Size: 1721 bytes --]

From 9b13098da885938ac175623d0a0099d6d63ae864 Mon Sep 17 00:00:00 2001
From: oreo639 <31916379+Oreo639@users.noreply.github.com>
Date: Sun, 17 Apr 2022 15:55:01 -0700
Subject: [PATCH] kitinerary: temporarily ignore test failure

This test was fixed upstream, so this should be
 able to be removed after the next update
---
 .../temporarily-disable-broken-test.patch        | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch

diff --git a/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch b/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch
new file mode 100644
index 000000000000..4e7bb1ce88bd
--- /dev/null
+++ b/srcpkgs/kitinerary/patches/temporarily-disable-broken-test.patch
@@ -0,0 +1,16 @@
+Temporarily disable the calendarhandler test.
+This test has been fixed upstream, so this should be able to be
+ removed in the next release.
+
+diff -Naur a/autotests/CMakeLists.txt b/autotests/CMakeLists.txt
+--- a/autotests/CMakeLists.txt	2022-04-18 11:34:57.356111303 -0700
++++ b/autotests/CMakeLists.txt	2022-04-18 11:33:56.175938220 -0700
+@@ -35,7 +35,7 @@
+ ecm_add_test(postprocessortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+ ecm_add_test(extractorvalidatortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+ if (TARGET KF5::CalendarCore)
+-    ecm_add_test(calendarhandlertest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
++   #ecm_add_test(calendarhandlertest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)
+     ecm_add_test(extractortest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary KPim::PkPass)
+ endif()
+ ecm_add_test(documentutiltest.cpp LINK_LIBRARIES Qt::Test KPim::Itinerary)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (9 preceding siblings ...)
  2022-04-18 18:49 ` oreo639
@ 2022-04-18 19:51 ` oreo639
  2022-04-18 20:49 ` [PR PATCH] [Merged]: " paper42
  11 siblings, 0 replies; 13+ messages in thread
From: oreo639 @ 2022-04-18 19:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/36746#discussion_r852318527

Comment:
~~Alright, I can look into that.~~ Done.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Merged]: kitinerary: temporarily ignore test failures
  2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
                   ` (10 preceding siblings ...)
  2022-04-18 19:51 ` [PR REVIEW] " oreo639
@ 2022-04-18 20:49 ` paper42
  11 siblings, 0 replies; 13+ messages in thread
From: paper42 @ 2022-04-18 20:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]

There's a merged pull request on the void-packages repository

kitinerary: temporarily ignore test failures
https://github.com/void-linux/void-packages/pull/36746

Description:
The tests were fixed upstream, so this shoul be able to be removed after the next update

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

These tests are already updated upstream, but it is over several commits and it is mixed with updates for supporting qt6, so it's probably best to just ignore it for now, I checked it and the tests do succeed with `kitinerary-22.03.80` so once that reaches stable, it can be removed.

Closes: https://github.com/void-linux/void-packages/issues/36734

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-04-18 20:49 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-17 22:59 [PR PATCH] kitinerary: temporarily ignore test failures oreo639
2022-04-17 23:00 ` [PR PATCH] [Updated] " oreo639
2022-04-17 23:08 ` oreo639
2022-04-18 18:17 ` [PR REVIEW] " paper42
2022-04-18 18:26 ` oreo639
2022-04-18 18:27 ` [PR PATCH] [Updated] " oreo639
2022-04-18 18:28 ` [PR REVIEW] " paper42
2022-04-18 18:31 ` oreo639
2022-04-18 18:43 ` [PR PATCH] [Updated] " oreo639
2022-04-18 18:46 ` oreo639
2022-04-18 18:49 ` oreo639
2022-04-18 19:51 ` [PR REVIEW] " oreo639
2022-04-18 20:49 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).