Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] shadow: increase maximum group name length to 32 (from 16).
@ 2022-02-13 10:40 JamiKettunen
  2022-02-13 19:04 ` Duncaen
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: JamiKettunen @ 2022-02-13 10:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

There is a new pull request by JamiKettunen against master on the void-packages repository

https://github.com/JamiKettunen/void-packages shadow-longer-group-names
https://github.com/void-linux/void-packages/pull/35579

shadow: increase maximum group name length to 32 (from 16).
This is already the case for usernames, so why not groups?

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35579.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shadow-longer-group-names-35579.patch --]
[-- Type: text/x-diff, Size: 1095 bytes --]

From 46be27d00c24ec327d5bdfc53107db1641061527 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Sun, 13 Feb 2022 12:36:33 +0200
Subject: [PATCH] shadow: increase maximum group name length to 32 (from 16).

This is already the case for usernames, so why not groups?
---
 srcpkgs/shadow/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/shadow/template b/srcpkgs/shadow/template
index f01181a49bd6..c59d92bfeb54 100644
--- a/srcpkgs/shadow/template
+++ b/srcpkgs/shadow/template
@@ -1,12 +1,13 @@
 # Template file for 'shadow'
 pkgname=shadow
 version=4.8.1
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--bindir=/usr/bin --sbindir=/usr/bin
  --enable-shared --disable-static
  --with-libpam --without-selinux --with-acl --with-attr --without-su
- --disable-nls --enable-subordinate-ids --disable-account-tools-setuid"
+ --disable-nls --enable-subordinate-ids --disable-account-tools-setuid
+ --with-group-name-max-length=32"
 hostmakedepends="libtool"
 makedepends="acl-devel pam-devel"
 depends="pam"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: shadow: increase maximum group name length to 32 (from 16).
  2022-02-13 10:40 [PR PATCH] shadow: increase maximum group name length to 32 (from 16) JamiKettunen
@ 2022-02-13 19:04 ` Duncaen
  2022-02-13 19:05 ` Duncaen
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Duncaen @ 2022-02-13 19:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/35579#issuecomment-1038352844

Comment:
Debian and arch do the same, so I would think it would be good to follow here.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: shadow: increase maximum group name length to 32 (from 16).
  2022-02-13 10:40 [PR PATCH] shadow: increase maximum group name length to 32 (from 16) JamiKettunen
  2022-02-13 19:04 ` Duncaen
@ 2022-02-13 19:05 ` Duncaen
  2022-02-18 16:05 ` JamiKettunen
  2022-04-20 19:01 ` [PR PATCH] [Merged]: " the-maldridge
  3 siblings, 0 replies; 5+ messages in thread
From: Duncaen @ 2022-02-13 19:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/35579#issuecomment-1038352844

Comment:
Debian, fedora and arch do the same, so I would think it would be good to follow here.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: shadow: increase maximum group name length to 32 (from 16).
  2022-02-13 10:40 [PR PATCH] shadow: increase maximum group name length to 32 (from 16) JamiKettunen
  2022-02-13 19:04 ` Duncaen
  2022-02-13 19:05 ` Duncaen
@ 2022-02-18 16:05 ` JamiKettunen
  2022-04-20 19:01 ` [PR PATCH] [Merged]: " the-maldridge
  3 siblings, 0 replies; 5+ messages in thread
From: JamiKettunen @ 2022-02-18 16:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by JamiKettunen on void-packages repository

https://github.com/void-linux/void-packages/pull/35579#issuecomment-1044760684

Comment:
I've submitted a PR which changes the default behavior upstream, I'll either close or re-open this later.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: shadow: increase maximum group name length to 32 (from 16).
  2022-02-13 10:40 [PR PATCH] shadow: increase maximum group name length to 32 (from 16) JamiKettunen
                   ` (2 preceding siblings ...)
  2022-02-18 16:05 ` JamiKettunen
@ 2022-04-20 19:01 ` the-maldridge
  3 siblings, 0 replies; 5+ messages in thread
From: the-maldridge @ 2022-04-20 19:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

There's a merged pull request on the void-packages repository

shadow: increase maximum group name length to 32 (from 16).
https://github.com/void-linux/void-packages/pull/35579

Description:
This is already the case for usernames, so why not groups?

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-04-20 19:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 10:40 [PR PATCH] shadow: increase maximum group name length to 32 (from 16) JamiKettunen
2022-02-13 19:04 ` Duncaen
2022-02-13 19:05 ` Duncaen
2022-02-18 16:05 ` JamiKettunen
2022-04-20 19:01 ` [PR PATCH] [Merged]: " the-maldridge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).