Re: [PR PATCH] [Updated] openjdk{9,10,12-16}-bootstrap: disable on armv5 and armv6

[classabbyamp <classabbyamp@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages fix/openjdk-bootstrap-arm
https://github.com/void-linux/void-packages/pull/36791

openjdk{9,10,12-16}-bootstrap: disable on armv5 and armv6
Openjdk will compile for armv5* and armv6*, but it is not supported at runtime, at least in the configuration we ship.

See [here](https://forums.raspberrypi.com/viewtopic.php?t=232680), [here](https://forums.raspberrypi.com/viewtopic.php?t=323376), and [here](https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255662) for evidence of the incompatibility.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

[skip ci]

A patch file from https://github.com/void-linux/void-packages/pull/36791.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/openjdk-bootstrap-arm-36791.patch --]
[-- Type: text/x-diff, Size: 6304 bytes --]

From a35aae2230bf906890e4fd4e31bed27e9bd0589b Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@placeviolette.net>
Date: Wed, 20 Apr 2022 21:05:38 -0400
Subject: [PATCH 1/7] openjdk9-bootstrap: disable on armv[56]

---
 srcpkgs/openjdk9-bootstrap/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/openjdk9-bootstrap/template b/srcpkgs/openjdk9-bootstrap/template
index 48cc14fb712c..c82f0761166a 100644
--- a/srcpkgs/openjdk9-bootstrap/template
+++ b/srcpkgs/openjdk9-bootstrap/template
@@ -50,10 +50,11 @@ checksum="914183a7eac6a1dfdfa70a98ceb4262244c77ab904c4570bb34c609ecb5f0986
  9cba7f03ebeda4d3cfaffb015f9bf967fcca2c3c113604836073556df6a7b9aa
  c939de46f903ecb283c02155e1415cee98ab66803e17eae0403c399c1a475647"
 
-# no hotspot JIT for arm32 and ppc32
 case "$XBPS_TARGET_MACHINE" in
 	ppc64*) ;;
-	arm*|ppc*) _use_zero=yes ;;
+	# no hotspot JIT for arm32 and ppc32
+	armv7*|ppc*) _use_zero=yes ;;
+	armv[56]*) broken="Unsupported architecture" ;;
 esac
 
 if [ -n "$_use_zero" ]; then

From ca8f2a7fcd0324b02a66442c497c8a0fd27a0032 Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@placeviolette.net>
Date: Wed, 20 Apr 2022 21:05:40 -0400
Subject: [PATCH 2/7] openjdk10-bootstrap: disable on armv[56]

---
 srcpkgs/openjdk10-bootstrap/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/openjdk10-bootstrap/template b/srcpkgs/openjdk10-bootstrap/template
index 3d99cd14af98..1c673dc748d1 100644
--- a/srcpkgs/openjdk10-bootstrap/template
+++ b/srcpkgs/openjdk10-bootstrap/template
@@ -35,10 +35,11 @@ distfiles="http://hg.openjdk.java.net/jdk-updates/jdk10u/archive/jdk-${_repo_ver
 checksum="374f7ae35f0a7439a40bd2c765d1f410607c75c6c1e788f1a344a42e59431f51"
 lib32disabled=yes
 
-# no hotspot JIT for arm32 and ppc32
 case "$XBPS_TARGET_MACHINE" in
 	ppc64*) ;;
-	arm*|ppc*) _use_zero=yes ;;
+	# no hotspot JIT for arm32 and ppc32
+	armv7*|ppc*) _use_zero=yes ;;
+	armv[56]*) broken="Unsupported architecture" ;;
 esac
 
 if [ -n "$_use_zero" ]; then

From cee74f7967826c10b192026d49714ed7e81e8593 Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@placeviolette.net>
Date: Wed, 20 Apr 2022 21:05:41 -0400
Subject: [PATCH 3/7] openjdk12-bootstrap: disable on armv[56]

---
 srcpkgs/openjdk12-bootstrap/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/openjdk12-bootstrap/template b/srcpkgs/openjdk12-bootstrap/template
index 2b5d421a52f0..1f20483ecbd4 100644
--- a/srcpkgs/openjdk12-bootstrap/template
+++ b/srcpkgs/openjdk12-bootstrap/template
@@ -47,10 +47,11 @@ nocross=yes
 # Build is still parallel, but don't use -jN.
 disable_parallel_build=yes
 
-# no hotspot JIT for ppc32
 case "$XBPS_TARGET_MACHINE" in
 	ppc64*) ;;
+	# no hotspot JIT for ppc32
 	ppc*) _use_zero=yes ;;
+	armv[56]*) broken="Unsupported architecture" ;;
 esac
 
 if [ -n "$_use_zero" ]; then

From 51b904beed16b6720ddd8c837144fbc6a63ab1a1 Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@placeviolette.net>
Date: Wed, 20 Apr 2022 21:05:41 -0400
Subject: [PATCH 4/7] openjdk13-bootstrap: disable on armv[56]

---
 srcpkgs/openjdk13-bootstrap/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/openjdk13-bootstrap/template b/srcpkgs/openjdk13-bootstrap/template
index 4a61e102381d..6a6b3340ffcd 100644
--- a/srcpkgs/openjdk13-bootstrap/template
+++ b/srcpkgs/openjdk13-bootstrap/template
@@ -47,10 +47,11 @@ nocross=yes
 # Build is still parallel, but don't use -jN.
 disable_parallel_build=yes
 
-# no hotspot JIT for ppc32
 case "$XBPS_TARGET_MACHINE" in
 	ppc64*) ;;
+	# no hotspot JIT for ppc32
 	ppc*) _use_zero=yes ;;
+	armv[56]*) broken="Unsupported architecture" ;;
 esac
 
 if [ -n "$_use_zero" ]; then

From 7119edde008460fc02351c81d468c6ab30ea31db Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@placeviolette.net>
Date: Wed, 20 Apr 2022 21:05:42 -0400
Subject: [PATCH 5/7] openjdk14-bootstrap: disable on armv[56]

---
 srcpkgs/openjdk14-bootstrap/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/openjdk14-bootstrap/template b/srcpkgs/openjdk14-bootstrap/template
index 768b94633196..341818dc5cf9 100644
--- a/srcpkgs/openjdk14-bootstrap/template
+++ b/srcpkgs/openjdk14-bootstrap/template
@@ -46,10 +46,11 @@ nocross=yes
 # Build is still parallel, but don't use -jN.
 disable_parallel_build=yes
 
-# no hotspot JIT for ppc32
 case "$XBPS_TARGET_MACHINE" in
 	ppc64*) ;;
+	# no hotspot JIT for ppc32
 	ppc*) _use_zero=yes ;;
+	armv[56]*) broken="Unsupported architecture" ;;
 esac
 
 if [ -n "$_use_zero" ]; then

From 9657f43d25cf5624fc43a340e8d3dc5c65ee3b67 Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@placeviolette.net>
Date: Wed, 20 Apr 2022 21:05:43 -0400
Subject: [PATCH 6/7] openjdk15-bootstrap: disable on armv[56]

---
 srcpkgs/openjdk15-bootstrap/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/openjdk15-bootstrap/template b/srcpkgs/openjdk15-bootstrap/template
index 7608f4dd2658..1430f205d1b9 100644
--- a/srcpkgs/openjdk15-bootstrap/template
+++ b/srcpkgs/openjdk15-bootstrap/template
@@ -49,10 +49,11 @@ nocross=yes
 # Build is still parallel, but don't use -jN.
 disable_parallel_build=yes
 
-# no hotspot JIT for ppc32
 case "$XBPS_TARGET_MACHINE" in
 	ppc64*) ;;
+	# no hotspot JIT for ppc32
 	ppc*) _use_zero=yes ;;
+	armv[56]*) broken="Unsupported architecture" ;;
 esac
 
 if [ -n "$_use_zero" ]; then

From dbc62361dc71f973bfb3f8e2d041a961a4db5364 Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@placeviolette.net>
Date: Wed, 20 Apr 2022 21:05:43 -0400
Subject: [PATCH 7/7] openjdk16-bootstrap: disable on armv[56]

---
 srcpkgs/openjdk16-bootstrap/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/openjdk16-bootstrap/template b/srcpkgs/openjdk16-bootstrap/template
index 28e70a17fd2b..2c8566bb1c31 100644
--- a/srcpkgs/openjdk16-bootstrap/template
+++ b/srcpkgs/openjdk16-bootstrap/template
@@ -49,10 +49,11 @@ nocross=yes
 # Build is still parallel, but don't use -jN.
 disable_parallel_build=yes
 
-# no hotspot JIT for ppc32
 case "$XBPS_TARGET_MACHINE" in
 	ppc64*) ;;
+	# no hotspot JIT for ppc32
 	ppc*) _use_zero=yes ;;
+	armv[56]*) broken="Unsupported architecture" ;;
 esac
 
 if [ -n "$_use_zero" ]; then