[PR PATCH] mdcat: update to 0.27.1.

[PR PATCH] mdcat: update to 0.27.1.

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

There is a new pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages mdcat
https://github.com/void-linux/void-packages/pull/36788

mdcat: update to 0.27.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36788.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mdcat-36788.patch --]
[-- Type: text/x-diff, Size: 1175 bytes --]

From 51903c6c2827d36d29e6b4dc3cda688f81ede3c2 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Wed, 20 Apr 2022 19:27:11 -0400
Subject: [PATCH] mdcat: update to 0.27.1.

---
 srcpkgs/mdcat/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/mdcat/template b/srcpkgs/mdcat/template
index c07dbd3b3913..93f6595c67a6 100644
--- a/srcpkgs/mdcat/template
+++ b/srcpkgs/mdcat/template
@@ -1,6 +1,6 @@
 # Template file for 'mdcat'
 pkgname=mdcat
-version=0.26.1
+version=0.27.1
 revision=1
 wrksrc="${pkgname}"
 build_style=cargo
@@ -11,8 +11,8 @@ maintainer="cinerea0 <cinerea0@protonmail.com>"
 license="MPL-2.0"
 homepage="https://codeberg.org/flausch/mdcat/"
 changelog="https://codeberg.org/flausch/mdcat/raw/branch/main/CHANGELOG.md"
-distfiles="https://codeberg.org/flausch/mdcat/archive/mdcat-${version}.tar.gz"
-checksum=1120c4f3b5b517075b6347dbfe76a2211a91837b4d0242c0b72cdbc19e6886dd
+distfiles="https://codeberg.org/flausch/mdcat/archive/${pkgname}-${version}.tar.gz"
+checksum=79961e0a842ee0f68aee3d54b39458352664c67388e56175a9d18d80f357bf14
 
 case "$XBPS_TARGET_MACHINE" in
 	x86_64*|i686*|arm*|aarch64*) ;;

Re: [PR REVIEW] mdcat: update to 0.27.1.

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36788#discussion_r854693082

Comment:
It's generally preferred that distfiles don't use `${pkgname}`. Is there a specific reason in this case?

Re: [PR REVIEW] mdcat: update to 0.27.1.

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/36788#discussion_r854693894

Comment:
I thought it would solve the "NO VERSION found for mdcat" error I get when running `xbps-src update-check`. It did not.

Re: [PR PATCH] [Updated] mdcat: update to 0.27.1.

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages mdcat
https://github.com/void-linux/void-packages/pull/36788

mdcat: update to 0.27.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36788.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mdcat-36788.patch --]
[-- Type: text/x-diff, Size: 1243 bytes --]

From 04612323bd10f58a008045c9824b8d97f30806fc Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Wed, 20 Apr 2022 21:19:00 -0400
Subject: [PATCH] mdcat: update to 0.27.1.

---
 srcpkgs/mdcat/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/mdcat/template b/srcpkgs/mdcat/template
index c07dbd3b3913..84a8294986a9 100644
--- a/srcpkgs/mdcat/template
+++ b/srcpkgs/mdcat/template
@@ -1,18 +1,20 @@
 # Template file for 'mdcat'
 pkgname=mdcat
-version=0.26.1
+version=0.27.1
 revision=1
 wrksrc="${pkgname}"
 build_style=cargo
 hostmakedepends="pkg-config ruby-asciidoctor"
 makedepends="openssl-devel"
+depends="shared-mime-info"
+checkdepends="shared-mime-info"
 short_desc="Cat for markdown"
 maintainer="cinerea0 <cinerea0@protonmail.com>"
 license="MPL-2.0"
 homepage="https://codeberg.org/flausch/mdcat/"
 changelog="https://codeberg.org/flausch/mdcat/raw/branch/main/CHANGELOG.md"
 distfiles="https://codeberg.org/flausch/mdcat/archive/mdcat-${version}.tar.gz"
-checksum=1120c4f3b5b517075b6347dbfe76a2211a91837b4d0242c0b72cdbc19e6886dd
+checksum=79961e0a842ee0f68aee3d54b39458352664c67388e56175a9d18d80f357bf14
 
 case "$XBPS_TARGET_MACHINE" in
 	x86_64*|i686*|arm*|aarch64*) ;;

Re: [PR REVIEW] mdcat: update to 0.27.1.

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New review comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36788#discussion_r854695787

Comment:
For that you'd need to write an `update` file. It'd what update-check uses when the upstream isn't one it know how to deal with like Github

Re: [PR REVIEW] mdcat: update to 0.27.1.

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New review comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36788#discussion_r854695787

Comment:
For that you'd need to write an `update` file. It's what update-check uses when the upstream isn't one it know how to deal with like Github

Re: [PR REVIEW] mdcat: update to 0.27.1.

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/36788#discussion_r854697803

Comment:
Other packages like `foot` also download their sources from Codeberg, have a similar source URL, and have no issue checking for updates without an `update` file.

Re: [PR REVIEW] mdcat: update to 0.27.1.

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New review comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36788#discussion_r854700858

Comment:
Hum, there seems to be a definition for codeberg https://github.com/void-linux/void-packages/blob/master/common/xbps-src/shutils/update_check.sh#L146

You might need to specify a variable manually to get it to work 

Re: [PR REVIEW] mdcat: update to 0.27.1.

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New review comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36788#discussion_r854705408

Comment:
Looking at it a bit more, the codeberg support works on releases, but mdcat only has tags
I *think* setting the url to the tag page instead of the release page should work 

Re: [PR REVIEW] mdcat: update to 0.27.1.

[0x5c]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/36788#discussion_r854709207

Comment:
Nevermind, they do appear to use releases but have not published one for the latest tag

Re: [PR PATCH] [Merged]: mdcat: update to 0.27.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

There's a merged pull request on the void-packages repository

mdcat: update to 0.27.1.
https://github.com/void-linux/void-packages/pull/36788

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->