[PR PATCH] Manual.md: require package names to be lowercase

[PR PATCH] Manual.md: require package names to be lowercase

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

There is a new pull request by Piraty against master on the void-packages repository

https://github.com/Piraty/void-packages manual-lowercase-naming
https://github.com/void-linux/void-packages/pull/25633

Manual.md: require package names to be lowercase
@void-linux/pkg-committers 

A patch file from https://github.com/void-linux/void-packages/pull/25633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-lowercase-naming-25633.patch --]
[-- Type: text/x-diff, Size: 1227 bytes --]

From f20e7996b83466ad21ad49fbf3d61316eb658349 Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Thu, 15 Oct 2020 12:25:46 +0200
Subject: [PATCH] Manual.md: require package names to be lowercase

---
 Manual.md | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/Manual.md b/Manual.md
index 4af3a7b78d9..784cfdfb734 100644
--- a/Manual.md
+++ b/Manual.md
@@ -243,13 +243,10 @@ Example: gimp-python, irssi-perl
 #### Programs
 
 Programs put executables under /usr/bin (or in very special cases in other
-.../bin directories)
+.../bin directories).
 
-For those packages the upstream packages name should be used. Remember that
-in contrast to many other distributions, void doesn't lowercase package names.
-As a rule of thumb, if the tar.gz of a package contains uppercase letter, then
-the package name should contain them too; if it doesn't, the package name
-is lowercase.
+For those packages either the upstream package's name or (in rare cases) the
+main binary's name should be used. Void only accepts lowercase package names.
 
 Programs can be split into program packages and library packages. The program
 package should be named as described above. The library package should be

Re: Manual.md: require package names to be lowercase

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709469572

Comment:
I am strongly opposed to this.  This is an arbitrary change with no defined benefit and no justification.  There are no known issues with the current system, and as a general rule I will not support a change for the sake of change.

Re: Manual.md: require package names to be lowercase

[q66]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709489428

Comment:
I disagree; if anything is arbitrary, it's the current convention, and it just makes package searches confusing and introduces a relatively small minority of packages that have mixed case names while vast majority have lowercase names

not to mention that the current convention isn't even always respected, so it's not "for the sake of change", it's for the sake of consistency

the change is also easily implementable, so i see no reason not to go with it

Re: Manual.md: require package names to be lowercase

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709492767

Comment:
Is there any plan to lowercase existing packages, or we will be stuck with old packages mostly upstream-case, new lower-case?

Re: Manual.md: require package names to be lowercase

[q66]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709496890

Comment:
there is a plan; we will rename the existing packages (in batches: one batch would be all packages that start with an uppercase letter, that's 200something packages and should be relatively small scale, probably less than e.g. a single chromium build :P, the rest is mostly perl packages which would be done with the next perl related rebuild, and then the remainder would be handled individually)

renaming would be done via `provides=` + `replaces=` combo for the old name + removal of the old package from the repos (this would be easy to do, since doing it in a batch means we could just clean the affected packages at once), which means no existing scripts or commands would be broken (there would be a single virtual provider of the old name, which means `xbps` can just pick it up) - the docs would then gradually be updated

Re: Manual.md: require package names to be lowercase

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709497252

Comment:
Lowercasing existing packages would involve a myriad of renames.  Given that XBPS already doesn't handle renames super well, I'm not inclined to do anything large that will risk repo state.  Similarly, I am still against this change on principle as the complaint of searches being harder could be fixed by something far simpler, like making the package search case insensitive.

Re: Manual.md: require package names to be lowercase

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709498048

Comment:
Package search is already case insensitive, but xbps-install is not and there is no reason to make it case insensitive.

The main issue is inconsistency and no good reason to have mixed case package names.

Re: Manual.md: require package names to be lowercase

[q66]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709498303

Comment:
there is less than 300 packages that start with uppercase, and around 1000 total packages that have mixed case, most of them simple (formerly noarch) perl/python packages, this is really rather trivial

it's been discussed in `#xbps` yesterday, and we've come to the conclusion that this is feasible and unlikely to break

@Duncaen was also strongly opposed to making things case insensitive, and so am I, it's just a massive can of worms that's both more complex and uglier than the lowercasing approach

Re: Manual.md: require package names to be lowercase

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709498706

Comment:
Replaces simply won't work for this use case.

Re: Manual.md: require package names to be lowercase

[q66]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709498951

Comment:
it will, when paired with `provides=` (@Duncaen has already confirmed this)

Re: Manual.md: require package names to be lowercase

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709510061

Comment:
Please don't "rename" packages, but make XBPS normalize the name? Then fix all the templates.

Re: Manual.md: require package names to be lowercase

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709516065

Comment:
@66: Package with provides + replaces doesn't install itself in place of manually installed package.

Re: Manual.md: require package names to be lowercase

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709516065

Comment:
@q66: Package with provides + replaces doesn't install itself in place of manually installed package.

Re: Manual.md: require package names to be lowercase

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709517383

Comment:
> @q66: Package with provides + replaces doesn't install itself in place of manually installed package.

Yes looks like it needs a two line patch to work correctly.

> Please don't "rename" packages, but make XBPS normalize the name? Then fix all the templates.

With "provides=" being the old name, its effectively normalized by going through the virtual package if necessary.

Re: Manual.md: require package names to be lowercase

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709523883

Comment:
> needs a two line patch to work correctly.

Provides is now used as both "use this instead" and as "this is alternative provider of other non-virtual package", and proposed change will make second usage work incorrectly.

Re: Manual.md: require package names to be lowercase

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709531356

Comment:
> Provides is now used as both "use this instead" and as "this is alternative provider of other non-virtual package", and proposed change will make second usage work incorrectly.

I don't really see how anything changed, the proposed change is making updates try virtual packages if a normal package wasn't found, like it already does for dependencies and direct installations.

Re: Manual.md: require package names to be lowercase

[hippi777]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

New comment by hippi777 on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709660487

Comment:
hi folks :) 

i think it can be a strong reason to bring the package names any nearer to other distros (ok, i saw other interesting stuffs elsewhere, and i dont know enough, but it was strange when i saw the mixed case here...), and i think if this doesnt introduce any collision, then it must be doable (!=done). my 1st (naive/uneducated ?) guess would be to look up both the current name and the name with lowercase if the former cant be found, but this makes a transition period, that i dont know how long it should be...

i can understand the thinking that says if it works then it doesnt need to be fixed, but i have no idea why it was introduced on the 1st place, so, out of curiosity, why? :D 

the greatest difference between all the distros out there is in their package managers and packages, bringing them any nearer to each other is a nice dream of mine, but void is the 1st distro i approached this closely, so i dunno how huge this dragon might be :D otherwise i saw the repology rules, so i have some idea :D also, a script that would install dependencies for various tasks to be done may need a nontrivial translator for package names between various distros, and while the basics will be mostly identical, i can think about nasty cases as well, so this is my other reason to vote on this change...

Re: Manual.md: require package names to be lowercase

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709747283

Comment:
```
diff --git a/Manual.md b/Manual.md
index 4af3a7b78d..9675e5a00f 100644
--- a/Manual.md
+++ b/Manual.md
@@ -255,6 +255,9 @@ Programs can be split into program packages and library packages. The program
 package should be named as described above. The library package should be
 prefixed with "lib" (see section `Libraries`)

+If miscellanious executables are put into a subpackage, name the subpackage
+`${sourcepkg}-tools`. Void does not accept packages with the `-utils` suffix.
+
 <a id="global_funcs"></a>
 ### Global functions

```

Re: Manual.md: require package names to be lowercase

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709747283

Comment:
```diff
diff --git a/Manual.md b/Manual.md
index 4af3a7b78d..9675e5a00f 100644
--- a/Manual.md
+++ b/Manual.md
@@ -255,6 +255,9 @@ Programs can be split into program packages and library packages. The program
 package should be named as described above. The library package should be
 prefixed with "lib" (see section `Libraries`)

+If miscellanious executables are put into a subpackage, name the subpackage
+`${sourcepkg}-tools`. Void does not accept packages with the `-utils` suffix.
+
 <a id="global_funcs"></a>
 ### Global functions

```

Re: Manual.md: require package names to be lowercase

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709747283

Comment:
I see it as a trade-off between respecting upstream identification (external consistency) and normalizing what is coming in from the world (internal consistency).


```diff
diff --git a/Manual.md b/Manual.md
index 4af3a7b78d..9675e5a00f 100644
--- a/Manual.md
+++ b/Manual.md
@@ -255,6 +255,9 @@ Programs can be split into program packages and library packages. The program
 package should be named as described above. The library package should be
 prefixed with "lib" (see section `Libraries`)

+If miscellanious executables are put into a subpackage, name the subpackage
+`${sourcepkg}-tools`. Void does not accept packages with the `-utils` suffix.
+
 <a id="global_funcs"></a>
 ### Global functions

```

Re: Manual.md: require package names to be lowercase

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709747283

Comment:
I see it as a trade-off between closely mirroring upstream identification (external consistency) and normalizing what is coming in from the world (internal consistency).


```diff
diff --git a/Manual.md b/Manual.md
index 4af3a7b78d..9675e5a00f 100644
--- a/Manual.md
+++ b/Manual.md
@@ -255,6 +255,9 @@ Programs can be split into program packages and library packages. The program
 package should be named as described above. The library package should be
 prefixed with "lib" (see section `Libraries`)

+If miscellanious executables are put into a subpackage, name the subpackage
+`${sourcepkg}-tools`. Void does not accept packages with the `-utils` suffix.
+
 <a id="global_funcs"></a>
 ### Global functions

```

Re: Manual.md: require package names to be lowercase

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709747283

Comment:
I see it as a trade-off between closely mirroring upstream identification (external consistency) and normalizing what is coming in from the world (internal consistency).


```diff
diff --git a/Manual.md b/Manual.md
index 4af3a7b78d..9675e5a00f 100644
--- a/Manual.md
+++ b/Manual.md
@@ -255,6 +255,9 @@ Programs can be split into program packages and library packages. The program
 package should be named as described above. The library package should be
 prefixed with "lib" (see section `Libraries`)

+If miscellanious executables are put into a subpackage, name the subpackage
+`${sourcepkg}-tools`. Void does not accept packages with the `-utils` suffix.
+
 <a id="global_funcs"></a>
 ### Global functions

```

Which do you value more?

Re: Manual.md: require package names to be lowercase

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709747283

Comment:
I see it as a trade-off between closely mirroring upstream identification (external consistency) and normalizing what is coming in from the world (internal consistency).


```diff
diff --git a/Manual.md b/Manual.md
index 4af3a7b78d..9675e5a00f 100644
--- a/Manual.md
+++ b/Manual.md
@@ -255,6 +255,9 @@ Programs can be split into program packages and library packages. The program
 package should be named as described above. The library package should be
 prefixed with "lib" (see section `Libraries`)

+If miscellanious executables are put into a subpackage, name the subpackage
+`${sourcepkg}-tools`. Void does not accept packages with the `-utils` suffix.
+
 <a id="global_funcs"></a>
 ### Global functions

```

Which do you value more? Does it depend on context?

Re: Manual.md: require package names to be lowercase

[Gottox]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-709946333

Comment:
I prefer allowing uppercase names. For me it makes templating easier, as I don't have to set up variables for package and upstream filenames for those packages.

Personally, I even would go into another direction and support the full utf8 set. This would allow to find bugs in the string handling of xbps.

Anyway, as I wasn't recently active in void, I won't take a vote in this discussion.

Re: Manual.md: require package names to be lowercase

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-714549588

Comment:
Closing, as most seem opposed.

Re: [PR PATCH] [Closed]: Manual.md: require package names to be lowercase

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

There's a closed pull request on the void-packages repository

Manual.md: require package names to be lowercase
https://github.com/void-linux/void-packages/pull/25633

Description:
@void-linux/pkg-committers 

Re: Manual.md: require package names to be lowercase

[q66]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-714569915

Comment:
not true, i don't see most being opposed

but xbps will need work first

Re: Manual.md: require package names to be lowercase

[q66]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-714569915

Comment:
not true, i don't see most being opposed (let's see: for were at very least me, you, @Duncaen, @ericonr, against were - I only see @the-maldridge and @Chocimier, with the former mostly seeming opposed on technical basis, which was later cleared up on IRC - and @Gottox, who didn't take a vote; others didn't say anything; so that's 4 for, 2 against)

but xbps will need work first

Re: Manual.md: require package names to be lowercase

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-714657820

Comment:
Reopening. Closing issue won't stop this, but arguments can.

Re: Manual.md: require package names to be lowercase

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-744626944

Comment:
I'm not  entirely sure, but lowercase package names can be more predictable and might help with accessibility as well...

Re: Manual.md: require package names to be lowercase

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-863176040

Comment:
I personally don't really care how the packages are stored repo side, 

I do however get very annoyed by trying to install a package, xbps telling me it doesn't exist and then searching it only to find out it uses random capitals, it's inconsistent and annoying.

I have proposed this in IRC and I think it would align with @Gottox wishes partly as well. (since it would mean overhauling strings a bit)

I would rather have the package matching to be case-insensitive, I assume there's at least consensus that we shouldn't have e.g. `MyPackage`  and `mypackage` at the same time.

allowing package matching to be case-insensitive allows usage pattern to be the same as if all was lowercase, and might ease migration if we plan to go full lowercase anyhow

Re: Manual.md: require package names to be lowercase

[the-eater]

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

New comment by the-eater on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-863176040

Comment:
I personally don't really care how the packages are stored repo side, 

I do however get very annoyed by trying to install a package, xbps telling me it doesn't exist and then searching it only to find out it uses random capitals, it's inconsistent and annoying.

I have proposed this in IRC and I think it would align with @Gottox wishes partly as well. (since it would mean overhauling strings a bit)

I would rather have the package matching to be case-insensitive, I assume there's at least consensus that we shouldn't have e.g. `MyPackage`  and `mypackage` at the same time.

allowing package matching to be case-insensitive allows usage pattern to be the same as if all was lowercase, and might ease migration if we plan to go full lowercase anyhow

Update:

took a look at conflicting mixed case packages

```
[eater@momo srcpkgs]$ ls -1 | tr '[:upper:]' '[:lower:]' | sort | uniq -c | grep -v '^ \+1 '
      2 bcnc
      2 gifsicle
      2 libice
      2 wildmidi
```

only `libIce` and `libICE` are different packages,

WildMidi points to wildmidi,
bcnc points to bCNC (hue hue consistency)
gifsicle and Gifsicle are 2 different packages maintaining the same software
libIce is the library of `Ice` while `libICE` is xorg libICE

Re: Manual.md: require package names to be lowercase

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/25633#issuecomment-1104635067

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: Manual.md: require package names to be lowercase

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

There's a closed pull request on the void-packages repository

Manual.md: require package names to be lowercase
https://github.com/void-linux/void-packages/pull/25633

Description:
@void-linux/pkg-committers