Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] thefuck: update to 3.32.
@ 2022-04-15 18:45 glaulher
  2022-04-18 21:00 ` [PR REVIEW] " paper42
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: glaulher @ 2022-04-15 18:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

There is a new pull request by glaulher against master on the void-packages repository

https://github.com/glaulher/void-packages thefuck
https://github.com/void-linux/void-packages/pull/36710

thefuck: update to 3.32.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):  
  - armv7l
 

A patch file from https://github.com/void-linux/void-packages/pull/36710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thefuck-36710.patch --]
[-- Type: text/x-diff, Size: 1261 bytes --]

From 1ce953818d634e011f839facf8f92c34779e5c5d Mon Sep 17 00:00:00 2001
From: glaulher <glaulher.developer@gmail.com>
Date: Fri, 15 Apr 2022 15:09:43 -0300
Subject: [PATCH] thefuck: update to 3.32.

---
 srcpkgs/thefuck/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/thefuck/template b/srcpkgs/thefuck/template
index 267a27d7789a..366c51f663ea 100644
--- a/srcpkgs/thefuck/template
+++ b/srcpkgs/thefuck/template
@@ -1,7 +1,7 @@
 # Template file for 'thefuck'
 pkgname=thefuck
-version=3.31
-revision=2
+version=3.32
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-colorama python3-decorator python3-psutil python3-pyte
@@ -12,12 +12,11 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://github.com/nvbn/thefuck"
 distfiles="https://github.com/nvbn/thefuck/archive/${version}.tar.gz"
-checksum=ac12705b95e22b356f23b20181a34d549267b7b1702523a1f0a22ba7ba3d30df
+checksum=76cbb014473672d1c384922857f8fbc1f6f7774f74f784149ad88751854ecfdf
 
 case "$XBPS_TARGET_MACHINE" in
 	# archs where go is available - the test suite uses it
 	x86_64*|i686*|armv[67]*|aarch64*|ppc64le*) checkdepends+=" go" ;;
-	*) make_check=no ;;
 esac
 
 pre_check() {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] thefuck: update to 3.32.
  2022-04-15 18:45 [PR PATCH] thefuck: update to 3.32 glaulher
@ 2022-04-18 21:00 ` paper42
  2022-04-19  0:55 ` glaulher
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-04-18 21:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36710#discussion_r852412201

Comment:
Could you explain why you removed this line?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] thefuck: update to 3.32.
  2022-04-15 18:45 [PR PATCH] thefuck: update to 3.32 glaulher
  2022-04-18 21:00 ` [PR REVIEW] " paper42
@ 2022-04-19  0:55 ` glaulher
  2022-04-19 18:42 ` paper42
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: glaulher @ 2022-04-19  0:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/36710#discussion_r852510898

Comment:
It was giving error in lint and there was no error in the tests on my computer. 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] thefuck: update to 3.32.
  2022-04-15 18:45 [PR PATCH] thefuck: update to 3.32 glaulher
  2022-04-18 21:00 ` [PR REVIEW] " paper42
  2022-04-19  0:55 ` glaulher
@ 2022-04-19 18:42 ` paper42
  2022-04-21 12:25 ` [PR PATCH] [Updated] " glaulher
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-04-19 18:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36710#discussion_r853381184

Comment:
> It was giving error in lint 

```
srcpkgs/thefuck/template:20: explain why the tests fail
```
then you should explain why the tests fail on this line (or right before it).

This is a case statement and your PC probably matches the first case, so make_check=no isn't set for you. Restore this line and add something like `... ;; # go is not available`

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] thefuck: update to 3.32.
  2022-04-15 18:45 [PR PATCH] thefuck: update to 3.32 glaulher
                   ` (2 preceding siblings ...)
  2022-04-19 18:42 ` paper42
@ 2022-04-21 12:25 ` glaulher
  2022-04-21 12:36 ` glaulher
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: glaulher @ 2022-04-21 12:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

There is an updated pull request by glaulher against master on the void-packages repository

https://github.com/glaulher/void-packages thefuck
https://github.com/void-linux/void-packages/pull/36710

thefuck: update to 3.32.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):  
  - armv7l
 

A patch file from https://github.com/void-linux/void-packages/pull/36710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thefuck-36710.patch --]
[-- Type: text/x-diff, Size: 2020 bytes --]

From 1ce953818d634e011f839facf8f92c34779e5c5d Mon Sep 17 00:00:00 2001
From: glaulher <glaulher.developer@gmail.com>
Date: Fri, 15 Apr 2022 15:09:43 -0300
Subject: [PATCH 1/2] thefuck: update to 3.32.

---
 srcpkgs/thefuck/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/thefuck/template b/srcpkgs/thefuck/template
index 267a27d7789a..366c51f663ea 100644
--- a/srcpkgs/thefuck/template
+++ b/srcpkgs/thefuck/template
@@ -1,7 +1,7 @@
 # Template file for 'thefuck'
 pkgname=thefuck
-version=3.31
-revision=2
+version=3.32
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-colorama python3-decorator python3-psutil python3-pyte
@@ -12,12 +12,11 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://github.com/nvbn/thefuck"
 distfiles="https://github.com/nvbn/thefuck/archive/${version}.tar.gz"
-checksum=ac12705b95e22b356f23b20181a34d549267b7b1702523a1f0a22ba7ba3d30df
+checksum=76cbb014473672d1c384922857f8fbc1f6f7774f74f784149ad88751854ecfdf
 
 case "$XBPS_TARGET_MACHINE" in
 	# archs where go is available - the test suite uses it
 	x86_64*|i686*|armv[67]*|aarch64*|ppc64le*) checkdepends+=" go" ;;
-	*) make_check=no ;;
 esac
 
 pre_check() {

From 35a09bae3101277bb1ffa1802b5f8fe84b212841 Mon Sep 17 00:00:00 2001
From: glaulher <glaulher.developer@gmail.com>
Date: Thu, 21 Apr 2022 12:24:36 -0300
Subject: [PATCH 2/2] thefuck: update to 3.32.

---
 srcpkgs/thefuck/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/thefuck/template b/srcpkgs/thefuck/template
index 366c51f663ea..7704ab2a6a68 100644
--- a/srcpkgs/thefuck/template
+++ b/srcpkgs/thefuck/template
@@ -17,6 +17,7 @@ checksum=76cbb014473672d1c384922857f8fbc1f6f7774f74f784149ad88751854ecfdf
 case "$XBPS_TARGET_MACHINE" in
 	# archs where go is available - the test suite uses it
 	x86_64*|i686*|armv[67]*|aarch64*|ppc64le*) checkdepends+=" go" ;;
+	*) make_check=no ;; # go is not available
 esac
 
 pre_check() {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] thefuck: update to 3.32.
  2022-04-15 18:45 [PR PATCH] thefuck: update to 3.32 glaulher
                   ` (3 preceding siblings ...)
  2022-04-21 12:25 ` [PR PATCH] [Updated] " glaulher
@ 2022-04-21 12:36 ` glaulher
  2022-04-21 12:39 ` [PR REVIEW] " glaulher
  2022-04-25  8:52 ` [PR PATCH] [Merged]: " paper42
  6 siblings, 0 replies; 8+ messages in thread
From: glaulher @ 2022-04-21 12:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

There is an updated pull request by glaulher against master on the void-packages repository

https://github.com/glaulher/void-packages thefuck
https://github.com/void-linux/void-packages/pull/36710

thefuck: update to 3.32.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):  
  - armv7l
 

A patch file from https://github.com/void-linux/void-packages/pull/36710.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-thefuck-36710.patch --]
[-- Type: text/x-diff, Size: 1306 bytes --]

From eea6ad87b35aab7d916ab99c0e49bac092fe5523 Mon Sep 17 00:00:00 2001
From: glaulher <glaulher.developer@gmail.com>
Date: Thu, 21 Apr 2022 12:34:46 -0300
Subject: [PATCH] thefuck: update to 3.32.

---
 srcpkgs/thefuck/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/thefuck/template b/srcpkgs/thefuck/template
index 267a27d7789a..7704ab2a6a68 100644
--- a/srcpkgs/thefuck/template
+++ b/srcpkgs/thefuck/template
@@ -1,7 +1,7 @@
 # Template file for 'thefuck'
 pkgname=thefuck
-version=3.31
-revision=2
+version=3.32
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-colorama python3-decorator python3-psutil python3-pyte
@@ -12,12 +12,12 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://github.com/nvbn/thefuck"
 distfiles="https://github.com/nvbn/thefuck/archive/${version}.tar.gz"
-checksum=ac12705b95e22b356f23b20181a34d549267b7b1702523a1f0a22ba7ba3d30df
+checksum=76cbb014473672d1c384922857f8fbc1f6f7774f74f784149ad88751854ecfdf
 
 case "$XBPS_TARGET_MACHINE" in
 	# archs where go is available - the test suite uses it
 	x86_64*|i686*|armv[67]*|aarch64*|ppc64le*) checkdepends+=" go" ;;
-	*) make_check=no ;;
+	*) make_check=no ;; # go is not available
 esac
 
 pre_check() {

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] thefuck: update to 3.32.
  2022-04-15 18:45 [PR PATCH] thefuck: update to 3.32 glaulher
                   ` (4 preceding siblings ...)
  2022-04-21 12:36 ` glaulher
@ 2022-04-21 12:39 ` glaulher
  2022-04-25  8:52 ` [PR PATCH] [Merged]: " paper42
  6 siblings, 0 replies; 8+ messages in thread
From: glaulher @ 2022-04-21 12:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/36710#discussion_r855140072

Comment:
really, thanks 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Merged]: thefuck: update to 3.32.
  2022-04-15 18:45 [PR PATCH] thefuck: update to 3.32 glaulher
                   ` (5 preceding siblings ...)
  2022-04-21 12:39 ` [PR REVIEW] " glaulher
@ 2022-04-25  8:52 ` paper42
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-04-25  8:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

There's a merged pull request on the void-packages repository

thefuck: update to 3.32.
https://github.com/void-linux/void-packages/pull/36710

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):  
  - armv7l
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-04-25  8:52 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-15 18:45 [PR PATCH] thefuck: update to 3.32 glaulher
2022-04-18 21:00 ` [PR REVIEW] " paper42
2022-04-19  0:55 ` glaulher
2022-04-19 18:42 ` paper42
2022-04-21 12:25 ` [PR PATCH] [Updated] " glaulher
2022-04-21 12:36 ` glaulher
2022-04-21 12:39 ` [PR REVIEW] " glaulher
2022-04-25  8:52 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).