[PR PATCH] neovim: update to 0.7.0

[PR PATCH] neovim: update to 0.7.0

[siduck]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

There is a new pull request by siduck against master on the void-packages repository

https://github.com/siduck/void-packages patch-1
https://github.com/void-linux/void-packages/pull/36804

neovim: update to 0.7.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36804.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-36804.patch --]
[-- Type: text/x-diff, Size: 586 bytes --]

From 5a130d432dadaa3032a0975b5d2e8afc886ee0d9 Mon Sep 17 00:00:00 2001
From: Sidhanth Rathod <siduck@tutanota.com>
Date: Thu, 21 Apr 2022 21:14:08 +0530
Subject: [PATCH] neovim: update to 0.7.0

---
 srcpkgs/neovim/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/neovim/template b/srcpkgs/neovim/template
index 28cbc7e363cb..fe3f77ac717c 100644
--- a/srcpkgs/neovim/template
+++ b/srcpkgs/neovim/template
@@ -1,6 +1,6 @@
 # Template file for 'neovim'
 pkgname=neovim
-version=0.6.1
+version=0.7.0
 revision=1
 build_style=cmake
 build_helper="qemu"

Re: neovim: update to 0.7.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/36804#issuecomment-1105402188

Comment:
You need to build, install and run to check if update is fine before sending a PR.

Re: [PR PATCH] [Updated] neovim: update to 0.7.0

[siduck]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

There is an updated pull request by siduck against master on the void-packages repository

https://github.com/siduck/void-packages patch-1
https://github.com/void-linux/void-packages/pull/36804

neovim: update to 0.7.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** 

 

A patch file from https://github.com/void-linux/void-packages/pull/36804.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-36804.patch --]
[-- Type: text/x-diff, Size: 1426 bytes --]

From 5a130d432dadaa3032a0975b5d2e8afc886ee0d9 Mon Sep 17 00:00:00 2001
From: Sidhanth Rathod <siduck@tutanota.com>
Date: Thu, 21 Apr 2022 21:14:08 +0530
Subject: [PATCH 1/2] neovim: update to 0.7.0

---
 srcpkgs/neovim/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/neovim/template b/srcpkgs/neovim/template
index 28cbc7e363cb..fe3f77ac717c 100644
--- a/srcpkgs/neovim/template
+++ b/srcpkgs/neovim/template
@@ -1,6 +1,6 @@
 # Template file for 'neovim'
 pkgname=neovim
-version=0.6.1
+version=0.7.0
 revision=1
 build_style=cmake
 build_helper="qemu"

From 9e9c9c10a8bffc882aa327cf2f8c4524f9d0405b Mon Sep 17 00:00:00 2001
From: Sidhanth Rathod <siduck@tutanota.com>
Date: Thu, 21 Apr 2022 21:24:59 +0530
Subject: [PATCH 2/2] Update checksum

---
 srcpkgs/neovim/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/neovim/template b/srcpkgs/neovim/template
index fe3f77ac717c..bb6177911bb0 100644
--- a/srcpkgs/neovim/template
+++ b/srcpkgs/neovim/template
@@ -14,7 +14,7 @@ maintainer="Steve Prybylski <sa.prybylx@gmail.com>"
 license="Apache-2.0, custom:Vim"
 homepage="https://neovim.io"
 distfiles="https://github.com/neovim/neovim/archive/v${version}.tar.gz"
-checksum=dd882c21a52e5999f656cae3f336b5fc702d52addd4d9b5cd3dc39cfff35e864
+checksum=792a9c55d5d5f4a5148d475847267df309d65fb20f05523f21c1319ea8a6c7df
 
 alternatives="
  vi:vi:/usr/bin/nvim

Re: [PR PATCH] [Closed]: neovim: update to 0.7.0

[siduck]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

There's a closed pull request on the void-packages repository

neovim: update to 0.7.0
https://github.com/void-linux/void-packages/pull/36804

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES** 

 

Re: neovim: update to 0.7.0

[siduck]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

New comment by siduck on void-packages repository

https://github.com/void-linux/void-packages/pull/36804#issuecomment-1105410118

Comment:
> You need to build, install and run to check if update is fine before sending a PR.

alright, it stopped here so closing the PR :(

![image](https://user-images.githubusercontent.com/59060246/164501562-6b67fbef-112a-4fb9-9834-cfbe0a53605a.png)

Re: neovim: update to 0.7.0

[ram02z]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/36804#issuecomment-1106784197

Comment:
> alright, it stopped here so closing the PR :(
> 

LICENSE was changed to LICENSE.txt 

aarch64 build is failing, so Neovim 0.7 depends on https://github.com/void-linux/void-packages/pull/36790

Meanwhile, if you want to use Neovim on x86_64. I have nightly builds for musl and glibc. You need to add it as a custom repository.
https://github.com/ram02z/neovim-nightly

Re: neovim: update to 0.7.0.

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1107460347

Comment:
I have void-linux for more than 3 years, but recently i'm thinking more to switch to another distro,(that let me do whatever i want without any stupid limitations).

The main reason is that i still don't understand why maintainers of void insist on release versions of applications.

In my opinion, there's no single direction between "no-bug" and "high-quality" software with having "releases".

Stop this annoying policy and let people be more free.

Re: neovim: update to 0.7.0.

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1107460347

Comment:
I have void-linux for more than 3 years, but recently i'm thinking more to switch to another distro,(that let me do whatever i want without any stupid limitations).

The main reason is that i still don't understand why maintainers of void insist on release versions of applications.

In my opinion, there's no single direction between "no-bug" and "high-quality" software with having "releases".

Stop this annoying policy and let people be more free.

Re: neovim: update to 0.7.0.

[thatboyjake]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by thatboyjake on void-packages repository

https://github.com/void-linux/void-packages/pull/36823#issuecomment-1107342596

Comment:
seems like this is a pretty debated issue about LuaJIT

Re: neovim: update to 0.7.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36823#issuecomment-1107321002

Comment:
this will fail on aarch64 and is blocked by #36790 (see previous: #36704, #36804)

Re: neovim: update to 0.7.0.

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1104591240

Comment:
FYI: https://github.com/void-linux/void-packages/pull/36790 and https://github.com/CameronNemo/void-packages/commit/7ec696e5d77d8dca95677e92b6ba63f2728dbd13

Re: neovim: update to 0.7.0.

[gbrlsnchs]

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1104286148

Comment:
> @gbrlsnchs can you confirm that after compiling with `-DCOMPILE_LUA=OFF`, neovim actually works on arm64 or not? I don't the hardware to test it.

I'm also unable to test it right now, unfortunately. I just had it compiled for future usage.

Still, I don't think that breaks anything; it seems to turn off a Lua optimization where Neovim's Lua API code is compiled ahead of time instead of interpreted during runtime.

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1104121353

Comment:
@gbrlsnchs can you confirm that after compiling with `-DCOMPILE_LUA=OFF`, neovim actually works on arm64 or not? I don't the hardware to test it.

Re: neovim: update to 0.7.0.

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1104070385

Comment:
Guys, we need neovim 0.7.0

Please submit a PR if it doesn't have any issue for building in different architectures. 

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1103447036

Comment:
https://github.com/void-linux/void-packages/pull/36704#issuecomment-1101686958 is also what gpanders suggested to me on the neovim forum.

Re: neovim: update to 0.7.0.

[gbrlsnchs]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

New comment by gbrlsnchs on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1101686958

Comment:
> If anyone has any tips for the failing crossbuilds, feel free to let me know. Meanwhile I will ask on their discourse about it.

For my custom packages, I'm using the following in order to build Neovim to ARM64:
```sh
pre_configure() {
	vsed -i runtime/CMakeLists.txt \
		-e "s|\".*/bin/nvim|\${CMAKE_CROSSCOMPILING_EMULATOR} &|g"

	if [ "$CROSS_BUILD" ]; then
		# https://github.com/neovim/neovim/pull/16722#issue-1084168744
		configure_args+=" -DCOMPILE_LUA=OFF"
	fi
}
```

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1101320483

Comment:
> But there is also currently a discussion in #xbps on IRC whether we should just switch the LuaJIT package fuy to some newer git commit.

@Johnnynator For what it's worth, the neovim developers always test against the HEAD of the v2.1 branch because LuaJIT seem to not be doing any releases for the past couple of years. ~~If neovim is the only package that is using LuaJIT, you can update it whenever there a new neovim release.~~

Don't have a strong opinion on this. Just laying out what I have found from pestering the neovim developers.

Edit: Seems like a good number of other packages are using LuaJIT as well. 

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1101320483

Comment:
> But there is also currently a discussion in #xbps on IRC whether we should just switch the LuaJIT package fuy to some newer git commit.

@Johnnynator For what it's worth, the neovim developers always test against the HEAD of the v2.1 branch because LuaJIT seem to not be doing any releases for the past couple of years. If neovim is the only package that is using LuaJIT, you can update it whenever there a new neovim release.

Don't have a strong opinion on this. Just laying out what I have found from pestering the neovim developers.

Re: neovim: update to 0.7.0.

[kartikdc]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by kartikdc on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1101270345

Comment:
> But there is also currently a discussion in #xbps on IRC whether we should just switch the LuaJIT package fuy to some newer git commit.

LuaJIT seems to not be doing releases so this could be the easier option.

Re: neovim: update to 0.7.0.

[kartikdc]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New comment by kartikdc on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1101270345

Comment:
> But there is also currently a discussion in #xbps on IRC whether we should just switch the LuaJIT package fuy to some newer git commit.

LuaJIT seems to not be doing releases so this could be the easier option.

Re: neovim: update to 0.7.0.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1101234072

Comment:
> @Johnnynator sorry for pinging you. You pushed some patches in LuaJIT to fix neovim crashes. If you can tell me how you picked those patches I can do that step myself.

I just used `git bisect` to find the commit that fixed it.
But there is also currently a discussion in #xbps on IRC whether we should just switch the LuaJIT package fuy to some newer git commit.

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1101085646

Comment:
@Johnnynator sorry for pinging you. You pushed some patches in LuaJIT to fix neovim crashes. If you can tell me how you picked those patches I can do that step myself.

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1100924522

Comment:
Build succeeds with LuaJIT branch v2.1 HEAD (ddb95537645746) with these patches ported over to the updated code: `enable-debug-symbols.patch  fix-bcsave-ppc64.patch  get-rid-of-luajit-version-sym.patch`

But the repository has seen a lot of commits after the latest patch we have downstreamed:

```
luajit on  v2.1
❯ git log --since="2018-06-24T14:09:00" --grep=ARM --grep=arm64 --oneline | wc -l
31
```

Closing this since I am not sure what to do here.

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1100209395

Comment:
I am thinking it will need some LuaJIT patches to fix the crashes on aarch64. Can't think of anything else.

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1100209395

Comment:
I am thinking it will need some patches to fix the crashes on aarch64. 

Re: neovim: update to 0.7.0.

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/36704#issuecomment-1100104953

Comment:
If anyone has any tips for the failing crossbuilds, feel free to let me know. Meanwhile I will ask on their discourse about it.