Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] hooks/99-pkglint.sh: make missing shlib entry not a warning
@ 2021-08-31 19:02 Chocimier
  2022-04-21 16:36 ` [PR PATCH] [Updated] " Chocimier
  2022-04-22 19:55 ` [PR PATCH] [Merged]: " Chocimier
  0 siblings, 2 replies; 3+ messages in thread
From: Chocimier @ 2021-08-31 19:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

There is a new pull request by Chocimier against master on the void-packages repository

https://github.com/Chocimier/void-packages-org shlibs-warning
https://github.com/void-linux/void-packages/pull/32774

hooks/99-pkglint.sh: make missing shlib entry not a warning
Message is useful, but when it is a warning, clueless people add *any* missing entry.

A patch file from https://github.com/void-linux/void-packages/pull/32774.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shlibs-warning-32774.patch --]
[-- Type: text/x-diff, Size: 853 bytes --]

From 40baec0d388d83948e58698f831527d898335fdd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Tue, 31 Aug 2021 21:00:01 +0200
Subject: [PATCH] hooks/99-pkglint.sh: make missing shlib entry not a warning

---
 common/hooks/pre-pkg/99-pkglint.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/hooks/pre-pkg/99-pkglint.sh b/common/hooks/pre-pkg/99-pkglint.sh
index ea73c961ec5b..325938f5d541 100644
--- a/common/hooks/pre-pkg/99-pkglint.sh
+++ b/common/hooks/pre-pkg/99-pkglint.sh
@@ -182,7 +182,7 @@ hook() {
 			if [ -z "$found" ]; then
 				_myshlib="${libname}.so"
 				[ "${_myshlib}" != "${rev}" ] && _myshlib+=".${rev}"
-				msg_warn "${pkgver}: ${_myshlib} not found in common/shlibs!\n"
+				msg_normal "${pkgver}: ${_myshlib} not found in common/shlibs.\n"
 			fi;
 		}
 	done

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Updated] hooks/99-pkglint.sh: make missing shlib entry not a warning
  2021-08-31 19:02 [PR PATCH] hooks/99-pkglint.sh: make missing shlib entry not a warning Chocimier
@ 2022-04-21 16:36 ` Chocimier
  2022-04-22 19:55 ` [PR PATCH] [Merged]: " Chocimier
  1 sibling, 0 replies; 3+ messages in thread
From: Chocimier @ 2022-04-21 16:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

There is an updated pull request by Chocimier against master on the void-packages repository

https://github.com/Chocimier/void-packages-org shlibs-warning
https://github.com/void-linux/void-packages/pull/32774

hooks/99-pkglint.sh: make missing shlib entry not a warning
Message is useful, but when it is a warning, clueless people add *any* missing entry.

A patch file from https://github.com/void-linux/void-packages/pull/32774.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shlibs-warning-32774.patch --]
[-- Type: text/x-diff, Size: 853 bytes --]

From 114d15196d3fc0a875027267e27af3baf801953f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Tue, 31 Aug 2021 21:00:01 +0200
Subject: [PATCH] hooks/99-pkglint.sh: make missing shlib entry not a warning

---
 common/hooks/pre-pkg/99-pkglint.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/hooks/pre-pkg/99-pkglint.sh b/common/hooks/pre-pkg/99-pkglint.sh
index ea73c961ec5b..325938f5d541 100644
--- a/common/hooks/pre-pkg/99-pkglint.sh
+++ b/common/hooks/pre-pkg/99-pkglint.sh
@@ -182,7 +182,7 @@ hook() {
 			if [ -z "$found" ]; then
 				_myshlib="${libname}.so"
 				[ "${_myshlib}" != "${rev}" ] && _myshlib+=".${rev}"
-				msg_warn "${pkgver}: ${_myshlib} not found in common/shlibs!\n"
+				msg_normal "${pkgver}: ${_myshlib} not found in common/shlibs.\n"
 			fi;
 		}
 	done

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: hooks/99-pkglint.sh: make missing shlib entry not a warning
  2021-08-31 19:02 [PR PATCH] hooks/99-pkglint.sh: make missing shlib entry not a warning Chocimier
  2022-04-21 16:36 ` [PR PATCH] [Updated] " Chocimier
@ 2022-04-22 19:55 ` Chocimier
  1 sibling, 0 replies; 3+ messages in thread
From: Chocimier @ 2022-04-22 19:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

There's a merged pull request on the void-packages repository

hooks/99-pkglint.sh: make missing shlib entry not a warning
https://github.com/void-linux/void-packages/pull/32774

Description:
Message is useful, but when it is a warning, clueless people add *any* missing entry.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-22 19:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 19:02 [PR PATCH] hooks/99-pkglint.sh: make missing shlib entry not a warning Chocimier
2022-04-21 16:36 ` [PR PATCH] [Updated] " Chocimier
2022-04-22 19:55 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).