Github messages for voidlinux
 help / color / mirror / Atom feed
From: zlice <zlice@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Fluxbox switch source
Date: Tue, 26 Apr 2022 17:41:36 +0200	[thread overview]
Message-ID: <20220426154136.Kj4IrRnp0uLLmO_qvlCJtFLo5yZ5IzFQmYrOUcMWQ2I@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36863@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

There is an updated pull request by zlice against master on the void-packages repository

https://github.com/zlice/void-packages fluxbox_switch_source
https://github.com/void-linux/void-packages/pull/36863

Fluxbox switch source
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Comments

Ran into issues with the sourceforge tar using pregenerated aclocal.m4/make files. Saw that github is getting commits here and there and the source has autogen.sh so I built from there.

There are a few file differences from the sourceforge tar. From what I can tell:

 - a `defaults.cc` generated by a makefile?
 - some `tests/` are in github that aren't in sourceforge
 - already made languages files in sourceforge
 - updated docs that aren't in sourceforge

A patch file from https://github.com/void-linux/void-packages/pull/36863.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fluxbox_switch_source-36863.patch --]
[-- Type: text/x-diff, Size: 1993 bytes --]

From 6c7bd4af3f7442fa50166cf7f75e07db918d2e68 Mon Sep 17 00:00:00 2001
From: zlice <zlice555@gmail.com>
Date: Mon, 25 Apr 2022 22:41:33 -0400
Subject: [PATCH] fluxbox: build from github

---
 srcpkgs/fluxbox/template | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/fluxbox/template b/srcpkgs/fluxbox/template
index 3328421d91ac..db5c61f17e95 100644
--- a/srcpkgs/fluxbox/template
+++ b/srcpkgs/fluxbox/template
@@ -1,26 +1,32 @@
 # Template file for 'fluxbox'
 pkgname=fluxbox
 version=1.3.7
-revision=3
+revision=4
+wrksrc=fluxbox-Release-${version//./_}
 build_style=gnu-configure
 configure_args="--enable-nls
  ac_cv_lib_X11_XOpenDisplay=yes ac_cv_lib_Xft_XftFontOpen=yes
  ac_cv_lib_Xrender_XRenderCreatePicture=yes ac_cv_lib_Xpm_XpmReadFileToPixmap=yes
  ac_cv_lib_Xinerama_XineramaQueryScreens=yes ac_cv_lib_Xext_XShapeCombineShape=yes
  ac_cv_lib_Xrandr_XRRQueryExtension=yes ac_cv_lib_fribidi_fribidi_version_info=yes"
-hostmakedepends="pkg-config"
+hostmakedepends="pkg-config automake libtool gettext gettext-devel"
 makedepends="libSM-devel libXrender-devel libXft-devel libXpm-devel imlib2-devel
  libXext-devel libXinerama-devel libXrandr-devel fribidi-devel"
 short_desc="Highly configurable and low resource X11 Window manager"
 maintainer="Orphaned <orphan@voidlinux.org>"
-homepage="http://www.fluxbox.org"
 license="MIT"
-distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.xz"
-checksum=fc8c75fe94c54ed5a5dd3fd4a752109f8949d6df67a48e5b11a261403c382ec0
+homepage="http://www.fluxbox.org"
+distfiles="https://github.com/fluxbox/fluxbox/archive/refs/tags/Release-${version//./_}.tar.gz"
+checksum=990414ae342a35c5703e5025a8bf019b0b4dada55d57071c51d3d498abb5cd36
 
 case "$XBPS_TARGET_MACHINE" in
 	*-musl) configure_args="${configure_args/enable-nls/disable-nls}" ;;
 esac
+
+pre_configure() {
+	./autogen.sh
+}
+
 post_install() {
 	vinstall ${FILESDIR}/fluxbox.desktop 644 usr/share/xsessions
 	vlicense COPYING

  parent reply	other threads:[~2022-04-26 15:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26  2:55 [PR PATCH] " zlice
2022-04-26  2:56 ` [PR PATCH] [Updated] " zlice
2022-04-26 15:37 ` [PR REVIEW] " classabbyamp
2022-04-26 15:37 ` classabbyamp
2022-04-26 15:41 ` zlice [this message]
2022-04-26 15:42 ` zlice
2022-04-26 15:47 ` classabbyamp
2022-07-01  5:49 ` classabbyamp
2022-07-01 11:57 ` [PR PATCH] [Updated] " zlice
2022-08-21 19:00 ` classabbyamp
2022-08-21 19:06 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220426154136.Kj4IrRnp0uLLmO_qvlCJtFLo5yZ5IzFQmYrOUcMWQ2I@z \
    --to=zlice@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).